Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support logging of arbitrary binary payload #1249

Conversation

rwalker-apple
Copy link
Contributor

Problem

hoping a binary string will "just print" seems error-prone

Summary of Changes

sanitize to something like "od -c"

@woody-apple
Copy link
Contributor

@rwalker-apple conflict here

@jelderton @saurabhst ?

@woody-apple woody-apple self-requested a review June 25, 2020 21:59
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @andy31415 's suggestions, and also needs merge fix :)

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@rwalker-apple rwalker-apple force-pushed the support-logging-of-arbitrary-binary-payload branch from 6637227 to 982fa85 Compare June 25, 2020 23:14
@rwalker-apple
Copy link
Contributor Author

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .flash.text 172 172
chip-wifi-echo.elf .dram0.bss 0 8
chip-wifi-echo.elf .dram0.data -8 -8
Full report output

oh noes! 172 bytes more code

@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .flash.text 172 172
Full report output
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.debug_line,0,546
.debug_loc,0,478
.debug_info,0,420
.flash.text,172,172
.debug_abbrev,0,137
.debug_ranges,0,128
.debug_str,0,41
.strtab,0,11
[Unmapped],0,3


@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize


@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize


@rwalker-apple
Copy link
Contributor Author

I think I’ve addressed change requests.

@gerickson
Copy link
Contributor

@rwalker-apple
Copy link
Contributor Author

@woody-apple
Copy link
Contributor

@saurabhst @jelderton ?

@woody-apple woody-apple merged commit 86cc404 into project-chip:master Jun 26, 2020
@rwalker-apple rwalker-apple deleted the support-logging-of-arbitrary-binary-payload branch June 26, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants