-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support logging of arbitrary binary payload #1249
support logging of arbitrary binary payload #1249
Conversation
@rwalker-apple conflict here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like @andy31415 's suggestions, and also needs merge fix :)
6637227
to
982fa85
Compare
oh noes! 172 bytes more code |
Size increase report for "Build Examples [ESP32]"
Full report output
|
Size increase report for "Build Examples [main-build]"
Full report output
|
Size increase report for "Build Examples [nRF]"
Full report output
|
I think I’ve addressed change requests. |
Seems fine, though we could have leveraged https://github.com/openweave/openweave-core/blob/master/src/test-apps/ToolCommon.cpp#L1336. |
Problem
hoping a binary string will "just print" seems error-prone
Summary of Changes
sanitize to something like "od -c"