Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore StartupMode when rebooting due to OTA. #21074

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Ignore StartupMode when rebooting due to OTA. #21074

merged 2 commits into from
Jul 23, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes #19272

This will only work on platforms that actually set boot reasons
properly (i.e. probably not Mac/Linux).

Problem

See #19272.

Change overview

Change StartupMode handling to ignore the attribute when rebooting for OTA. This is extracted from #20440

Testing

  1. Made sure that normal restart of all-clusters-app on Mac picks up the StartupMode.
  2. Hacked up the Darwin version of DiagnosticDataProviderImpl::GetBootReason to return kSoftwareUpdateCompleted and verified that in this case the pre-restart CurrentMode value sticks around instead of StartupMode overwriting it.

@isiu-apple @bzbarsky-apple
Ignore StartupMode when rebooting due to OTA.
9e7b8a8 
Fixes project-chip#19272

This will only work on platforms that actually set boot reasons
properly (i.e. probably not Mac/Linux).
@woody-apple woody-apple enabled auto-merge (squash) July 21, 2022 20:09
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #21074: Size comparison from 1d88b32 to 9e7b8a8

Increases (13 builds for cc13x2_26x2, esp32, linux, nrfconnect, p6, telink)
platform target config section 1d88b32 9e7b8a8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668415 88 0.0
.rodata 88311 88351 40 0.0
.text 579700 579748 48 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 634039 104 0.0
.rodata 77551 77583 32 0.0
.text 556060 556132 72 0.0
shell LP_CC2652R7 (read only) 660810 660906 96 0.0
.rodata 85090 85122 32 0.0
.text 575404 575468 64 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1021996 66 0.0
(read/write) 1486282 1486370 88 0.0
.flash.rodata 216008 216096 88 0.0
.flash.text 1021930 1021996 66 0.0
m5stack (read only) 1075691 1075767 76 0.0
(read/write) 488304 488384 80 0.0
.flash.rodata 246412 246492 80 0.0
.flash.text 1070307 1070383 76 0.0
linux all-clusters-app debug (read only) 2981121 2981489 368 0.0
.rodata 265707 265899 192 0.1
.text 2537298 2537474 176 0.0
all-clusters-minimal-app debug (read only) 2827073 2827473 400 0.0
.rodata 266603 266827 224 0.1
.text 2385010 2385186 176 0.0
shell debug (read only) 2567729 2568129 400 0.0
.rodata 229010 229234 224 0.1
.text 2181186 2181362 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176527 144 0.0
rodata 142200 142280 80 0.1
text 812248 812316 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156591 144 0.0
rodata 133744 133824 80 0.1
text 801564 801632 68 0.0
p6 all-clusters-app default (read/write) 1686428 1686580 152 0.0
.text 1526328 1526480 152 0.0
all-clusters-minimal-app default (read/write) 1630540 1630708 168 0.0
.text 1471160 1471328 168 0.0
telink light-switch-app tlsr9518adk80d text 566822 566824 2 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
platform target config section 1d88b32 9e7b8a8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183016 182928 -88 -0.0
shell LP_CC2652R7 (read/write) 186036 185940 -96 -0.1
cyw30739 lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 818908 818900 -8 -0.0
text 583370 583368 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1d88b32 9e7b8a8 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380794 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1050932 0 0.0
bl602+rpc (read/write) 1426202 1426202 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082588 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668327 668415 88 0.0
(read/write) 183016 182928 -88 -0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88351 40 0.0
.text 579700 579748 48 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633935 634039 104 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77583 32 0.0
.text 556060 556132 72 0.0
lock-ftd LP_CC2652R7 (read only) 671555 671555 0 0.0
(read/write) 169964 169964 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594632 594632 0 0.0
lock-mtd LP_CC2652R7 (read only) 653839 653839 0 0.0
(read/write) 183368 183368 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 552176 552176 0 0.0
pump-app LP_CC2652R7 (read only) 680579 680579 0 0.0
(read/write) 161796 161796 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 591284 591284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666355 666355 0 0.0
(read/write) 176140 176140 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84667 0 0.0
.text 581208 581208 0 0.0
shell LP_CC2652R7 (read only) 660810 660906 96 0.0
(read/write) 186036 185940 -96 -0.1
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85122 32 0.0
.text 575404 575468 64 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582050 582050 0 0.0
.app_xip_area 460440 460440 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587966 587958 -8 -0.0
.app_xip_area 461628 461620 -8 -0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585430 585430 0 0.0
.app_xip_area 464668 464668 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086760 1086760 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951472 951472 0 0.0
BRD4161A+rpc (read/write) 1141036 1141036 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988860 988860 0 0.0
BRD4161A+rs911x (read/write) 972716 972716 0 0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 808984 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128224 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 981844 0 0.0
window-app BRD4161A (read/write) 1080236 1080236 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943448 943448 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021930 1021996 66 0.0
(read/write) 1486282 1486370 88 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216096 88 0.0
.flash.text 1021930 1021996 66 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075691 1075767 76 0.0
(read/write) 488304 488384 80 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246492 80 0.0
.flash.text 1070307 1070383 76 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660784 660784 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583324 583324 0 0.0
lock k32w061+release (read/write) 687788 687788 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609844 609844 0 0.0
linux all-clusters-app debug (read only) 2981121 2981489 368 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265707 265899 192 0.1
.text 2537298 2537474 176 0.0
all-clusters-minimal-app debug (read only) 2827073 2827473 400 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266827 224 0.1
.text 2385010 2385186 176 0.0
bridge-app debug+rpc (read only) 2341705 2341705 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199208 199208 0 0.0
.text 1980210 1980210 0 0.0
chip-tool debug (read only) 10350497 10350497 0 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521525 521525 0 0.0
.text 8375380 8375380 0 0.0
chip-tool-ipv6only arm64 (read only) 9774108 9774108 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457340 0 0.0
.text 7732372 7732372 0 0.0
lighting-app debug+rpc (read only) 2564897 2564897 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214896 214896 0 0.0
.text 2179602 2179602 0 0.0
lock-app debug (read only) 2529921 2529921 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229936 0 0.0
.text 2134386 2134386 0 0.0
ota-provider-app debug (read only) 2333505 2333505 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1965570 1965570 0 0.0
ota-requestor-app debug (read only) 2451961 2451961 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208448 0 0.0
.text 2071906 2071906 0 0.0
shell debug (read only) 2567729 2568129 400 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229010 229234 224 0.1
.text 2181186 2181362 176 0.0
thermostat-no-ble arm64 (read only) 2341476 2341476 0 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139420 0 0.0
.text 1965248 1965248 0 0.0
tv-app debug (read only) 3115497 3115497 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250408 250408 0 0.0
.text 2676690 2676690 0 0.0
tv-casting-app debug (read only) 5369113 5369113 0 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334561 334561 0 0.0
.text 4768050 4768050 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176383 1176527 144 0.0
bss 143068 143068 0 0.0
rodata 142200 142280 80 0.1
text 812248 812316 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156447 1156591 144 0.0
bss 142304 142304 0 0.0
rodata 133744 133824 80 0.1
text 801564 801632 68 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686428 1686580 152 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526328 1526480 152 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630708 168 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471328 168 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1550780 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1399704 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588372 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1432824 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798852 798852 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566822 566824 2 0.0
lighting-app tlsr9518adk80d (read/write) 818908 818900 -8 -0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583370 583368 -2 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the fix-mode-select-boot-reason branch from cb966e7 to 2ded613 Compare July 23, 2022 01:26
@github-actions
Copy link

github-actions bot commented Jul 23, 2022 •
edited
Loading

PR #21074: Size comparison from e58147e to 2ded613

Increases (17 builds for bl602, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, p6, telink)
platform target config section e58147e 2ded613 change % change
bl602 lighting-app bl602+rpc .text 1082600 1082604 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668479 96 0.0
.rodata 88335 88367 32 0.0
.text 579732 579796 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633983 634063 80 0.0
.rodata 77559 77591 32 0.0
.text 556100 556148 48 0.0
lock-ftd LP_CC2652R7 (read only) 671595 671603 8 0.0
.text 594664 594672 8 0.0
shell LP_CC2652R7 (read only) 660866 660954 88 0.0
.rodata 85106 85146 40 0.0
.text 575444 575492 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582034 582042 8 0.0
.app_xip_area 460424 460432 8 0.0
esp32 all-clusters-app c3devkit (read only) 1021958 1022020 62 0.0
(read/write) 1486434 1486522 88 0.0
.flash.rodata 216160 216248 88 0.0
.flash.text 1021958 1022020 62 0.0
m5stack (read only) 1075723 1075795 72 0.0
(read/write) 488448 488528 80 0.0
.flash.rodata 246556 246636 80 0.0
.flash.text 1070339 1070411 72 0.0
linux all-clusters-app debug (read only) 2981689 2982089 400 0.0
.rodata 265867 266091 224 0.1
.text 2537682 2537858 176 0.0
all-clusters-minimal-app debug (read only) 2827585 2827985 400 0.0
.rodata 266731 266955 224 0.1
.text 2385394 2385570 176 0.0
shell debug (read only) 2568297 2568697 400 0.0
.rodata 229170 229394 224 0.1
.text 2181570 2181746 176 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177091 1177235 144 0.0
rodata 142572 142652 80 0.1
text 812588 812656 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157143 1157287 144 0.0
rodata 134104 134184 80 0.1
text 801900 801968 68 0.0
p6 all-clusters-app default (read/write) 1686628 1686780 152 0.0
.text 1526528 1526680 152 0.0
all-clusters-minimal-app default (read/write) 1630732 1630884 152 0.0
.text 1471352 1471504 152 0.0
telink light-switch-app tlsr9518adk80d text 567210 567214 4 0.0
lighting-app tlsr9518adk80d text 583756 583758 2 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section e58147e 2ded613 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182960 182864 -96 -0.1
lock-ftd LP_CC2652R7 (read/write) 169924 169916 -8 -0.0
shell LP_CC2652R7 (read/write) 185980 185892 -88 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e58147e 2ded613 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380794 0 0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050944 1050944 0 0.0
bl602+rpc (read/write) 1426202 1426202 0 0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082600 1082604 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668479 96 0.0
(read/write) 182960 182864 -96 -0.1
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88335 88367 32 0.0
.text 579732 579796 64 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633983 634063 80 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77559 77591 32 0.0
.text 556100 556148 48 0.0
lock-ftd LP_CC2652R7 (read only) 671595 671603 8 0.0
(read/write) 169924 169916 -8 -0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76451 0 0.0
.text 594664 594672 8 0.0
lock-mtd LP_CC2652R7 (read only) 653847 653847 0 0.0
(read/write) 183360 183360 0 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101167 101167 0 0.0
.text 552200 552200 0 0.0
pump-app LP_CC2652R7 (read only) 681271 681271 0 0.0
(read/write) 161104 161104 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89183 89183 0 0.0
.text 591604 591604 0 0.0
pump-controller-app LP_CC2652R7 (read only) 667039 667039 0 0.0
(read/write) 175456 175456 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 85039 85039 0 0.0
.text 581520 581520 0 0.0
shell LP_CC2652R7 (read only) 660866 660954 88 0.0
(read/write) 185980 185892 -88 -0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85106 85146 40 0.0
.text 575444 575492 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582034 582042 8 0.0
.app_xip_area 460424 460432 8 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587942 587942 0 0.0
.app_xip_area 461604 461604 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586494 586494 0 0.0
.app_xip_area 465732 465732 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087680 1087680 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952392 952392 0 0.0
BRD4161A+rpc (read/write) 1141972 1141972 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989796 989796 0 0.0
BRD4161A+rs911x (read/write) 952180 952180 0 0.0
.bss 140928 140928 0 0.0
.data 2048 2048 0 0.0
.text 809184 809184 0 0.0
lock-app BRD4161A+wf200 (read/write) 1128424 1128424 0 0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 982044 982044 0 0.0
window-app BRD4161A (read/write) 1081156 1081156 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944368 944368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021958 1022020 62 0.0
(read/write) 1486434 1486522 88 0.0
.dram0.bss 70232 70232 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216160 216248 88 0.0
.flash.text 1021958 1022020 62 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075723 1075795 72 0.0
(read/write) 488448 488528 80 0.0
.dram0.bss 75752 75752 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246556 246636 80 0.0
.flash.text 1070339 1070411 72 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 641520 641520 0 0.0
.bss 69696 69696 0 0.0
.data 2028 2028 0 0.0
.text 567068 567068 0 0.0
lock k32w0+release (read/write) 698880 698880 0 0.0
.bss 70144 70144 0 0.0
.data 2036 2036 0 0.0
.text 623972 623972 0 0.0
linux all-clusters-app debug (read only) 2981689 2982089 400 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265867 266091 224 0.1
.text 2537682 2537858 176 0.0
all-clusters-minimal-app debug (read only) 2827585 2827985 400 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266731 266955 224 0.1
.text 2385394 2385570 176 0.0
bridge-app debug+rpc (read only) 2342289 2342289 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199368 199368 0 0.0
.text 1980610 1980610 0 0.0
chip-tool debug (read only) 10349889 10349889 0 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 522005 522005 0 0.0
.text 8374292 8374292 0 0.0
chip-tool-ipv6only arm64 (read only) 9779324 9779324 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457724 457724 0 0.0
.text 7737204 7737204 0 0.0
lighting-app debug+rpc (read only) 2565441 2565441 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 215056 215056 0 0.0
.text 2179986 2179986 0 0.0
lock-app debug (read only) 2530433 2530433 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 230064 230064 0 0.0
.text 2134770 2134770 0 0.0
ota-provider-app debug (read only) 2334081 2334081 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204920 204920 0 0.0
.text 1965954 1965954 0 0.0
ota-requestor-app debug (read only) 2452505 2452505 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208608 208608 0 0.0
.text 2072290 2072290 0 0.0
shell debug (read only) 2568297 2568697 400 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229170 229394 224 0.1
.text 2181570 2181746 176 0.0
thermostat-no-ble arm64 (read only) 2341916 2341916 0 0.0
(read/write) 141249 141249 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75592 75592 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139572 139572 0 0.0
.text 1965536 1965536 0 0.0
tv-app debug (read only) 3116033 3116033 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250568 250568 0 0.0
.text 2677042 2677042 0 0.0
tv-casting-app debug (read only) 5369777 5369777 0 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334753 334753 0 0.0
.text 4768498 4768498 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449240 2449240 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411884 1411884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177091 1177235 144 0.0
bss 143068 143068 0 0.0
rodata 142572 142652 80 0.1
text 812588 812656 68 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157143 1157287 144 0.0
bss 142304 142304 0 0.0
rodata 134104 134184 80 0.1
text 801900 801968 68 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686628 1686780 152 0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526528 1526680 152 0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630732 1630884 152 0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471352 1471504 152 0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550972 1550972 0 0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399896 1399896 0 0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588564 1588564 0 0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1433016 1433016 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799620 799620 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567210 567214 4 0.0
lighting-app tlsr9518adk80d (read/write) 819668 819668 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583756 583758 2 0.0

@woody-apple woody-apple merged commit b647dfb into project-chip:master Jul 23, 2022
github-actions bot pushed a commit that referenced this pull request Jul 23, 2022
@bzbarsky-apple @isiu-apple @web-flow
Ignore StartupMode when rebooting due to OTA. (#21074)
ceb0676 
Fixes #19272

This will only work on platforms that actually set boot reasons
properly (i.e. probably not Mac/Linux).

Co-authored-by: Irene Siu (Apple) <98558756+isiu-apple@users.noreply.github.com>
@bzbarsky-apple bzbarsky-apple deleted the fix-mode-select-boot-reason branch July 23, 2022 05:29
woody-apple added a commit that referenced this pull request Jul 25, 2022
@woody-apple @bzbarsky-apple @isiu-apple
Ignore StartupMode when rebooting due to OTA. (#21074) (#21141)
53ea33d 
Fixes #19272

This will only work on platforms that actually set boot reasons
properly (i.e. probably not Mac/Linux).

Co-authored-by: Irene Siu (Apple) <98558756+isiu-apple@users.noreply.github.com>

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Irene Siu (Apple) <98558756+isiu-apple@users.noreply.github.com>
isiu-apple added a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@bzbarsky-apple @isiu-apple
Ignore StartupMode when rebooting due to OTA. (project-chip#21074)
da8d6b5 
Fixes project-chip#19272

This will only work on platforms that actually set boot reasons
properly (i.e. probably not Mac/Linux).

Co-authored-by: Irene Siu (Apple) <98558756+isiu-apple@users.noreply.github.com>
@j0tunn j0tunn mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app cert blocker darwin examples lib platform review - approved support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pre-sve] TC-MOD-3.3 The mode backs to the start-up-mode value after matter ota.
4 participants
@bzbarsky-apple @andy31415 @woody-apple @isiu-apple