Se05x HSM support in thermostat example #22220
+1,029
−31
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,298 @@ | ||
| /* | ||
| * | ||
| * Copyright (c) 2021 Project CHIP Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #include "DeviceAttestationSe05xCredsExample.h" | ||
|
|
||
| #include <credentials/examples/ExampleDACs.h> | ||
| #include <credentials/examples/ExamplePAI.h> | ||
| #include <crypto/CHIPCryptoPAL.h> | ||
| #include <lib/core/CHIPError.h> | ||
| #include <lib/core/CHIPTLV.h> | ||
| #include <lib/core/CHIPTLVTags.h> | ||
| #include <lib/core/CHIPTLVTypes.h> | ||
| #include <lib/core/CHIPTLVUtilities.hpp> | ||
| #include <lib/support/Span.h> | ||
|
|
||
| #if CHIP_CRYPTO_HSM | ||
| #include <crypto/hsm/CHIPCryptoPALHsm.h> | ||
| #endif | ||
|
|
||
| #ifdef ENABLE_HSM_DEVICE_ATTESTATION | ||
|
|
||
| #include <crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_utils.h> | ||
|
|
||
| /* Device attestation key ids */ | ||
| #define DEV_ATTESTATION_KEY_SE05X_ID 0x7D300000 | ||
| #define DEV_ATTESTATION_CERT_SE05X_ID 0x7D300001 | ||
|
|
||
| /* Device attestation key ids (Used with internal sign) */ | ||
| #define CD_DEV_ATTESTATION_KEY_SE05X_ID 0x7D300002 | ||
| #define NOCSR_DEV_ATTESTATION_KEY_SE05X_ID 0x7D300004 | ||
|
|
||
| /* Device attestation data ids (for Cert decl) */ | ||
| #define CD_CERT_DECLARATION_DATA_SE05X_ID 0x7D300009 | ||
| #define CD_ATTEST_NONCE_DATA_SE05X_ID 0x7D30000C | ||
| #define CD_TIME_STAMP_LEN_SE05X_ID 0x7D30000E | ||
| #define CD_TIME_STAMP_DATA_SE05X_ID 0x7D30000F | ||
| #define CD_ATTEST_CHALLENGE_SE05X_ID 0x7D300011 | ||
|
|
||
| /* Device attestation data ids (for CSR) */ | ||
| #define NOCSR_CSR_LEN_SE05X_ID 0x7D300014 | ||
| #define NOCSR_CSR_DATA_SE05X_ID 0x7D300015 | ||
| #define NOCSR_CSR_NONCE_DATA_SE05X_ID 0x7D300018 | ||
| #define NOCSR_ATTEST_CHALLENGE_SE05X_ID 0x7D30001A | ||
|
|
||
| extern CHIP_ERROR se05xGetCertificate(uint32_t keyId, uint8_t * buf, size_t * buflen); | ||
| extern CHIP_ERROR se05xSetCertificate(uint32_t keyId, const uint8_t * buf, size_t buflen); | ||
| extern CHIP_ERROR se05xPerformInternalSign(uint32_t keyId, uint8_t * sigBuf, size_t * sigBufLen); | ||
| extern void se05x_delete_key(uint32_t keyid); | ||
|
|
||
| namespace chip { | ||
| namespace Credentials { | ||
| namespace Examples { | ||
|
|
||
| namespace { | ||
|
|
||
| class ExampleSe05xDACProviderv2 : public DeviceAttestationCredentialsProvider | ||
| { | ||
| public: | ||
| CHIP_ERROR GetCertificationDeclaration(MutableByteSpan & out_cd_buffer) override; | ||
| CHIP_ERROR GetFirmwareInformation(MutableByteSpan & out_firmware_info_buffer) override; | ||
| CHIP_ERROR GetDeviceAttestationCert(MutableByteSpan & out_dac_buffer) override; | ||
| CHIP_ERROR GetProductAttestationIntermediateCert(MutableByteSpan & out_pai_buffer) override; | ||
| CHIP_ERROR SignWithDeviceAttestationKey(const ByteSpan & message_to_sign, MutableByteSpan & out_signature_buffer) override; | ||
| }; | ||
|
|
||
| CHIP_ERROR ExampleSe05xDACProviderv2::GetDeviceAttestationCert(MutableByteSpan & out_dac_buffer) | ||
| { | ||
| #if 0 | ||
| return CopySpanToMutableSpan(DevelopmentCerts::kDacCert, out_dac_buffer); | ||
| #else | ||
| size_t buflen = out_dac_buffer.size(); | ||
| ChipLogDetail(Crypto, "Get DA certificate from se05x"); | ||
| ReturnErrorOnFailure(se05xGetCertificate(DEV_ATTESTATION_CERT_SE05X_ID, out_dac_buffer.data(), &buflen)); | ||
| out_dac_buffer.reduce_size(buflen); | ||
| return CHIP_NO_ERROR; | ||
| #endif | ||
| } | ||
|
|
||
| CHIP_ERROR ExampleSe05xDACProviderv2::GetProductAttestationIntermediateCert(MutableByteSpan & out_pai_buffer) | ||
| { | ||
| return CopySpanToMutableSpan(ByteSpan(DevelopmentCerts::kPaiCert), out_pai_buffer); | ||
| } | ||
|
|
||
| CHIP_ERROR ExampleSe05xDACProviderv2::GetCertificationDeclaration(MutableByteSpan & out_cd_buffer) | ||
| { | ||
| //-> format_version = 1 | ||
| //-> vendor_id = 0xFFF1 | ||
| //-> product_id_array = [ 0x8000, 0x8001, 0x8002, 0x8003, 0x8004, 0x8005, 0x8006, 0x8007, 0x8008, 0x8009, 0x800A, 0x800B, | ||
| // 0x800C, 0x800D, 0x800E, 0x800F, 0x8010, 0x8011, 0x8012, 0x8013, 0x8014, 0x8015, 0x8016, 0x8017, 0x8018, 0x8019, 0x801A, | ||
| // 0x801B, 0x801C, 0x801D, 0x801E, 0x801F, 0x8020, 0x8021, 0x8022, 0x8023, 0x8024, 0x8025, 0x8026, 0x8027, 0x8028, 0x8029, | ||
| // 0x802A, 0x802B, 0x802C, 0x802D, 0x802E, 0x802F, 0x8030, 0x8031, 0x8032, 0x8033, 0x8034, 0x8035, 0x8036, 0x8037, 0x8038, | ||
| // 0x8039, 0x803A, 0x803B, 0x803C, 0x803D, 0x803E, 0x803F, 0x8040, 0x8041, 0x8042, 0x8043, 0x8044, 0x8045, 0x8046, 0x8047, | ||
| // 0x8048, 0x8049, 0x804A, 0x804B, 0x804C, 0x804D, 0x804E, 0x804F, 0x8050, 0x8051, 0x8052, 0x8053, 0x8054, 0x8055, 0x8056, | ||
| // 0x8057, 0x8058, 0x8059, 0x805A, 0x805B, 0x805C, 0x805D, 0x805E, 0x805F, 0x8060, 0x8061, 0x8062, 0x8063 ] | ||
| //-> device_type_id = 0x0016 | ||
| //-> certificate_id = "ZIG20142ZB330003-24" | ||
| //-> security_level = 0 | ||
| //-> security_information = 0 | ||
| //-> version_number = 0x2694 | ||
| //-> certification_type = 0 | ||
| //-> dac_origin_vendor_id is not present | ||
| //-> dac_origin_product_id is not present | ||
| #if 0 | ||
| const uint8_t kCdForAllExamples[541] = { | ||
| 0x30, 0x82, 0x02, 0x19, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d, 0x01, 0x07, 0x02, 0xa0, 0x82, 0x02, 0x0a, 0x30, | ||
| 0x82, 0x02, 0x06, 0x02, 0x01, 0x03, 0x31, 0x0d, 0x30, 0x0b, 0x06, 0x09, 0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, | ||
| 0x01, 0x30, 0x82, 0x01, 0x71, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d, 0x01, 0x07, 0x01, 0xa0, 0x82, 0x01, 0x62, | ||
| 0x04, 0x82, 0x01, 0x5e, 0x15, 0x24, 0x00, 0x01, 0x25, 0x01, 0xf1, 0xff, 0x36, 0x02, 0x05, 0x00, 0x80, 0x05, 0x01, 0x80, | ||
| 0x05, 0x02, 0x80, 0x05, 0x03, 0x80, 0x05, 0x04, 0x80, 0x05, 0x05, 0x80, 0x05, 0x06, 0x80, 0x05, 0x07, 0x80, 0x05, 0x08, | ||
| 0x80, 0x05, 0x09, 0x80, 0x05, 0x0a, 0x80, 0x05, 0x0b, 0x80, 0x05, 0x0c, 0x80, 0x05, 0x0d, 0x80, 0x05, 0x0e, 0x80, 0x05, | ||
| 0x0f, 0x80, 0x05, 0x10, 0x80, 0x05, 0x11, 0x80, 0x05, 0x12, 0x80, 0x05, 0x13, 0x80, 0x05, 0x14, 0x80, 0x05, 0x15, 0x80, | ||
| 0x05, 0x16, 0x80, 0x05, 0x17, 0x80, 0x05, 0x18, 0x80, 0x05, 0x19, 0x80, 0x05, 0x1a, 0x80, 0x05, 0x1b, 0x80, 0x05, 0x1c, | ||
| 0x80, 0x05, 0x1d, 0x80, 0x05, 0x1e, 0x80, 0x05, 0x1f, 0x80, 0x05, 0x20, 0x80, 0x05, 0x21, 0x80, 0x05, 0x22, 0x80, 0x05, | ||
| 0x23, 0x80, 0x05, 0x24, 0x80, 0x05, 0x25, 0x80, 0x05, 0x26, 0x80, 0x05, 0x27, 0x80, 0x05, 0x28, 0x80, 0x05, 0x29, 0x80, | ||
| 0x05, 0x2a, 0x80, 0x05, 0x2b, 0x80, 0x05, 0x2c, 0x80, 0x05, 0x2d, 0x80, 0x05, 0x2e, 0x80, 0x05, 0x2f, 0x80, 0x05, 0x30, | ||
| 0x80, 0x05, 0x31, 0x80, 0x05, 0x32, 0x80, 0x05, 0x33, 0x80, 0x05, 0x34, 0x80, 0x05, 0x35, 0x80, 0x05, 0x36, 0x80, 0x05, | ||
| 0x37, 0x80, 0x05, 0x38, 0x80, 0x05, 0x39, 0x80, 0x05, 0x3a, 0x80, 0x05, 0x3b, 0x80, 0x05, 0x3c, 0x80, 0x05, 0x3d, 0x80, | ||
| 0x05, 0x3e, 0x80, 0x05, 0x3f, 0x80, 0x05, 0x40, 0x80, 0x05, 0x41, 0x80, 0x05, 0x42, 0x80, 0x05, 0x43, 0x80, 0x05, 0x44, | ||
| 0x80, 0x05, 0x45, 0x80, 0x05, 0x46, 0x80, 0x05, 0x47, 0x80, 0x05, 0x48, 0x80, 0x05, 0x49, 0x80, 0x05, 0x4a, 0x80, 0x05, | ||
| 0x4b, 0x80, 0x05, 0x4c, 0x80, 0x05, 0x4d, 0x80, 0x05, 0x4e, 0x80, 0x05, 0x4f, 0x80, 0x05, 0x50, 0x80, 0x05, 0x51, 0x80, | ||
| 0x05, 0x52, 0x80, 0x05, 0x53, 0x80, 0x05, 0x54, 0x80, 0x05, 0x55, 0x80, 0x05, 0x56, 0x80, 0x05, 0x57, 0x80, 0x05, 0x58, | ||
| 0x80, 0x05, 0x59, 0x80, 0x05, 0x5a, 0x80, 0x05, 0x5b, 0x80, 0x05, 0x5c, 0x80, 0x05, 0x5d, 0x80, 0x05, 0x5e, 0x80, 0x05, | ||
| 0x5f, 0x80, 0x05, 0x60, 0x80, 0x05, 0x61, 0x80, 0x05, 0x62, 0x80, 0x05, 0x63, 0x80, 0x18, 0x24, 0x03, 0x16, 0x2c, 0x04, | ||
| 0x13, 0x5a, 0x49, 0x47, 0x32, 0x30, 0x31, 0x34, 0x32, 0x5a, 0x42, 0x33, 0x33, 0x30, 0x30, 0x30, 0x33, 0x2d, 0x32, 0x34, | ||
| 0x24, 0x05, 0x00, 0x24, 0x06, 0x00, 0x25, 0x07, 0x94, 0x26, 0x24, 0x08, 0x00, 0x18, 0x31, 0x7d, 0x30, 0x7b, 0x02, 0x01, | ||
| 0x03, 0x80, 0x14, 0x62, 0xfa, 0x82, 0x33, 0x59, 0xac, 0xfa, 0xa9, 0x96, 0x3e, 0x1c, 0xfa, 0x14, 0x0a, 0xdd, 0xf5, 0x04, | ||
| 0xf3, 0x71, 0x60, 0x30, 0x0b, 0x06, 0x09, 0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x04, 0x02, 0x01, 0x30, 0x0a, 0x06, 0x08, | ||
| 0x2a, 0x86, 0x48, 0xce, 0x3d, 0x04, 0x03, 0x02, 0x04, 0x47, 0x30, 0x45, 0x02, 0x20, 0x24, 0xe5, 0xd1, 0xf4, 0x7a, 0x7d, | ||
| 0x7b, 0x0d, 0x20, 0x6a, 0x26, 0xef, 0x69, 0x9b, 0x7c, 0x97, 0x57, 0xb7, 0x2d, 0x46, 0x90, 0x89, 0xde, 0x31, 0x92, 0xe6, | ||
| 0x78, 0xc7, 0x45, 0xe7, 0xf6, 0x0c, 0x02, 0x21, 0x00, 0xf8, 0xaa, 0x2f, 0xa7, 0x11, 0xfc, 0xb7, 0x9b, 0x97, 0xe3, 0x97, | ||
| 0xce, 0xda, 0x66, 0x7b, 0xae, 0x46, 0x4e, 0x2b, 0xd3, 0xff, 0xdf, 0xc3, 0xcc, 0xed, 0x7a, 0xa8, 0xca, 0x5f, 0x4c, 0x1a, | ||
| 0x7c, | ||
| }; | ||
|
|
||
| return CopySpanToMutableSpan(ByteSpan{ kCdForAllExamples }, out_cd_buffer); | ||
|
|
||
| #else | ||
| size_t buflen = out_cd_buffer.size(); | ||
| ChipLogDetail(Crypto, "Get certificate declaration from se05x"); | ||
| ReturnErrorOnFailure(se05xGetCertificate(CD_CERT_DECLARATION_DATA_SE05X_ID, out_cd_buffer.data(), &buflen)); | ||
| out_cd_buffer.reduce_size(buflen); | ||
| return CHIP_NO_ERROR; | ||
| #endif | ||
| } | ||
|
|
||
| CHIP_ERROR ExampleSe05xDACProviderv2::GetFirmwareInformation(MutableByteSpan & out_firmware_info_buffer) | ||
| { | ||
| // TODO: We need a real example FirmwareInformation to be populated. | ||
| out_firmware_info_buffer.reduce_size(0); | ||
|
|
||
| return CHIP_NO_ERROR; | ||
| } | ||
|
|
||
| CHIP_ERROR ExampleSe05xDACProviderv2::SignWithDeviceAttestationKey(const ByteSpan & message_to_sign, | ||
| MutableByteSpan & out_signature_buffer) | ||
| { | ||
| CHIP_ERROR err = CHIP_NO_ERROR; | ||
| VerifyOrReturnError(IsSpanUsable(out_signature_buffer), CHIP_ERROR_INVALID_ARGUMENT); | ||
| VerifyOrReturnError(IsSpanUsable(message_to_sign), CHIP_ERROR_INVALID_ARGUMENT); | ||
|
|
||
| ChipLogDetail(Crypto, "Sign using DA key from se05x (Using internal sign)"); | ||
|
|
||
| TLV::TLVReader msg_reader; | ||
| TLV::TLVReader tagReader; | ||
|
|
||
| msg_reader.Init(message_to_sign); | ||
|
|
||
| /* To be removed. Use common key id to sign message */ | ||
| static bool sign_cert_decl_attest = 1; | ||
|
|
||
| if (sign_cert_decl_attest) | ||
| { | ||
| /* Check if certificate declaration tag is present and Skip certificate declaration tag */ | ||
| ReturnErrorOnFailure(TLV::Utilities::Find(msg_reader, TLV::ContextTag(1), tagReader)); | ||
|
|
||
| ReturnErrorOnFailure(TLV::Utilities::Find(msg_reader, TLV::ContextTag(2), tagReader)); | ||
| uint8_t attlen = tagReader.GetLength(); | ||
| VerifyOrReturnError(attlen > 0, CHIP_ERROR_INVALID_TLV_TAG); | ||
| /* Get attestation nonce */ | ||
| ByteSpan attest_nonce; | ||
| ReturnErrorOnFailure(tagReader.Get(attest_nonce)); | ||
| /* Set attestation nonce */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == | ||
| se05xSetCertificate(CD_ATTEST_NONCE_DATA_SE05X_ID, attest_nonce.data(), attest_nonce.size()), | ||
| CHIP_ERROR_INTERNAL); | ||
|
|
||
| ReturnErrorOnFailure(TLV::Utilities::Find(msg_reader, TLV::ContextTag(3), tagReader)); | ||
| uint8_t tslen = tagReader.GetLength(); | ||
| if (tslen > 0) | ||
| { | ||
| ByteSpan time_stamp; | ||
| ReturnErrorOnFailure(tagReader.Get(time_stamp)); | ||
| /* Set time stamp data */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == | ||
| se05xSetCertificate(CD_TIME_STAMP_DATA_SE05X_ID, time_stamp.data(), time_stamp.size()), | ||
| CHIP_ERROR_INTERNAL); | ||
| } | ||
| /* Set time stamp length */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == se05xSetCertificate(CD_TIME_STAMP_LEN_SE05X_ID, &tslen, 1), CHIP_ERROR_INTERNAL); | ||
|
|
||
| if ((tagReader.GetRemainingLength() + 1 /* End container */) >= 16) | ||
| { | ||
| /* Set attestation challenge */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == | ||
| se05xSetCertificate(CD_ATTEST_CHALLENGE_SE05X_ID, (message_to_sign.end() - 16), 16), | ||
| CHIP_ERROR_INTERNAL); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| ReturnErrorOnFailure(TLV::Utilities::Find(msg_reader, TLV::ContextTag(1), tagReader)); | ||
| uint8_t csrlen = tagReader.GetLength(); | ||
| VerifyOrReturnError(csrlen > 0, CHIP_ERROR_INVALID_TLV_TAG); | ||
| ByteSpan csr_data; | ||
| /* Get nocsr */ | ||
| ReturnErrorOnFailure(tagReader.Get(csr_data)); | ||
| /* Set nocsr length */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == se05xSetCertificate(NOCSR_CSR_LEN_SE05X_ID, &csrlen, 1), CHIP_ERROR_INTERNAL); | ||
sujaygkulkarni-nxp marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Why not initializing csrlen from There was a problem hiding this comment. get() member will return error in case the tag length is 0. So using the GetLength() before get() member is called. There was a problem hiding this comment. Again, There was a problem hiding this comment. I have created the issue to check this as well as other changes you suggested in the previous conversation. (#23064). Will address these in the next PR. |
||
| /* Set nocsr data */ | ||
| se05x_delete_key(NOCSR_CSR_DATA_SE05X_ID); | ||
| VerifyOrReturnError(CHIP_NO_ERROR == se05xSetCertificate(NOCSR_CSR_DATA_SE05X_ID, csr_data.data(), csr_data.size()), | ||
| CHIP_ERROR_INTERNAL); | ||
|
|
||
| ReturnErrorOnFailure(TLV::Utilities::Find(msg_reader, TLV::ContextTag(2), tagReader)); | ||
| uint8_t noncelen = tagReader.GetLength(); | ||
| VerifyOrReturnError(noncelen > 0, CHIP_ERROR_INVALID_TLV_TAG); | ||
| /* Get nocsr nonce */ | ||
| ByteSpan nocsr_nonce; | ||
| ReturnErrorOnFailure(tagReader.Get(nocsr_nonce)); | ||
| /* Set nocsr nonce data */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == | ||
| se05xSetCertificate(NOCSR_CSR_NONCE_DATA_SE05X_ID, nocsr_nonce.data(), nocsr_nonce.size()), | ||
| CHIP_ERROR_INTERNAL); | ||
|
|
||
| if ((tagReader.GetRemainingLength() + 1 /* End container */) >= 16) | ||
| { | ||
| /* Set attestation challenge */ | ||
| VerifyOrReturnError(CHIP_NO_ERROR == | ||
| se05xSetCertificate(NOCSR_ATTEST_CHALLENGE_SE05X_ID, (message_to_sign.end() - 16), 16), | ||
| CHIP_ERROR_INTERNAL); | ||
| } | ||
| } | ||
|
|
||
| uint8_t signature_se05x[Crypto::kMax_ECDSA_Signature_Length_Der] = { 0 }; | ||
| size_t signature_se05x_len = sizeof(signature_se05x); | ||
|
|
||
| if (sign_cert_decl_attest) | ||
| { | ||
| err = se05xPerformInternalSign(CD_DEV_ATTESTATION_KEY_SE05X_ID, signature_se05x, &signature_se05x_len); | ||
| se05x_delete_key(CD_ATTEST_NONCE_DATA_SE05X_ID); | ||
| se05x_delete_key(CD_TIME_STAMP_LEN_SE05X_ID); | ||
| se05x_delete_key(CD_TIME_STAMP_DATA_SE05X_ID); | ||
| se05x_delete_key(CD_ATTEST_CHALLENGE_SE05X_ID); | ||
| sign_cert_decl_attest = 0; | ||
sujaygkulkarni-nxp marked this conversation as resolved.
Show resolved
Hide resolved
sujaygkulkarni-nxp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| else | ||
| { | ||
| err = se05xPerformInternalSign(NOCSR_DEV_ATTESTATION_KEY_SE05X_ID, signature_se05x, &signature_se05x_len); | ||
| se05x_delete_key(NOCSR_CSR_LEN_SE05X_ID); | ||
| se05x_delete_key(NOCSR_CSR_DATA_SE05X_ID); | ||
| se05x_delete_key(NOCSR_CSR_NONCE_DATA_SE05X_ID); | ||
| se05x_delete_key(NOCSR_ATTEST_CHALLENGE_SE05X_ID); | ||
| sign_cert_decl_attest = 1; | ||
| } | ||
|
|
||
| ReturnErrorOnFailure(err); | ||
|
|
||
| return chip::Crypto::EcdsaAsn1SignatureToRaw(chip::Crypto::kP256_FE_Length, ByteSpan{ signature_se05x, signature_se05x_len }, | ||
| out_signature_buffer); | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| DeviceAttestationCredentialsProvider * GetExampleSe05xDACProviderv2() | ||
| { | ||
| static ExampleSe05xDACProviderv2 example_dac_provider; | ||
|
|
||
| return &example_dac_provider; | ||
| } | ||
|
|
||
| } // namespace Examples | ||
| } // namespace Credentials | ||
| } // namespace chip | ||
|
|
||
| #endif //#ifdef ENABLE_HSM_DEVICE_ATTESTATION | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| # Copyright (c) 2020 Project CHIP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import("//build_overrides/chip.gni") | ||
| import("${chip_root}/examples/common/pigweed/pigweed_rpcs.gni") | ||
| import("${chip_root}/src/app/common_flags.gni") | ||
| import("${chip_root}/src/crypto/crypto.gni") | ||
| import("${chip_root}/src/lib/core/core.gni") | ||
| import("${chip_root}/src/lib/lib.gni") | ||
|
|
||
| config("app-main-config") { | ||
| include_dirs = [ "." ] | ||
| } | ||
|
|
||
| source_set("ota-test-event-trigger") { | ||
| sources = [ | ||
| "${chip_root}/src/app/clusters/ota-requestor/OTATestEventTriggerDelegate.h", | ||
| ] | ||
| } | ||
|
|
||
| source_set("app-main") { | ||
| defines = [] | ||
| sources = [ | ||
| "${chip_root}/examples/platform/linux/AppMain.h", | ||
| "${chip_root}/examples/platform/linux/CommissionableInit.cpp", | ||
| "${chip_root}/examples/platform/linux/CommissionableInit.h", | ||
| "${chip_root}/examples/platform/linux/CommissioneeShellCommands.cpp", | ||
| "${chip_root}/examples/platform/linux/CommissioneeShellCommands.h", | ||
| "${chip_root}/examples/platform/linux/CommissionerMain.cpp", | ||
| "${chip_root}/examples/platform/linux/CommissionerMain.h", | ||
| "${chip_root}/examples/platform/linux/ControllerShellCommands.cpp", | ||
| "${chip_root}/examples/platform/linux/ControllerShellCommands.h", | ||
| "${chip_root}/examples/platform/linux/LinuxCommissionableDataProvider.cpp", | ||
| "${chip_root}/examples/platform/linux/LinuxCommissionableDataProvider.h", | ||
| "${chip_root}/examples/platform/linux/NamedPipeCommands.cpp", | ||
| "${chip_root}/examples/platform/linux/NamedPipeCommands.h", | ||
| "${chip_root}/examples/platform/linux/Options.cpp", | ||
| "${chip_root}/examples/platform/linux/Options.h", | ||
| "${chip_root}/examples/platform/linux/testing/CustomCSRResponse.cpp", | ||
| "${chip_root}/examples/platform/linux/testing/CustomCSRResponse.h", | ||
| "${chip_root}/examples/platform/linux/testing/CustomCSRResponseOperationalKeyStore.cpp", | ||
| "${chip_root}/examples/platform/linux/testing/CustomCSRResponseOperationalKeyStore.h", | ||
| "${chip_root}/examples/platform/nxp/se05x/DeviceAttestationSe05xCredsExample.cpp", | ||
| "${chip_root}/examples/platform/nxp/se05x/DeviceAttestationSe05xCredsExample_v2.cpp", | ||
| "AppMain.cpp", | ||
| ] | ||
|
|
||
| include_dirs = [ | ||
| "${chip_root}/examples/platform/linux", | ||
| "${chip_root}/examples/platform/nxp/se05x", | ||
| ] | ||
|
|
||
| defines = [] | ||
|
|
||
| if (chip_enable_pw_rpc) { | ||
| defines += [ "PW_RPC_ENABLED" ] | ||
| } | ||
| if (chip_build_libshell) { | ||
| defines += [ "ENABLE_CHIP_SHELL" ] | ||
| } | ||
|
|
||
| public_deps = [ | ||
| ":ota-test-event-trigger", | ||
| "${chip_root}/examples/providers:device_info_provider", | ||
| "${chip_root}/src/app/server", | ||
| "${chip_root}/src/credentials:default_attestation_verifier", | ||
| "${chip_root}/src/lib", | ||
| "${chip_root}/src/lib/shell", | ||
| "${chip_root}/src/lib/shell:shell_core", | ||
| ] | ||
|
|
||
| if (chip_enable_transport_trace) { | ||
| public_deps += | ||
| [ "${chip_root}/examples/common/tracing:trace_handlers_decoder" ] | ||
| } | ||
|
|
||
| public_configs = [ ":app-main-config" ] | ||
| } | ||
|
|
||
| source_set("commissioner-main") { | ||
| defines = [] | ||
| sources = [ | ||
| "${chip_root}/examples/platform/linux/CommissionerMain.cpp", | ||
| "${chip_root}/examples/platform/linux/CommissionerMain.h", | ||
| ] | ||
|
|
||
| defines = [] | ||
|
|
||
| if (chip_enable_pw_rpc) { | ||
| defines += [ "PW_RPC_ENABLED" ] | ||
| } | ||
| if (chip_build_libshell) { | ||
| defines += [ "ENABLE_CHIP_SHELL" ] | ||
| } | ||
|
|
||
| public_deps = [ | ||
| "${chip_root}/src/app/server", | ||
| "${chip_root}/src/credentials:default_attestation_verifier", | ||
| "${chip_root}/src/lib", | ||
| "${chip_root}/src/lib/shell", | ||
| "${chip_root}/src/lib/shell:shell_core", | ||
| ] | ||
|
|
||
| if (chip_enable_transport_trace) { | ||
| public_deps += [ "${chip_root}/examples/common/tracing:trace_handlers" ] | ||
| } | ||
|
|
||
| public_configs = [ ":app-main-config" ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright (c) 2020 Project CHIP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import("//build_overrides/build.gni") | ||
|
|
||
| # The location of the build configuration file. | ||
| buildconfig = "${build_root}/config/BUILDCONFIG.gn" | ||
|
|
||
| # CHIP uses angle bracket includes. | ||
| check_system_includes = true | ||
|
|
||
| default_args = { | ||
| import("//args.gni") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Copyright (c) 2020 Project CHIP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import("//build_overrides/build.gni") | ||
| import("//build_overrides/chip.gni") | ||
|
|
||
| executable("thermostat-se05x-app") { | ||
| sources = [ "${chip_root}/examples/thermostat/linux/main.cpp" ] | ||
|
|
||
| include_dirs = [ "${chip_root}/examples/platform/linux" ] | ||
|
|
||
| deps = [ | ||
| "${chip_root}/examples/platform/nxp/se05x/linux:app-main", | ||
| "${chip_root}/examples/thermostat/thermostat-common", | ||
| "${chip_root}/src/lib", | ||
| ] | ||
|
|
||
| cflags = [ "-Wconversion" ] | ||
|
|
||
| output_dir = root_out_dir | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copyright (c) 2020 Project CHIP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import("//build_overrides/chip.gni") | ||
| import("${chip_root}/config/standalone/args.gni") | ||
| chip_with_se05x = 1 | ||
| host = "host_linux" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../build_overrides |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../.. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule repo
updated
1 files
| +442 −67 | demos/se05x_dev_attest_key_prov/common/se05x_dev_attest_key_prov.cpp |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this using
time_stamp.size()? That is, what is the point oftslenat all? It seems like an attractive nuisance, as do most of theGetLengthcalls here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get() member will return error in case the tag length is 0. So using the GetLength() before get() member is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, what? Why would
Getreturn an error on 0 length? It most certainly does not do that...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created the issue to check this as well as other changes you suggested in the previous conversation. (#23064). Will address these in the next PR.