-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Integrate cluster state cache with android Java IM API #22851
Merged
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/android_cluster_state_cache_integration
Sep 26, 2022
Merged
[Android] Integrate cluster state cache with android Java IM API #22851
yunhanw-google
merged 3 commits into
project-chip:master
from
yunhanw-google:feature/android_cluster_state_cache_integration
Sep 26, 2022
+82
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88f9e5a
to
b6841c7
Compare
b6841c7
to
ebdd47b
Compare
PR #22851: Size comparison from 8ac8ec7 to ebdd47b Increases (7 builds for bl602, bl702, nrfconnect, psoc6, qpg)
Decreases (6 builds for bl702, esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Sep 25, 2022
andy31415
reviewed
Sep 26, 2022
andy31415
reviewed
Sep 26, 2022
andy31415
reviewed
Sep 26, 2022
src/controller/java/src/chip/devicecontroller/model/ClusterState.java
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Sep 26, 2022
PR #22851: Size comparison from 8ac8ec7 to a1ada12 Increases above 0.2%:
Increases (10 builds for bl602, bl702, cc13x2_26x2)
Decreases (25 builds for bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Sep 26, 2022
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…ject-chip#22851) * Integrate cluster state cache with java im API * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
#19668
Change overview
Integrate Java Read/Subscribe API with ClusterStateCache, where it has fine-grained dataVersionFilter and eventFilters support.
In android, we would not expect to retrieve attributes and events from cluster state cache, instead we have provided the NodeState to collect the attribute and event data from each report transaction, in this change, we piped the committed cluster data version from clusterStateCache to nodeState, which can provide coherent data version view when involving wildcard attribute path read/subscribe.