Ensure that CHIPDeviceControllerFactory calls FabricTable::Shutdown #22932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviceControllerFactory::InitSystemState initializes the FabricTable when it allocates it, but DeviceControllerSystemState::Shutdown does not symmetrically shut it down before deletion, and it should. This commit adds the missing Shutdown call.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #22932: Size comparison from a8bd389 to c1d3eee Increases (4 builds for linux, psoc6, telink)
Decreases (5 builds for bl602, bl702, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Sep 28, 2022
andy31415
approved these changes
Sep 28, 2022
|
PR #22932: Size comparison from 6dfab6f to 9f396b1 Increases (3 builds for linux, nrfconnect, qpg)
Decreases (9 builds for bl602, bl702, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #22932: Size comparison from 46fd14a to f7fcb3c Increases (5 builds for bl602, bl702, linux, nrfconnect)
Full report (15 builds for bl602, bl702, k32w, linux, nrfconnect, qpg, telink)
|
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Sep 29, 2022
…utdown (project-chip#22932)" This reverts commit 57c7321.
mrjerryjohns
added a commit
to mrjerryjohns/connectedhomeip
that referenced
this pull request
Sep 29, 2022
the stack. This entails interactions with the persistent storage layer to update some keys. In Python however, the storage layer has already been shutdown by the time we get to stack shutdown, causing a use-after-free. Flip the order in which we shutdown the storage adapter relative to shutting down the rest of the stack.
mrjerryjohns
added a commit
to mrjerryjohns/connectedhomeip
that referenced
this pull request
Sep 29, 2022
22932 shuts down the fabric table as part of shutting down the stack. This entails interactions with the persistent storage layer to update some keys. In Python however, the storage layer has already been shutdown by the time we get to stack shutdown, causing a use-after-free. Flip the order in which we shutdown the storage adapter relative to shutting down the rest of the stack.
mrjerryjohns
added a commit
to mrjerryjohns/connectedhomeip
that referenced
this pull request
Sep 29, 2022
22932 shuts down the fabric table as part of shutting down the stack. This entails interactions with the persistent storage layer to update some keys. In Python however, the storage layer has already been shutdown by the time we get to stack shutdown, causing a use-after-free. Flip the order in which we shutdown the storage adapter relative to shutting down the rest of the stack.
andy31415
pushed a commit
that referenced
this pull request
Sep 30, 2022
22932 shuts down the fabric table as part of shutting down the stack. This entails interactions with the persistent storage layer to update some keys. In Python however, the storage layer has already been shutdown by the time we get to stack shutdown, causing a use-after-free. Flip the order in which we shutdown the storage adapter relative to shutting down the rest of the stack.
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…roject-chip#22932) DeviceControllerFactory::InitSystemState initializes the FabricTable when it allocates it, but DeviceControllerSystemState::Shutdown does not symmetrically shut it down before deletion, and it should. This commit adds the missing Shutdown call.
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…utdown (project-chip#22932)" (project-chip#22961) This reverts commit 57c7321.
sharad-patil24
pushed a commit
to sharad-patil24/connectedhomeip
that referenced
this pull request
Sep 30, 2022
…hip#22963) 22932 shuts down the fabric table as part of shutting down the stack. This entails interactions with the persistent storage layer to update some keys. In Python however, the storage layer has already been shutdown by the time we get to stack shutdown, causing a use-after-free. Flip the order in which we shutdown the storage adapter relative to shutting down the rest of the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
DeviceControllerFactory::InitSystemState initializes the FabricTable when it allocates it, but DeviceControllerSystemState::Shutdown does not symmetrically shut it down before deletion, and it should. This adds the missing Shutdown call.