Add ability to establish PASE over BLE to Python DeviceController #22985
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to just establish PASE over BLE to the Python device controller. This then makes it possible to write custom commissioning code in Python if needed.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
mspang,
rgoliver,
robszewczyk and
saurabhst
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
reviewed
Sep 30, 2022
andy31415
approved these changes
Sep 30, 2022
|
PR #22985: Size comparison from e08db05 to 0294bbe Increases (6 builds for cc13x2_26x2, esp32, psoc6, qpg)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 4, 2022
bzbarsky-apple
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
This seems OK, I guess, but really instead of EstablishPASESessionIP and EstablishPASESessionBLE, or maybe in addition to them, there should be EstablishPASESession that takes a setup payload (string or parsed) and does the right thing wrt discovery and so on.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
pullapprove
bot
requested review from
lpbeliveau-silabs
and removed request for
wbschiller
|
PR #22985: Size comparison from dcf7061 to 4424c25 Increases (14 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
emargolis
approved these changes
Dec 8, 2022
|
PR #22985: Size comparison from dcf7061 to 3eff5c0 Increases (10 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, esp32)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #22985: Size comparison from 241e7b0 to 70b1104 Increases (5 builds for bl602, psoc6, telink)
Decreases (2 builds for telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to just establish PASE over BLE to the Python device controller. This then makes it possible to write custom commissioning code in Python if needed.