-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce targets for cloudbuild smoketest #23034
Merged
andy31415
merged 5 commits into
project-chip:master
from
andy31415:smaller_smoke_cloudbuild
Oct 5, 2022
Merged
Reduce targets for cloudbuild smoketest #23034
andy31415
merged 5 commits into
project-chip:master
from
andy31415:smaller_smoke_cloudbuild
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix: this is a 3rd party integration that cannot be validated by CI. |
PR #23034: Size comparison from 55116a1 to 863d3d8 Increases (3 builds for bl702, nrfconnect, qpg)
Decreases (3 builds for bl602, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23034: Size comparison from 55116a1 to f45729a Increases (5 builds for cc13x2_26x2, esp32, psoc6)
Decreases (5 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudbuild uses a glob for smoketest, however after recent target additons this seems to take more than 2.5h on a 32core to compile.
This seems to be due to variant explosion: on linux we would compile 84 different variants, esp32 also has some quite redundant versions (rpc, ipv6, nodeps combinations).
This change explicitly picks the targets to compile: still a somewhat long list, but at least a 50% reduction for linux which should save 30min to 1h or compile time.