-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup keep_trailing_newline=True
in python jinja templates
#23235
Merged
andy31415
merged 4 commits into
project-chip:master
from
andy31415:keep_trailing_newlines_in_codegen
Oct 18, 2022
Merged
Setup keep_trailing_newline=True
in python jinja templates
#23235
andy31415
merged 4 commits into
project-chip:master
from
andy31415:keep_trailing_newlines_in_codegen
Oct 18, 2022
+53
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23235: Size comparison from 11606ea to c4d56d3 Decreases (3 builds for bl702, qpg)
Full report (6 builds for bl702, linux, qpg)
|
tehampson
approved these changes
Oct 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23235) * Keep trailing newlins in codegen * Add option to auto-regenerate golden data * Re-generate test outputs after skip whitespace changes * Restyle
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23235) * Keep trailing newlins in codegen * Add option to auto-regenerate golden data * Re-generate test outputs after skip whitespace changes * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We codegen C++ headers and sources and for headers, the final newline can be important.
This adds keep_trailing_newline to jinja codegen.
I also made it so that the unit tests for codegen can easily update their outputs and re-generated all files.