Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more time for pairing #23264

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

woody-apple
Copy link
Contributor

Internal tests have shown that 15 seconds to complete all of pairing, fails a significant amount (10%+) of pairings early. mDNS timeouts, network delay, device delay.

Further break downs to come, but we've found that moving this to 45s significantly reduces the amount of outliers (almost to 0).

@github-actions
Copy link

PR #23264: Size comparison from e4f60ce to a1f4cfe

Decreases (1 build for nrfconnect)
platform target config section e4f60ce a1f4cfe change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815888 815884 -4 -0.0
Full report (3 builds for mbed, nrfconnect)
platform target config section e4f60ce a1f4cfe change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452168 2452168 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414812 1414812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183627 1183627 0 0.0
bss 144457 144457 0 0.0
rodata 144396 144396 0 0.0
text 815888 815884 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162311 1162311 0 0.0
bss 143684 143684 0 0.0
rodata 135968 135968 0 0.0
text 803780 803780 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) October 19, 2022 20:04
@woody-apple woody-apple merged commit 64c101c into project-chip:master Oct 19, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants