Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating link order for Darwin platform #23265

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

woody-apple
Copy link
Contributor

Pairing testing has shown that for one reason or another, occasionally either the ULA update is late, and/or isn't working. The Link Local address however works almost all of the time, and tends to be more stable across device reset.

This brings about a 20% improvement to pairing reliability on Darwin.

@github-actions
Copy link

PR #23265: Size comparison from e4f60ce to 3691baa

Increases (2 builds for bl702)
platform target config section e4f60ce 3691baa change % change
bl702 lighting-app bl702 .debug_info 37908755 37908762 7 0.0
.debug_line 5257407 5257410 3 0.0
bl702+rpc .debug_info 41815370 41815378 8 0.0
.debug_line 5631938 5631941 3 0.0
Decreases (2 builds for bl702)
platform target config section e4f60ce 3691baa change % change
bl702 lighting-app bl702 .debug_abbrev 1507059 1507041 -18 -0.0
.text 957310 957308 -2 -0.0
bl702+rpc .debug_abbrev 1644604 1644586 -18 -0.0
Full report (5 builds for bl702, mbed, nrfconnect)
platform target config section e4f60ce 3691baa change % change
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1188947 1188947 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1507059 1507041 -18 -0.0
.debug_aranges 133144 133144 0 0.0
.debug_frame 486648 486648 0 0.0
.debug_info 37908755 37908762 7 0.0
.debug_line 5257407 5257410 3 0.0
.debug_loc 3367638 3367638 0 0.0
.debug_ranges 359456 359456 0 0.0
.debug_str 3457927 3457927 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565127 565127 0 0.0
.symtab 171680 171680 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957310 957308 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1284627 1284627 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644604 1644586 -18 -0.0
.debug_aranges 140648 140648 0 0.0
.debug_frame 512020 512020 0 0.0
.debug_info 41815370 41815378 8 0.0
.debug_line 5631938 5631941 3 0.0
.debug_loc 3560285 3560285 0 0.0
.debug_ranges 381912 381912 0 0.0
.debug_str 3853897 3853897 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624300 624300 0 0.0
.symtab 189488 189488 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1030756 1030756 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452168 2452168 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414812 1414812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183627 1183627 0 0.0
bss 144457 144457 0 0.0
rodata 144396 144396 0 0.0
text 815888 815888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162311 1162311 0 0.0
bss 143684 143684 0 0.0
rodata 135968 135968 0 0.0
text 803780 803780 0 0.0

Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider making this a default? Or do we believe this is apple-specific?

I am thinking to have some config of LL_ADDRESS_IS_BEST (with a better name) and enable it for __APPLE__ and make it easy for others to also enable it if it seems correct. Maybe in build flags even.

@woody-apple
Copy link
Contributor Author

Should we consider making this a default? Or do we believe this is apple-specific?

I am thinking to have some config of LL_ADDRESS_IS_BEST (with a better name) and enable it for __APPLE__ and make it easy for others to also enable it if it seems correct. Maybe in build flags even.

I do think Apple specific is correct for now, as there's some oddities with ULAs right now on this platform.

@woody-apple woody-apple merged commit f76da55 into project-chip:master Oct 19, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants