-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating link order for Darwin platform #23265
Updating link order for Darwin platform #23265
Conversation
PR #23265: Size comparison from e4f60ce to 3691baa Increases (2 builds for bl702)
Decreases (2 builds for bl702)
Full report (5 builds for bl702, mbed, nrfconnect)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider making this a default? Or do we believe this is apple-specific?
I am thinking to have some config of LL_ADDRESS_IS_BEST
(with a better name) and enable it for __APPLE__
and make it easy for others to also enable it if it seems correct. Maybe in build flags even.
I do think Apple specific is correct for now, as there's some oddities with ULAs right now on this platform. |
Pairing testing has shown that for one reason or another, occasionally either the ULA update is late, and/or isn't working. The Link Local address however works almost all of the time, and tends to be more stable across device reset.
This brings about a 20% improvement to pairing reliability on Darwin.