-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reworking example code to avoid compiler warning #23297
Merged
andy31415
merged 2 commits into
project-chip:master
from
billwatersiii:infineon_warning_fix
Oct 22, 2022
Merged
reworking example code to avoid compiler warning #23297
andy31415
merged 2 commits into
project-chip:master
from
billwatersiii:infineon_warning_fix
Oct 22, 2022
+25
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Oct 21, 2022
PR #23297: Size comparison from a325034 to 543ceb1 Increases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (5 builds for cyw30739, esp32, k32w, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Oct 21, 2022
543ceb1
to
575ed57
Compare
PR #23297: Size comparison from 559c7d5 to 575ed57 Increases (2 builds for k32w)
Decreases (2 builds for bl702)
Full report (15 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
575ed57
to
1f561bb
Compare
PR #23297: Size comparison from a9399de to 1f561bb Increases (3 builds for bl602, cc13x2_26x2, esp32)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 22, 2022
espressif-bot
pushed a commit
to espressif/connectedhomeip
that referenced
this pull request
Oct 22, 2022
* reworking example code to avoid compiler warning * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* reworking example code to avoid compiler warning * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* reworking example code to avoid compiler warning * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
greg-fer
pushed a commit
to greg-fer/connectedhomeip
that referenced
this pull request
Apr 26, 2023
* reworking example code to avoid compiler warning * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23295 (#23295)
There is a compiler warning with a function in the Infineon lock-app example. This pull request resolves that. Also took the opportunity to rework/simplify that function. There is a similar function in the lighting-app, so did the same there.