[app] Implement deferred attribute persister #23366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
force-pushed
the
deferred
branch
from
6b91858 to
db05fbb
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
Damian-Nordic
force-pushed
the
deferred
branch
from
db05fbb to
f4b0186
Compare
|
PR #23366: Size comparison from 50ac33d to f4b0186 Increases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6)
Decreases (29 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 3, 2022
LuDuda
approved these changes
Nov 4, 2022
Fast-changing attributes with NVM storage, such as CurrentLevel of the LevelControl cluster, may result in rapid flash wearout using the default attribute persister which stores all values immediately. Implement a helper adapter class for the attribute persistence interface to defer writes of selected attributes. Use the new class in nRF Connect lighting-app for verification.
Damian-Nordic
force-pushed
the
deferred
branch
from
f4b0186 to
7d71e03
Compare
|
PR #23366: Size comparison from a99675e to 7d71e03 Increases (13 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* [app] Implement deferred attribute persister Fast-changing attributes with NVM storage, such as CurrentLevel of the LevelControl cluster, may result in rapid flash wearout using the default attribute persister which stores all values immediately. Implement a helper adapter class for the attribute persistence interface to defer writes of selected attributes. Use the new class in nRF Connect lighting-app for verification. * Code review * Add a comment
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* [app] Implement deferred attribute persister Fast-changing attributes with NVM storage, such as CurrentLevel of the LevelControl cluster, may result in rapid flash wearout using the default attribute persister which stores all values immediately. Implement a helper adapter class for the attribute persistence interface to defer writes of selected attributes. Use the new class in nRF Connect lighting-app for verification. * Code review * Add a comment
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast-changing attributes with NVM storage, such as CurrentLevel of the LevelControl cluster, may result in rapid flash wearout using the default attribute persister which stores all values immediately.
Implement a helper adapter class for the attribute persistence interface to defer writes of selected attributes.
Use the new class in nRF Connect lighting-app for verification.
Fixes #23222.