-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "Id" with "ID" in Darwin APIs. #23389
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22558
Oct 29, 2022
Merged
Replace "Id" with "ID" in Darwin APIs. #23389
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-reland-PR-22558
Oct 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-landing of PR project-chip#22558 but modified to preserve the old APIs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * MTRAttributeCacheContainer_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerOverXPC_Internal.h is not public API.
PR #23389: Size comparison from 09acc29 to e05527e Increases (10 builds for bl602, bl702, cyw30739, esp32, k32w, psoc6, telink)
Decreases (3 builds for esp32, telink)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 29, 2022
Damian-Nordic
approved these changes
Oct 29, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22558 but modified to preserve the old APIs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * MTRAttributeCacheContainer_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerOverXPC_Internal.h is not public API.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22558 but modified to preserve the old APIs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * MTRAttributeCacheContainer+XPC.h is not public API. * MTRAttributeCacheContainer_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRDeviceControllerXPCConnection.h is not public API. * MTRDeviceControllerOverXPC.h is not public API. * MTRDeviceControllerOverXPC_Internal.h is not public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22558 but modified to preserve the old APIs.
The header changes not accompanied by backwards-compat shims are OK for the following reasons: