Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DeviceNetworkProvisioningDelegate interface to force vendor to use NetworkCommissioning interface… #23391

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Remove DeviceNetworkProvisioningDelegate interface to force vendor to use NetworkCommissioning interface… #23391

merged 2 commits into from
Nov 3, 2022

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Oct 28, 2022 •
edited
Loading

Currently, we have two interfaces to provision WiFi, ScanNetworks/AddOrUpdateNetwork APIs in NetworkCommissioning drivers and ProvisionWiFi within DeviceNetworkProvisioningDelegate. DeviceNetworkProvisioningDelegate interfaces are not used except example shell command.

To prevent confusion, we should remove DeviceNetworkProvisioningDelegate interface

Solution:
Remove DeviceNetworkProvisioningDelegate interface to force vendor to use NetworkCommissioning interface.

@github-actions
Copy link

github-actions bot commented Oct 29, 2022 •
edited
Loading

PR #23391: Size comparison from 09acc29 to 0fb9eb7

Increases (3 builds for bl602, bl702, k32w)
platform target config section 09acc29 0fb9eb7 change % change
bl602 lighting-app bl602 .text 1069810 1069814 4 0.0
bl702 lighting-app bl702 .debug_info 37964827 37964828 1 0.0
.text 957778 957780 2 0.0
k32w lock k32w0+release (read/write) 633468 633484 16 0.0
.text 553060 553076 16 0.0
Decreases (2 builds for bl602, k32w)
platform target config section 09acc29 0fb9eb7 change % change
bl602 lighting-app bl602+rpc .text 1101416 1101414 -2 -0.0
k32w light k32w0+release (read/write) 672008 671992 -16 -0.0
.text 592380 592364 -16 -0.0
Full report (11 builds for bl602, bl702, k32w, linux, qpg)
platform target config section 09acc29 0fb9eb7 change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069810 1069814 4 0.0
bl602+rpc (read/write) 1435974 1435974 0 0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101416 1101414 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1509373 1509373 0 0.0
.debug_aranges 132040 132040 0 0.0
.debug_frame 484428 484428 0 0.0
.debug_info 37964827 37964828 1 0.0
.debug_line 5257208 5257208 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358064 358064 0 0.0
.debug_str 3451542 3451542 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565954 565954 0 0.0
.symtab 171968 171968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 957778 957780 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1646772 1646772 0 0.0
.debug_aranges 139544 139544 0 0.0
.debug_frame 509800 509800 0 0.0
.debug_info 41877796 41877796 0 0.0
.debug_line 5632788 5632788 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380864 380864 0 0.0
.debug_str 3847670 3847670 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625127 625127 0 0.0
.symtab 189776 189776 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 1031486 1031486 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 672008 671992 -16 -0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592380 592364 -16 -0.0
lock k32w0+release (read/write) 633468 633484 16 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553060 553076 16 0.0
linux chip-tool-ipv6only arm64 (read only) 10436396 10436396 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262340 8262340 0 0.0
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149968 0 0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597068 597068 0 0.0
lock-app qpg6105+debug (read/write) 1114760 1114760 0 0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561856 561856 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 29, 2022 •
edited
Loading

PR #23391: Size comparison from 09acc29 to 17e421f

Increases (8 builds for bl602, bl702, cyw30739, esp32, k32w, psoc6)
platform target config section 09acc29 17e421f change % change
bl602 lighting-app bl602 .text 1069810 1069812 2 0.0
bl702 lighting-app bl702 .debug_info 37964827 37964828 1 0.0
.text 957778 957780 2 0.0
bl702+rpc .debug_info 41877796 41877797 1 0.0
.text 1031486 1031488 2 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544474 544482 8 0.0
.app_xip_area 426140 426148 8 0.0
esp32 all-clusters-app m5stack (read/write) 564396 564404 8 0.0
.flash.rodata 315096 315104 8 0.0
k32w lock k32w0+release (read/write) 633468 633484 16 0.0
.text 553060 553076 16 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26636121 26636122 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22330841 22330842 1 0.0
Decreases (6 builds for esp32, psoc6, qpg, telink)
platform target config section 09acc29 17e421f change % change
esp32 all-clusters-app c3devkit (read only) 1223972 1223968 -4 -0.0
.flash.text 1223972 1223968 -4 -0.0
m5stack (read only) 1234039 1233999 -40 -0.0
.flash.text 1228655 1228615 -40 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26899491 26899490 -1 -0.0
qpg lock-app qpg6105+debug (read/write) 1114760 1114752 -8 -0.0
.text 561856 561848 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 806068 806060 -8 -0.0
text 566414 566412 -2 -0.0
ota-requestor-app tlsr9518adk80d text 565288 565286 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section 09acc29 17e421f change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069810 1069812 2 0.0
bl602+rpc (read/write) 1435974 1435974 0 0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101416 1101416 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1509373 1509373 0 0.0
.debug_aranges 132040 132040 0 0.0
.debug_frame 484428 484428 0 0.0
.debug_info 37964827 37964828 1 0.0
.debug_line 5257208 5257208 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358064 358064 0 0.0
.debug_str 3451542 3451542 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565954 565954 0 0.0
.symtab 171968 171968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957778 957780 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1646772 1646772 0 0.0
.debug_aranges 139544 139544 0 0.0
.debug_frame 509800 509800 0 0.0
.debug_info 41877796 41877797 1 0.0
.debug_line 5632788 5632788 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380864 380864 0 0.0
.debug_str 3847670 3847670 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625127 625127 0 0.0
.symtab 189776 189776 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031486 1031488 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677871 677871 0 0.0
(read/write) 173688 173688 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89887 89887 0 0.0
.text 587672 587672 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642119 642119 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 79023 79023 0 0.0
.text 562776 562776 0 0.0
lock-ftd LP_CC2652R7 (read only) 676379 676379 0 0.0
(read/write) 172316 172316 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77411 77411 0 0.0
.text 598488 598488 0 0.0
lock-mtd LP_CC2652R7 (read only) 660167 660167 0 0.0
(read/write) 184216 184216 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103263 103263 0 0.0
.text 556424 556424 0 0.0
pump-app LP_CC2652R7 (read only) 688635 688635 0 0.0
(read/write) 160796 160796 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90859 90859 0 0.0
.text 597292 597292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672911 672911 0 0.0
(read/write) 176616 176616 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86407 86407 0 0.0
.text 586024 586024 0 0.0
shell LP_CC2652R7 (read only) 668890 668890 0 0.0
(read/write) 184988 184988 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86594 86594 0 0.0
.text 581980 581980 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588542 588542 0 0.0
.app_xip_area 465128 465128 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592590 592590 0 0.0
.app_xip_area 463880 463880 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544474 544482 8 0.0
.app_xip_area 426140 426148 8 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974732 974732 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 820188 820188 0 0.0
BRD4161A+rs911x (read/write) 1034672 1034672 0 0.0
.bss 186744 186744 0 0.0
.data 2092 2092 0 0.0
.text 845812 845812 0 0.0
BRD4187C (read/write) 1146720 1146720 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980864 980864 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160424 1160424 0 0.0
.bss 158272 158272 0 0.0
.data 2100 2100 0 0.0
.text 1000032 1000032 0 0.0
window-app BRD4187C (read/write) 1139940 1139940 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972644 972644 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223972 1223968 -4 -0.0
(read/write) 1788470 1788470 0 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258024 258024 0 0.0
.flash.text 1223972 1223968 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234039 1233999 -40 -0.0
(read/write) 564396 564404 8 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315096 315104 8 0.0
.flash.text 1228655 1228615 -40 -0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 672008 672008 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592380 592380 0 0.0
lock k32w0+release (read/write) 633468 633484 16 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553060 553076 16 0.0
linux chip-tool-ipv6only arm64 (read only) 10436396 10436396 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262340 8262340 0 0.0
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2528660 2528660 0 0.0
.bss 222752 222752 0 0.0
.data 5592 5592 0 0.0
.text 1491276 1491276 0 0.0
all-clusters-minimal-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2477496 2477496 0 0.0
.bss 222024 222024 0 0.0
.data 5568 5568 0 0.0
.text 1440092 1440092 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465492 2465492 0 0.0
.bss 216724 216724 0 0.0
.data 5848 5848 0 0.0
.text 1428108 1428108 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452768 2452768 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415412 1415412 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414140 2414140 0 0.0
.bss 215040 215040 0 0.0
.data 5752 5752 0 0.0
.text 1376756 1376756 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745940 1745940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1231262 1231262 0 0.0
.debug_aranges 110712 110712 0 0.0
.debug_frame 371204 371204 0 0.0
.debug_info 26899491 26899490 -1 -0.0
.debug_line 3673871 3673871 0 0.0
.debug_loc 3588816 3588816 0 0.0
.debug_ranges 337960 337960 0 0.0
.debug_str 3435299 3435299 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570460 570460 0 0.0
.symtab 421744 421744 0 0.0
.text 0 0 0 0.0
1546160 1546160 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688548 1688548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1223105 1223105 0 0.0
.debug_aranges 110184 110184 0 0.0
.debug_frame 374284 374284 0 0.0
.debug_info 26636121 26636122 1 0.0
.debug_line 3694663 3694663 0 0.0
.debug_loc 3576453 3576453 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3424320 3424320 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534549 534549 0 0.0
.symtab 408176 408176 0 0.0
.text 1489504 1489504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607004 1607004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1057613 1057613 0 0.0
.debug_aranges 102384 102384 0 0.0
.debug_frame 344600 344600 0 0.0
.debug_info 22097476 22097476 0 0.0
.debug_line 3264197 3264197 0 0.0
.debug_loc 3274179 3274179 0 0.0
.debug_ranges 301872 301872 0 0.0
.debug_str 3229759 3229759 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470874 470874 0 0.0
.symtab 376560 376560 0 0.0
.text 1416144 1416144 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640780 1640780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1059619 1059619 0 0.0
.debug_aranges 102784 102784 0 0.0
.debug_frame 346472 346472 0 0.0
.debug_info 22330841 22330842 1 0.0
.debug_line 3261187 3261187 0 0.0
.debug_loc 3301773 3301773 0 0.0
.debug_ranges 303816 303816 0 0.0
.debug_str 3249234 3249234 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473277 473277 0 0.0
.symtab 378240 378240 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149968 0 0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597068 597068 0 0.0
lock-app qpg6105+debug (read/write) 1114760 1114752 -8 -0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561856 561848 -8 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 790820 790820 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554266 554266 0 0.0
lighting-app tlsr9518adk80d (read/write) 806068 806060 -8 -0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 566414 566412 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 804952 804952 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565288 565286 -2 -0.0

Damian-Nordic
Damian-Nordic reviewed Oct 29, 2022
View reviewed changes
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class used at all? I thought I switched to using NetworkCommissioning drivers. The only usage of ProvisionWifi I could find is some shell command and ProvisionThread is not used at all. Shouldn't we rather remove the class?

@yufengwangca
Copy link
Contributor Author

Is this class used at all? I thought I switched to using NetworkCommissioning drivers. The only usage of ProvisionWifi I could find is some shell command and ProvisionThread is not used at all. Shouldn't we rather remove the class?

Yes, this API is not used in any example app, but one of my internal product team has asked question about this, if we have alternative solution in NetworkCommissioning drivers, then we should remove this redundant APIs

@yufengwangca
Copy link
Contributor Author

yufengwangca commented Oct 31, 2022 •
edited
Loading

@Damian-Nordic I found the NetworkCommissioning drivers provides ScanNetworks/AddOrUpdateNetwork APIs which can do the similar stuff, but only ProvisionWiFi within DeviceNetworkProvisioningDelegate could trigger the ProvisionWiFiNetwork API in ConnectivityMgr directly. This is higher level API used to connect to an access point in one shot. We also have example in chip_shell demonstrate how to use this API.

@yufengwangca
Copy link
Contributor Author

@Damian-Nordic I found the NetworkCommissioning drivers provides ScanNetworks/AddOrUpdateNetwork APIs which can do the similar stuff, but only ProvisionWiFi within DeviceNetworkProvisioningDelegate could trigger the ProvisionWiFiNetwork API in ConnectivityMgr directly. This is higher level API used to connect to an access point in one shot. We also have example in chip_shell demonstrate how to use this API.

After second thought, if we provide two ways to do the similar thing, it will confuse the platform vendors, maybe you are right, by removing DeviceNetworkProvisioningDelegate API, we can force vendors to use NetworkCommissioning drivers to provision WiFi.

@yufengwangca yufengwangca changed the title Remove intermediate CRTP layer from DeviceNetworkProvisioningDelegate… Remove DeviceNetworkProvisioningDelegate interface to force vendor to use NetworkCommissioning interface… Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022 •
edited
Loading

PR #23391: Size comparison from f88f7bb to 8f14737

Increases (10 builds for cc13x2_26x2, k32w, nrfconnect, psoc6, qpg, telink)
platform target config section f88f7bb 8f14737 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 642111 642119 8 0.0
.text 562768 562776 8 0.0
pump-app LP_CC2652R7 (read/write) 160796 160804 8 0.0
k32w light k32w0+release (read/write) 671992 672008 16 0.0
.text 592364 592380 16 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 805330 805334 4 0.0
lock-app nrf52840dk_nrf52840 text 771636 771640 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22330842 22330843 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1149960 1149968 8 0.0
.text 597060 597068 8 0.0
lock-app qpg6105+debug (read/write) 1114752 1114760 8 0.0
.text 561848 561856 8 0.0
telink light-switch-app tlsr9518adk80d text 554264 554266 2 0.0
lighting-app tlsr9518adk80d (read/write) 806060 806068 8 0.0
text 566412 566416 4 0.0
Decreases (16 builds for cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
platform target config section f88f7bb 8f14737 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 688635 688627 -8 -0.0
.text 597292 597284 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1234039 1233783 -256 -0.0
(read/write) 564396 564292 -104 -0.0
.flash.rodata 315096 314992 -104 -0.0
.flash.text 1228655 1228399 -256 -0.0
linux all-clusters-app debug (read only) 3086657 3086521 -136 -0.0
(read/write) 158360 158352 -8 -0.0
.init_array 1200 1192 -8 -0.7
.text 2620850 2620738 -112 -0.0
all-clusters-minimal-app debug (read only) 2912449 2912313 -136 -0.0
(read/write) 149792 149784 -8 -0.0
.init_array 1176 1168 -8 -0.7
.text 2450098 2449986 -112 -0.0
bridge-app debug+rpc (read only) 2412801 2412665 -136 -0.0
(read/write) 129560 129552 -8 -0.0
.init_array 848 840 -8 -0.9
.text 2034018 2033906 -112 -0.0
lighting-app debug+rpc (read only) 2640233 2640113 -120 -0.0
(read/write) 132248 132240 -8 -0.0
.init_array 944 936 -8 -0.8
.text 2236162 2236066 -96 -0.0
lock-app debug (read only) 2602241 2602121 -120 -0.0
(read/write) 127296 127288 -8 -0.0
.init_array 920 912 -8 -0.9
.text 2186306 2186210 -96 -0.0
ota-provider-app debug (read only) 2398777 2398641 -136 -0.0
(read/write) 120824 120816 -8 -0.0
.init_array 784 776 -8 -1.0
.text 2013330 2013218 -112 -0.0
ota-requestor-app debug (read only) 2563961 2563841 -120 -0.0
(read/write) 129136 129128 -8 -0.0
.init_array 872 864 -8 -0.9
.text 2162370 2162274 -96 -0.0
shell debug (read only) 2626433 2622889 -3544 -0.1
(read/write) 143016 142880 -136 -0.1
.data.rel.ro 78064 77936 -128 -0.2
.init_array 1048 1040 -8 -0.8
.rodata 240178 239730 -448 -0.2
.text 2226610 2223778 -2832 -0.1
tv-app debug (read only) 3236713 3233153 -3560 -0.1
(read/write) 261752 261616 -136 -0.1
.data.rel.ro 80272 80144 -128 -0.2
.init_array 1080 1072 -8 -0.7
.rodata 268184 267736 -448 -0.2
.text 2775186 2772338 -2848 -0.1
tv-casting-app debug (read only) 5585641 5580905 -4736 -0.1
(read/write) 161896 161728 -168 -0.1
.data.rel.ro 101224 101096 -128 -0.1
.got 4896 4888 -8 -0.2
.init_array 1064 1056 -8 -0.8
.rodata 355961 355481 -480 -0.1
.text 4954226 4950322 -3904 -0.1
nrfconnect lighting-app nrf52840dongle_nrf52840 text 752658 752654 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 text 742342 742338 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22097476 22097475 -1 -0.0
telink ota-requestor-app tlsr9518adk80d text 565288 565286 -2 -0.0
Full report (61 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f88f7bb 8f14737 change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069812 1069812 0 0.0
bl602+rpc (read/write) 1435974 1435974 0 0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101416 1101416 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1509373 1509373 0 0.0
.debug_aranges 132040 132040 0 0.0
.debug_frame 484428 484428 0 0.0
.debug_info 37964828 37964828 0 0.0
.debug_line 5257208 5257208 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358064 358064 0 0.0
.debug_str 3451542 3451542 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565954 565954 0 0.0
.symtab 171968 171968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957780 957780 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1646772 1646772 0 0.0
.debug_aranges 139544 139544 0 0.0
.debug_frame 509800 509800 0 0.0
.debug_info 41877796 41877796 0 0.0
.debug_line 5632788 5632788 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380864 380864 0 0.0
.debug_str 3847670 3847670 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625127 625127 0 0.0
.symtab 189776 189776 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031486 1031486 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677871 677871 0 0.0
(read/write) 173688 173688 0 0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89887 89887 0 0.0
.text 587672 587672 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642111 642119 8 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 79023 79023 0 0.0
.text 562768 562776 8 0.0
lock-ftd LP_CC2652R7 (read only) 676379 676379 0 0.0
(read/write) 172316 172316 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77411 77411 0 0.0
.text 598488 598488 0 0.0
lock-mtd LP_CC2652R7 (read only) 660167 660167 0 0.0
(read/write) 184216 184216 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103263 103263 0 0.0
.text 556424 556424 0 0.0
pump-app LP_CC2652R7 (read only) 688635 688627 -8 -0.0
(read/write) 160796 160804 8 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90859 90859 0 0.0
.text 597292 597284 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 672911 672911 0 0.0
(read/write) 176616 176616 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86407 86407 0 0.0
.text 586024 586024 0 0.0
shell LP_CC2652R7 (read only) 668890 668890 0 0.0
(read/write) 184988 184988 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86594 86594 0 0.0
.text 581980 581980 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588542 588542 0 0.0
.app_xip_area 465128 465128 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592590 592590 0 0.0
.app_xip_area 463880 463880 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544482 544482 0 0.0
.app_xip_area 426148 426148 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974732 974732 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 820188 820188 0 0.0
BRD4161A+rs911x (read/write) 1034672 1034672 0 0.0
.bss 186744 186744 0 0.0
.data 2092 2092 0 0.0
.text 845812 845812 0 0.0
BRD4187C (read/write) 1146720 1146720 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980864 980864 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160424 1160424 0 0.0
.bss 158272 158272 0 0.0
.data 2100 2100 0 0.0
.text 1000032 1000032 0 0.0
window-app BRD4187C (read/write) 1139940 1139940 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972644 972644 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223970 1223970 0 0.0
(read/write) 1788470 1788470 0 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258024 258024 0 0.0
.flash.text 1223970 1223970 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234039 1233783 -256 -0.0
(read/write) 564396 564292 -104 -0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315096 314992 -104 -0.0
.flash.text 1228655 1228399 -256 -0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 671992 672008 16 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592364 592380 16 0.0
lock k32w0+release (read/write) 633484 633484 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553076 553076 0 0.0
linux all-clusters-app debug (read only) 3086657 3086521 -136 -0.0
(read/write) 158360 158352 -8 -0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87016 87016 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1200 1192 -8 -0.7
.rodata 281419 281419 0 0.0
.text 2620850 2620738 -112 -0.0
all-clusters-minimal-app debug (read only) 2912449 2912313 -136 -0.0
(read/write) 149792 149784 -8 -0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 1176 1168 -8 -0.7
.rodata 280907 280907 0 0.0
.text 2450098 2449986 -112 -0.0
bridge-app debug+rpc (read only) 2412801 2412665 -136 -0.0
(read/write) 129560 129552 -8 -0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68680 68680 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 848 840 -8 -0.9
.rodata 211232 211232 0 0.0
.text 2034018 2033906 -112 -0.0
chip-tool debug (read only) 11081345 11081345 0 0.0
(read/write) 658440 658440 0 0.0
.bss 25944 25944 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623080 623080 0 0.0
.dynamic 608 608 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 592221 592221 0 0.0
.text 8965204 8965204 0 0.0
chip-tool-ipv6only arm64 (read only) 10436396 10436396 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262340 8262340 0 0.0
lighting-app debug+rpc (read only) 2640233 2640113 -120 -0.0
(read/write) 132248 132240 -8 -0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 944 936 -8 -0.8
.rodata 228096 228096 0 0.0
.text 2236162 2236066 -96 -0.0
lock-app debug (read only) 2602241 2602121 -120 -0.0
(read/write) 127296 127288 -8 -0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70728 70728 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 920 912 -8 -0.9
.rodata 244328 244328 0 0.0
.text 2186306 2186210 -96 -0.0
ota-provider-app debug (read only) 2398777 2398641 -136 -0.0
(read/write) 120824 120816 -8 -0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64648 64648 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 784 776 -8 -1.0
.rodata 216904 216904 0 0.0
.text 2013330 2013218 -112 -0.0
ota-requestor-app debug (read only) 2563961 2563841 -120 -0.0
(read/write) 129136 129128 -8 -0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 872 864 -8 -0.9
.rodata 223952 223952 0 0.0
.text 2162370 2162274 -96 -0.0
shell debug (read only) 2626433 2622889 -3544 -0.1
(read/write) 143016 142880 -136 -0.1
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78064 77936 -128 -0.2
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1040 -8 -0.8
.rodata 240178 239730 -448 -0.2
.text 2226610 2223778 -2832 -0.1
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
tv-app debug (read only) 3236713 3233153 -3560 -0.1
(read/write) 261752 261616 -136 -0.1
.bss 170552 170552 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80272 80144 -128 -0.2
.dynamic 608 608 0 0.0
.got 4976 4976 0 0.0
.init 27 27 0 0.0
.init_array 1080 1072 -8 -0.7
.rodata 268184 267736 -448 -0.2
.text 2775186 2772338 -2848 -0.1
tv-casting-app debug (read only) 5585641 5580905 -4736 -0.1
(read/write) 161896 161728 -168 -0.1
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101224 101096 -128 -0.1
.dynamic 608 608 0 0.0
.got 4896 4888 -8 -0.2
.init 27 27 0 0.0
.init_array 1064 1056 -8 -0.8
.rodata 355961 355481 -480 -0.1
.text 4954226 4950322 -3904 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2528660 2528660 0 0.0
.bss 222752 222752 0 0.0
.data 5592 5592 0 0.0
.text 1491276 1491276 0 0.0
all-clusters-minimal-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2477496 2477496 0 0.0
.bss 222024 222024 0 0.0
.data 5568 5568 0 0.0
.text 1440092 1440092 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465492 2465492 0 0.0
.bss 216724 216724 0 0.0
.data 5848 5848 0 0.0
.text 1428108 1428108 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452768 2452768 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415412 1415412 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2414140 2414140 0 0.0
.bss 215040 215040 0 0.0
.data 5752 5752 0 0.0
.text 1376756 1376756 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188191 1188191 0 0.0
bss 145301 145301 0 0.0
rodata 144836 144836 0 0.0
text 816996 816996 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167475 1167475 0 0.0
bss 144528 144528 0 0.0
rodata 136576 136576 0 0.0
text 805330 805334 4 0.0
light-switch-app nrf52840dk_nrf52840 (read/write) 1100435 1100435 0 0.0
bss 136907 136907 0 0.0
rodata 122072 122072 0 0.0
text 760432 760432 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 1148683 1148683 0 0.0
bss 148037 148037 0 0.0
rodata 117120 117120 0 0.0
text 801174 801174 0 0.0
nrf52840dongle_nrf52840 (read/write) 1086123 1086123 0 0.0
bss 154298 154298 0 0.0
rodata 94792 94792 0 0.0
text 752658 752654 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1080386 1080386 0 0.0
bss 142980 142980 0 0.0
rodata 118340 118340 0 0.0
text 735954 735954 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1133959 1133959 0 0.0
bss 137912 137912 0 0.0
rodata 143524 143524 0 0.0
text 771636 771640 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1036614 1036614 0 0.0
bss 133797 133797 0 0.0
rodata 135928 135928 0 0.0
text 683826 683826 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1089335 1089335 0 0.0
bss 136736 136736 0 0.0
rodata 119340 119340 0 0.0
text 752244 752244 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1075655 1075655 0 0.0
bss 136503 136503 0 0.0
rodata 115820 115820 0 0.0
text 742342 742338 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745940 1745940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1231262 1231262 0 0.0
.debug_aranges 110712 110712 0 0.0
.debug_frame 371204 371204 0 0.0
.debug_info 26899492 26899492 0 0.0
.debug_line 3673871 3673871 0 0.0
.debug_loc 3588816 3588816 0 0.0
.debug_ranges 337960 337960 0 0.0
.debug_str 3435299 3435299 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570460 570460 0 0.0
.symtab 421744 421744 0 0.0
.text 1546160 1546160 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688548 1688548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1223105 1223105 0 0.0
.debug_aranges 110184 110184 0 0.0
.debug_frame 374284 374284 0 0.0
.debug_info 26636122 26636122 0 0.0
.debug_line 3694663 3694663 0 0.0
.debug_loc 3576453 3576453 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3424320 3424320 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534549 534549 0 0.0
.symtab 408176 408176 0 0.0
.text 1489504 1489504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607004 1607004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1057613 1057613 0 0.0
.debug_aranges 102384 102384 0 0.0
.debug_frame 344600 344600 0 0.0
.debug_info 22097476 22097475 -1 -0.0
.debug_line 3264197 3264197 0 0.0
.debug_loc 3274179 3274179 0 0.0
.debug_ranges 301872 301872 0 0.0
.debug_str 3229759 3229759 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470874 470874 0 0.0
.symtab 376560 376560 0 0.0
.text 1416144 1416144 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640780 1640780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1059619 1059619 0 0.0
.debug_aranges 102784 102784 0 0.0
.debug_frame 346472 346472 0 0.0
.debug_info 22330842 22330843 1 0.0
.debug_line 3261187 3261187 0 0.0
.debug_loc 3301773 3301773 0 0.0
.debug_ranges 303816 303816 0 0.0
.debug_str 3249234 3249234 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473277 473277 0 0.0
.symtab 378240 378240 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149960 1149968 8 0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597060 597068 8 0.0
lock-app qpg6105+debug (read/write) 1114752 1114760 8 0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561848 561856 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790820 790820 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554264 554266 2 0.0
lighting-app tlsr9518adk80d (read/write) 806060 806068 8 0.0
bss 73240 73240 0 0.0
noinit 43520 43520 0 0.0
text 566412 566416 4 0.0
ota-requestor-app tlsr9518adk80d (read/write) 804952 804952 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565288 565286 -2 -0.0

@Damian-Nordic
Copy link
Contributor

After second thought, if we provide two ways to do the similar thing, it will confuse the platform vendors, maybe you are right, by removing DeviceNetworkProvisioningDelegate API, we can force vendors to use NetworkCommissioning drivers to provision WiFi.

Yes, if the NetworkCommissioning API is suitable for other needs, too, I think it would be better to remove DeviceNetworkProvisioningDelegate. Mostly because it is currently not tested by any CI tests.

@yufengwangca yufengwangca merged commit 7b8c574 into project-chip:master Nov 3, 2022
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@yufengwangca @adbridge
Remove DeviceNetworkProvisioningDelegate interface to force vendor to…
b147e50 
… use NetworkCommissioning interface… (project-chip#23391)

* Remove intermediate CRTP layer from DeviceNetworkProvisioningDelegate

* Remove DeviceNetworkProvisioningDelegate interface
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@yufengwangca @adbridge
Remove DeviceNetworkProvisioningDelegate interface to force vendor to…
b716e33 
… use NetworkCommissioning interface… (project-chip#23391)

* Remove intermediate CRTP layer from DeviceNetworkProvisioningDelegate

* Remove DeviceNetworkProvisioningDelegate interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emargolis emargolis emargolis approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq arkq is a code owner

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin efr32 esp32 lib linux nrf connect platform review - approved shell telink zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yufengwangca @Damian-Nordic @emargolis