Fix completion naming in Darwin framework. #23429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22557
branch
4 times, most recently
from
8b8614a to
37feecb
Compare
|
PR #23429: Size comparison from f88f7bb to 37feecb Increases (7 builds for bl602, k32w, nrfconnect, qpg, telink)
Full report (15 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22557
branch
from
37feecb to
91db54f
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton and
jepenven-silabs
pullapprove
bot
requested review from
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
bzbarsky-apple
force-pushed
the
darwin-reland-PR-22557
branch
from
91db54f to
e5adce4
Compare
|
PR #23429: Size comparison from a92b952 to e5adce4 Increases (5 builds for cyw30739, k32w, psoc6, qpg)
Decreases (4 builds for bl602, esp32, nrfconnect, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
anush-apple
reviewed
Nov 2, 2022
anush-apple
approved these changes
Nov 2, 2022
|
Fast-tracking platform change with platform owner review. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22557 but modified to preserve the old APIs. * Rename all "completionHandler" selectors/arguments to "completion". * Rename everything ending with "CompletionHandler" to end with "Completion". * Make sure we consistently use "queue" for callback queues, not "clientQueue". * Add MTR prefixes to remaining un-prefixed block typedefs. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * In MTRAttributeCacheContainer.h we're only changing an MTR_NEWLY_AVAILABLE thing. * In MTRBaseDevice.h we're changing MTR_NEWLY_AVAILABLE things (except deregisterReportHandlersWithQueue, which has a shim). * MTRCallbackBridgeBase_internal.h is not public API. * In MTRDeviceController+XPC.h the changes are source and binary compatible. * MTRDeviceController_Internal.h is not public API. * MTRDeviceOverXPC.h is not public API. * MTRCallbackBridge_internal.h is not public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-landing of PR #22557 but modified to preserve the old APIs.
The header changes not accompanied by backwards-compat shims are OK for the following reasons: