-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic-callback-stubs.cpp to the Darwin framework for now. #23488
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:update-xcode-callbacks
Nov 4, 2022
Merged
Add generic-callback-stubs.cpp to the Darwin framework for now. #23488
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:update-xcode-callbacks
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These callback bits used to be in callback-stub.cpp, which is included in the framwork. Also removes some completely unused callbacks. Fixes project-chip#23442
PR #23488: Size comparison from 42b4438 to 5df61e7 Increases (5 builds for bl702, cyw30739, esp32, nrfconnect, telink)
Decreases (9 builds for bl602, bl702, esp32, psoc6, telink)
Full report (44 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 4, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23488) These callback bits used to be in callback-stub.cpp, which is included in the framwork. Also removes some completely unused callbacks. Fixes project-chip#23442
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ect-chip#23488) These callback bits used to be in callback-stub.cpp, which is included in the framwork. Also removes some completely unused callbacks. Fixes project-chip#23442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These callback bits used to be in callback-stub.cpp, which is included in the framwork.
Also removes some completely unused callbacks.
Fixes #23442