Add chip_external_mbedtls flag to src/crypto #23538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 4, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 5, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 10, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 11, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 11, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 11, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 11, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 11, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 12, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 15, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 15, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 15, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 16, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 16, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 16, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 17, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 17, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 18, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 18, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 18, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 19, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 20, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 21, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 23, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
ATmobica
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
May 23, 2023
src/crypto/crypto.gni has been updated to remove the assert added by project-chip#23538. This assert assumes that you only build mbedtls externally if you have chip_crypto = 'mbedtls'. This is an invalid assumption and is certainly not the case for the Open IoT SDK. Signed-off-by: Anna Bridge <anna.bridge@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows mbedtls to be compiled outside of the Matter gn build routine, for build targets that wish to share mbedtls symbols.
Currently the zephyr target avoids building mbedtls. Expose this flag so that any target can set this for the Matter crypto library. The default value is false unless using the zephyr os, so this should not introduce any change to existing targets in the SDK.