-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out non-codegen callback logic from callbacks.h into separate header #23617
Merged
andy31415
merged 7 commits into
project-chip:master
from
andy31415:split_generic_callbacks.h
Nov 23, 2022
Merged
Split out non-codegen callback logic from callbacks.h into separate header #23617
andy31415
merged 7 commits into
project-chip:master
from
andy31415:split_generic_callbacks.h
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on still needs to be fixed
…eric callbacks are required
PR #23617: Size comparison from 6519b91 to 48bf32d Increases (9 builds for bl702, psoc6, telink)
Decreases (1 build for esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
commented
Nov 15, 2022
PR #23617: Size comparison from 3fa2104 to 2b63c92 Increases (13 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23617: Size comparison from 3b0fb58 to 22f1bb8 Increases (11 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (3 builds for bl602, bl702, cc13x2_26x2)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Nov 22, 2022
yunhanw-google
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to have code-gen data depend only on codegen input.
We have a set of callbacks that are not dependent on codegen (i.e. not cluster/commands) and these can be split out. This simplifies includes for some files (only generic callbacks are needed) and moves closer towards having a clearer picture of what needs codegen and what not.
Testing: