-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Check app options by iterate over given set #23634
Merged
Merged
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of iterating over available options and trying to get them from app extra data, iterate over extra data and match them with available options. This approach will fix errors generated by Tizen API call app_control_get_extra_data() when used with not available key.
PR #23634: Size comparison from 700ee0e to 335c629 Increases (6 builds for bl702, esp32, psoc6, telink)
Decreases (4 builds for bl602, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 16, 2022
bzbarsky-apple
approved these changes
Nov 16, 2022
yufengwangca
approved these changes
Nov 17, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Instead of iterating over available options and trying to get them from app extra data, iterate over extra data and match them with available options. This approach will fix errors generated by Tizen API call app_control_get_extra_data() when used with not available key.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Instead of iterating over available options and trying to get them from app extra data, iterate over extra data and match them with available options. This approach will fix errors generated by Tizen API call app_control_get_extra_data() when used with not available key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is lots of error messages in Tizen log when launching Tizen example CHIP app. Tizen API call
app_control_get_extra_data()
reports error when used with not available key.Changes
Instead of iterating over available options and trying to get them from app extra data, iterate over extra data and match them with available options.
Testing
Tested with Tizen lighting app. After these changes,
app_control_get_extra_data()
does not report errors like these any more: