Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all mention of "pairing" from non-deprecated Darwin public APIs. #23647

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Remove all mention of "pairing" from non-deprecated Darwin public APIs. #23647

merged 1 commit into from
Nov 17, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This is a re-landing of PR #22676, but with backwards-compat shims in place.

The change to MTRDeviceControllerDelegate is OK because this is a newly-introduced protocol.

@bzbarsky-apple
Remove all mention of "pairing" from non-deprecated Darwin public APIs.
f6d01eb 
This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place.

The change to MTRDeviceControllerDelegate is OK because this is a
newly-introduced protocol.
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

PR #23647: Size comparison from 361c74d to f6d01eb

Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
platform target config section 361c74d f6d01eb change % change
bl602 lighting-app bl602 .text 1059626 1059628 2 0.0
bl702 lighting-app bl702 .debug_info 39163107 39163108 1 0.0
.text 955954 955956 2 0.0
bl702+rpc .debug_info 43432308 43432309 1 0.0
.text 1029652 1029654 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183276 183284 8 0.0
esp32 all-clusters-app c3devkit (read only) 1224618 1224620 2 0.0
.flash.text 1224618 1224620 2 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 805794 805798 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27026555 27026557 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22462020 22462022 2 0.0
telink all-clusters-app tlsr9518adk80d text 649006 649008 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 612990 612994 4 0.0
Decreases (7 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
platform target config section 361c74d f6d01eb change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 661083 661075 -8 -0.0
.text 557296 557288 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543978 543970 -8 -0.0
.app_xip_area 425708 425700 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 564420 564412 -8 -0.0
.flash.rodata 315136 315128 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22228397 22228396 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 791004 790996 -8 -0.0
text 554454 554452 -2 -0.0
lighting-app tlsr9518adk80d text 624418 624416 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805496 805488 -8 -0.0
text 565834 565832 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 361c74d f6d01eb change % change
bl602 lighting-app bl602 (read/write) 1375778 1375778 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1059626 1059628 2 0.0
bl602+rpc (read/write) 1421594 1421594 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1091120 1091120 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195655 1195655 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1523925 1523925 0 0.0
.debug_aranges 132328 132328 0 0.0
.debug_frame 485340 485340 0 0.0
.debug_info 39163107 39163108 1 0.0
.debug_line 5273098 5273098 0 0.0
.debug_loc 3367914 3367914 0 0.0
.debug_ranges 360296 360296 0 0.0
.debug_str 3463623 3463623 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116568 116568 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 566910 566910 0 0.0
.symtab 171888 171888 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955954 955956 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283795 1283795 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1667955 1667955 0 0.0
.debug_aranges 140392 140392 0 0.0
.debug_frame 512544 512544 0 0.0
.debug_info 43432308 43432309 1 0.0
.debug_line 5668467 5668467 0 0.0
.debug_loc 3562150 3562150 0 0.0
.debug_ranges 383320 383320 0 0.0
.debug_str 3860938 3860938 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130200 130200 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 627125 627125 0 0.0
.symtab 190000 190000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029652 1029654 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678427 678427 0 0.0
(read/write) 173108 173108 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89851 89851 0 0.0
.text 588264 588264 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642723 642723 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78987 78987 0 0.0
.text 563416 563416 0 0.0
lock-ftd LP_CC2652R7 (read only) 676559 676559 0 0.0
(read/write) 172544 172544 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77271 77271 0 0.0
.text 598808 598808 0 0.0
lock-mtd LP_CC2652R7 (read only) 661083 661075 -8 -0.0
(read/write) 183276 183284 8 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103307 103307 0 0.0
.text 557296 557288 -8 -0.0
pump-app LP_CC2652R7 (read only) 689007 689007 0 0.0
(read/write) 160832 160832 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90759 90759 0 0.0
.text 597764 597764 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673291 673291 0 0.0
(read/write) 176644 176644 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86307 86307 0 0.0
.text 586504 586504 0 0.0
shell LP_CC2652R7 (read only) 669646 669646 0 0.0
(read/write) 184208 184208 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86598 86598 0 0.0
.text 582732 582732 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587494 587494 0 0.0
.app_xip_area 463704 463704 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591602 591602 0 0.0
.app_xip_area 462516 462516 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543978 543970 -8 -0.0
.app_xip_area 425708 425700 -8 -0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974460 974460 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 820012 820012 0 0.0
BRD4161A+rs911x (read/write) 1035208 1035208 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 846436 846436 0 0.0
BRD4187C (read/write) 1147064 1147064 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 981296 981296 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160416 1160416 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1000108 1000108 0 0.0
window-app BRD4187C (read/write) 1140284 1140284 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 973076 973076 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224618 1224620 2 0.0
(read/write) 1788614 1788614 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258184 258184 0 0.0
.flash.text 1224618 1224620 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234463 1234463 0 0.0
(read/write) 564420 564412 -8 -0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315136 315128 -8 -0.0
.flash.text 1229079 1229079 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662052 662052 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 563724 563724 0 0.0
light k32w0+release (read/write) 672072 672072 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 592372 592372 0 0.0
lock k32w0+release (read/write) 633612 633612 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553132 553132 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10435580 10435580 0 0.0
(read/write) 706529 706529 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650832 650832 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518412 518412 0 0.0
.text 8261380 8261380 0 0.0
thermostat-no-ble arm64 (read only) 2394796 2394796 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144980 144980 0 0.0
.text 2005920 2005920 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452592 2452592 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1415236 1415236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188127 1188127 0 0.0
bss 145285 145285 0 0.0
rodata 144516 144516 0 0.0
text 817248 817248 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167539 1167539 0 0.0
bss 144512 144512 0 0.0
rodata 136304 136304 0 0.0
text 805794 805798 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746708 1746708 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235724 1235724 0 0.0
.debug_aranges 110728 110728 0 0.0
.debug_frame 371396 371396 0 0.0
.debug_info 27026555 27026557 2 0.0
.debug_line 3687259 3687259 0 0.0
.debug_loc 3605093 3605093 0 0.0
.debug_ranges 339592 339592 0 0.0
.debug_str 3432518 3432518 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570636 570636 0 0.0
.symtab 421600 421600 0 0.0
.text 1546944 1546944 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1689244 1689244 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227567 1227567 0 0.0
.debug_aranges 110200 110200 0 0.0
.debug_frame 374476 374476 0 0.0
.debug_info 26763186 26763186 0 0.0
.debug_line 3708243 3708243 0 0.0
.debug_loc 3592699 3592699 0 0.0
.debug_ranges 338208 338208 0 0.0
.debug_str 3421538 3421538 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534725 534725 0 0.0
.symtab 408032 408032 0 0.0
.text 1490216 1490216 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1607420 1607420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062028 1062028 0 0.0
.debug_aranges 102400 102400 0 0.0
.debug_frame 344788 344788 0 0.0
.debug_info 22228397 22228396 -1 -0.0
.debug_line 3277368 3277368 0 0.0
.debug_loc 3290184 3290184 0 0.0
.debug_ranges 303488 303488 0 0.0
.debug_str 3227073 3227073 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471050 471050 0 0.0
.symtab 376400 376400 0 0.0
.text 1416576 1416576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1641428 1641428 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064003 1064003 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346664 346664 0 0.0
.debug_info 22462020 22462022 2 0.0
.debug_line 3274488 3274488 0 0.0
.debug_loc 3318037 3318037 0 0.0
.debug_ranges 305448 305448 0 0.0
.debug_str 3246430 3246430 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473453 473453 0 0.0
.symtab 378096 378096 0 0.0
.text 1445592 1445592 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151072 1151072 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 598172 598172 0 0.0
lock-app qpg6105+debug (read/write) 1116768 1116768 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 563864 563864 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937656 937656 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 649006 649008 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875648 875648 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 612990 612994 4 0.0
light-switch-app tlsr9518adk80d (read/write) 791004 790996 -8 -0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 554454 554452 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 875228 875228 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624418 624416 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 805496 805488 -8 -0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 565834 565832 -2 -0.0

@vivien-apple vivien-apple merged commit bdfc185 into project-chip:master Nov 17, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-reland-PR-22676 branch November 17, 2022 15:48
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Remove all mention of "pairing" from non-deprecated Darwin public API…
9fab213 
…s. (project-chip#23647)

This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place.

The change to MTRDeviceControllerDelegate is OK because this is a
newly-introduced protocol.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Remove all mention of "pairing" from non-deprecated Darwin public API…
4a11c52 
…s. (project-chip#23647)

This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place.

The change to MTRDeviceControllerDelegate is OK because this is a
newly-introduced protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yufengwangca @vivien-apple