-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use zap-cli
for zap codegen instead of using third_party/zap/repo
#23664
Use zap-cli
for zap codegen instead of using third_party/zap/repo
#23664
Conversation
Doesn't have to be an env var, but the specific request is: have some way to run either generate.py or zap_regen_all.py and have it run a development version of zap. Have the script raise a useful error if it can't find zap, which allows discovering how to use either a release or development version. Similarly for run_zaptool.sh. |
Updated all scripts to support:
|
Will be out for a week, don't want this to be blocked.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #23664: Size comparison from 287c1b5 to 64835d1 Increases (2 builds for bl702)
Full report (12 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
|
PR #23664: Size comparison from 287c1b5 to de4a27f Increases (8 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23664: Size comparison from 287c1b5 to 1e0ce1a Increases (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (28 builds for bl702, cc13x2_26x2, cyw30739, k32w, linux, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast track: had several review passes and this was verified on both linux and mac. Unlikely to be able to review more next week given thanks giving. |
This uses #23643 - our docker images now contain zap-cli which is usable for zap codegen:
Changes:
zap-cli
instead ofnpm ...
third_party/zap
as a submodule