-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup ChipDeviceController for all Matter commands #23712
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/controller
Nov 22, 2022
Merged
Setup ChipDeviceController for all Matter commands #23712
yunhanw-google
merged 1 commit into
project-chip:master
from
yufengwangca:pr/java/controller
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
approved these changes
Nov 22, 2022
PR #23712: Size comparison from 669cd47 to e2623ef Increases (9 builds for bl602, bl702, cc13x2_26x2, telink)
Decreases (6 builds for cc13x2_26x2, nrfconnect, telink)
Full report (31 builds for bl602, bl702, cc13x2_26x2, efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #23712: Size comparison from 669cd47 to 658794d Increases (7 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (2 builds for bl702, cc13x2_26x2)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Merged
jmartinez-silabs
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Matter command does not have access to ChipDeviceController reference to trigger the operations in SDK.
Now the ChipDeviceController instance has been initiated in the java-matter-controller, we can populate the reference of ChipDeviceController instance to all Matter commands.
This is needed for both discover and pairing command implementation.