-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set separate temporary directory for zap cli, to have independent unpacks #23842
Merged
andy31415
merged 4 commits into
project-chip:master
from
andy31415:fix_unpack_race_in_zap
Dec 5, 2022
Merged
Set separate temporary directory for zap cli, to have independent unpacks #23842
andy31415
merged 4 commits into
project-chip:master
from
andy31415:fix_unpack_race_in_zap
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23842: Size comparison from 66c6681 to 24ddeb5 Increases (9 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, k32w, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23842: Size comparison from 1e06479 to 0d7f4a6 Increases (7 builds for bl602, bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (9 builds for cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 3, 2022
PR #23842: Size comparison from 9c0ca13 to 0e6d730 Increases (10 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, electron seems to use
/tmp/pkg
and that can conflict like in https://github.com/project-chip/connectedhomeip/actions/runs/3586487383/jobs/6035736773:Testing: ran regen all, saw different temp directories being created AND cleaned (previously they were not cleaned).