-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add support for INFINITY and -INFINITY argument to float/… #23888
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_FloatDouble_InfinityKeyword
Dec 7, 2022
Merged
[chip-tool] Add support for INFINITY and -INFINITY argument to float/… #23888
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_FloatDouble_InfinityKeyword
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Dec 2, 2022
PR #23888: Size comparison from 013514b to fa55dc1 Increases (10 builds for cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, esp32, psoc6)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Dec 3, 2022
fa55dc1
to
f319d98
Compare
PR #23888: Size comparison from 9c0ca13 to f319d98 Increases (10 builds for cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, esp32)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
emargolis
approved these changes
Dec 5, 2022
Tidy fails:
|
f319d98
to
a1ddd39
Compare
PR #23888: Size comparison from c010eec to a1ddd39 Increases (6 builds for cc13x2_26x2, esp32, linux, psoc6)
Decreases (9 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…double arguments
Problem
The
Infinity
and-Infinity
keyword can not be used for float/double arguments on the command line withchip-tool
.