-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power source server: Use ember function for array indexing #29892
Merged
mergify
merged 4 commits into
project-chip:master
from
cecille:power_source_server_use_ember
Oct 27, 2023
Merged
Power source server: Use ember function for array indexing #29892
mergify
merged 4 commits into
project-chip:master
from
cecille:power_source_server_use_ember
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix warning when there are no power servers and no dynamic eps.
PR #29892: Size comparison from 8c986c7 to 9207ab9 Increases (1 build for telink)
Decreases (19 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29892: Size comparison from 7287731 to 02454b2 Increases (1 build for telink)
Decreases (15 builds for cc32xx, efr32, esp32, linux, nrfconnect, telink)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
andy31415
reviewed
Oct 23, 2023
PR #29892: Size comparison from 7287731 to ca7a193 Increases above 0.2%:
Increases (19 builds for bl702, cc13x4_26x4, k32w, linux, qpg, telink)
Decreases (22 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, nrfconnect, telink)
Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
andy31415
approved these changes
Oct 27, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…hip#29892) * Use ember function for array indexing Also fix warning when there are no power servers and no dynamic eps. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix warning when there are no power servers and no dynamic eps.