[nrfconnect] Improve CHIP_MEMORY_PROFILING config #32827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #32827: Size comparison from a7c9a7b to 2f5d3ba Decreases (1 build for efr32)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
- Enabled the full SHELL option when memory profiling is enabled.
ArekBalysNordic
force-pushed
the
memory_profiling_improvement
branch
from
2f5d3ba to
3ddce6d
Compare
Damian-Nordic
approved these changes
Apr 3, 2024
|
PR #32827: Size comparison from a7c9a7b to 3ddce6d Decreases (1 build for efr32)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jmartinez-silabs
approved these changes
Apr 3, 2024
kkasperczyk-no
pushed a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
Apr 24, 2024
- Enabled the full SHELL option when memory profiling is enabled.
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* [nrfconnect][zephyr] Improvements and Fixes for WiFi according to NCS 2.6.0 (#32711) * [nrfconnect] wifi: avoid unwanted connect request It's pointless to issue a connect request in case no valid SSID has been found. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [nrfconnect] wifi: Fix 5GHz association Wi-Fi stack recently introduced a check for valid band value and the default value of 0 (memset) means only 2.4GHz, so, 5GHz Wi-Fi associations will fail. Fix the default to Unknown to scan all supported bands. * [zephyr][nrfconnect] Make Wi-Fi manager use Wi-Fi interface only Find the Wi-Fi interface at the Wi-Fi manager initialization and use that interface instead of the default interface when calling Wi-Fi management functions. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * [nrfconnect] fix handling of LastNetworkID in Wi-Fi driver This commit makes sure that correct Network ID is provided to the Network Commissioning cluster from the platform's Wi-Fi driver. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * [inet] Combine platform handlers for joining/leaving mcast group Instead, use a single handler for both joining and leaving a multicast group to reduce the code duplication. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * [zephyr][nrfconnect] Move handler for joining/leaving mcast group Move the platform handler for joining and leaving a multicast group to ConnectivityManagerImpl to support Matter stack on a system with multiple network interfaces (Thread + Wi-Fi). Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * [nrfconnect] Added DNS server refresh after adding new IPv6 address The Wi-Fi device does not update mDNS queries after obtaining new IPv6 GUA address, so for some time after assigning prefix, the Thread Border Routers still use cached link-local address, which is not routable. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * [nrfconnect] [zephyr] Disable synchronous printk Disable synchronous printk to avoid blocking IRQs which may affect time sensitive components (like 15.4 radio). Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [nrfconnect] Fix various Wi-Fi issues with error code handling This commit handles a few issues with Wi-Fi connection or scanning: - Use wifi_status structure instead of incompatible WiFiRequestStatus - On connect error value > 2 do not report success - On scan error value > 1 do not report success - Provide value of mandatory LastConnectErrorValue attribute Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * [nrfconnect] Minor Wi-Fi refinements * error code handling unification * added GetWantedNetwork getter and use it when handling network status change * minor refactoring Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Restyled by clang-format * [nrfconnect] Provide a workaround for nrfconnect Posix unit tests. We need to disable all dependencies to the Zephyr net_if module until we switch unit tests to it. * Restyled by gn * Use Enum to indicate an operation instead of bool in MulticastGroupHandler --------- Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Co-authored-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Co-authored-by: Damian Krolik <damian.krolik@nordicsemi.no> Co-authored-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Co-authored-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Co-authored-by: Restyled.io <commits@restyled.io> * [nrfconnect] Improve CHIP_MEMORY_PROFILING config (#32827) - Enabled the full SHELL option when memory profiling is enabled. * [dnssd] Allow selecting DNS-SD implementation at runtime (#32829) Add Resolver::SetInstance() and ServiceAdvertiser::SetInstance() methods for dynamically changing the system-wide DNS-SD implementation used by Matter. Also, allow for building "minimal" and "platform" DNS-SD implementations together. Co-authored-by: Damian Krolik <damian.krolik@nordicsemi.no> * [scripts] Fixed nrfconnect factory generation scripts (#32892) The factory_data.hex file is not generated as an intermediate product of factory generation process. In result, factory generation works only if merging with firmware is used or scripts are manually invoked. Added optional --size and --offset arguments to generate_nrfconnect_chip_factory_data.py script that results in calling nrfconnect_generate_partition.py internally. It solves an issue and additionally simplifies manual generation process (if selected). * [nrfconnect] Implemented WiFiNetworkDiagnostics events generation (#32962) * Added generation of optional events from WiFiNetworkDiagnostics cluster. * Improved handler methods to validate the input data size * [zephyr] Fix CHIPDevicePlatformEvent.h include dependency (#33004) Currently the CHIPDevicePlatformEvent depends on the SystemPacketBuffer which is included in the CHIPDeviceEvent.h too late. The problem is silently worked around in the application when the <platform/PlatformManager.h> include is preceded by other headers that pull in SystemPacketBuffer.h, but we need a proper fix. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [zephyr] Added Bluetooth LE Extended Advertisement option (#33005) This commit implements platform solution for a Bluetooth LE extended advertising. Additionally, for the CommissioningWindowManager types were changed from Seconds16 to Seconds32, because the current implementation overflows for 48h duration. Co-authored-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no> * [clusters] Implemented ThreadDiagnosticDelegate (#32964) Added ThreadDiagnosticDelegate to enable generation of optional events from ThreadNetworkDiagnostics cluster. Additionally implemented generation of ConnectionStatus and NetworkFaultChanged events when Thread link state is changed. --------- Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Co-authored-by: Arkadiusz Bałys <arkadiusz.balys@nordicsemi.no> Co-authored-by: Marcin Kajor <marcin.kajor@nordicsemi.no> Co-authored-by: Damian Krolik <damian.krolik@nordicsemi.no> Co-authored-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled the full SHELL option when memory profiling is enabled.