Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix QR Code parsing about vendor info #33486

Merged
merged 2 commits into from
May 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -61,7 +61,6 @@ class CHIPDeviceDetailsFragment : Fragment() {
binding.discriminatorEd.setText(deviceInfo.discriminator.toString())
binding.serialNumberEd.setText(deviceInfo.serialNumber)
binding.discoveryCapabilitiesTv.text = "${deviceInfo.discoveryCapabilities}"

if (deviceInfo.optionalQrCodeInfoMap.isEmpty()) {
binding.vendorTagsLabelTv.visibility = View.GONE
binding.vendorTagsContainer.visibility = View.GONE
Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@ import kotlinx.parcelize.Parcelize
import matter.onboardingpayload.DiscoveryCapability
import matter.onboardingpayload.OnboardingPayload
import matter.onboardingpayload.OnboardingPayloadException
import matter.onboardingpayload.OptionalQRCodeInfoType

/** Class to hold the CHIP device information. */
@Parcelize
@@ -57,6 +58,13 @@ data class CHIPDeviceInfo(
if (serialNumber.isNotEmpty()) {
onboardingPayload.addSerialNumber(serialNumber)
}
optionalQrCodeInfoMap.forEach { (_, info) ->
if (info.type == OptionalQRCodeInfoType.TYPE_STRING && info.data != null) {
onboardingPayload.addOptionalVendorData(info.tag, info.data)
} else {
onboardingPayload.addOptionalVendorData(info.tag, info.intDataValue)
}
}
return onboardingPayload
}

@@ -78,8 +86,8 @@ data class CHIPDeviceInfo(
setupPayload.getLongDiscriminatorValue(),
setupPayload.setupPinCode,
setupPayload.commissioningFlow,
setupPayload.optionalQRCodeInfo.mapValues { (_, info) ->
QrCodeInfo(info.tag, info.type, info.data, info.int32)
setupPayload.getAllOptionalVendorData().associate { info ->
info.tag to QrCodeInfo(info.tag, info.type, info.data, info.int32)
},
setupPayload.discoveryCapabilities,
setupPayload.hasShortDiscriminator,
Original file line number Diff line number Diff line change
@@ -151,15 +151,15 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginBottom="8dp"
android:layout_below="@id/vendorTagsLabelTv"
android:layout_below="@id/vendorTagsContainer"
android:layout_alignParentStart="true"
android:textSize="20sp"/>
<EditText
android:id="@+id/discoveryCapabilitiesEd"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="16dp"
android:layout_below="@id/vendorTagsLabelTv"
android:layout_below="@id/vendorTagsContainer"
android:layout_toEndOf="@id/discoveryCapabilitiesLabelTv"
android:layout_alignParentEnd="true"
android:textSize="11sp"
@@ -260,6 +260,6 @@
android:layout_below="@id/showQRCodeUriBtn"
android:layout_alignParentBottom="true"
android:layout_alignParentStart="true"
android:textSize="20sp"/>
android:textSize="12sp"/>
</RelativeLayout>
</ScrollView>
Original file line number Diff line number Diff line change
@@ -178,6 +178,6 @@ private fun populateTLVBits(

for (i in 0 until tlvBufSizeInBytes) {
val value = tlvBuf[i]
populateBits(bits, offset, value.toLong(), 8, totalPayloadDataSizeInBits)
populateBits(bits, offset, value.toUByte().toLong(), 8, totalPayloadDataSizeInBits)
}
}