-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android tv-casting-app v1.3 Commissioner-Generated passcode flow #33680
Merged
mergify
merged 8 commits into
project-chip:master
from
pgregorr-amazon:droid-identificationDeclaration-2024-05-22
Jun 5, 2024
Merged
Android tv-casting-app v1.3 Commissioner-Generated passcode flow #33680
mergify
merged 8 commits into
project-chip:master
from
pgregorr-amazon:droid-identificationDeclaration-2024-05-22
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
8513ebe
to
ae50b93
Compare
PR #33680: Size comparison from 55012bf to cb82d51 Increases (3 builds for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
sharadb-amazon
requested changes
May 31, 2024
examples/tv-casting-app/android/App/app/src/main/java/com/chip/casting/app/MainActivity.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/java/com/chip/casting/app/MainActivity.java
Outdated
Show resolved
Hide resolved
...ndroid/App/app/src/main/java/com/matter/casting/ContentLauncherLaunchURLExampleFragment.java
Outdated
Show resolved
Hide resolved
...v-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java
Show resolved
Hide resolved
...tv-casting-app/android/App/app/src/main/java/com/matter/casting/EndpointSelectorExample.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
PR #33680: Size comparison from 55012bf to 008ea31 Increases above 0.2%:
Increases (24 builds for efr32, esp32, linux, nrfconnect, nxp, psoc6, stm32)
Decreases (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
...tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
...es/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/support/TargetAppInfo.java
Outdated
Show resolved
Hide resolved
...ndroid/App/app/src/main/jni/com/matter/casting/support/IdentificationDeclarationOptions.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
sharadb-amazon
approved these changes
Jun 4, 2024
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingApp.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/support/Converters-JNI.cpp
Outdated
Show resolved
Hide resolved
chrisdecenzo
approved these changes
Jun 5, 2024
...id/App/app/src/main/java/com/matter/casting/ApplicationBasicReadVendorIDExampleFragment.java
Show resolved
Hide resolved
...ing-app/android/App/app/src/main/jni/com/matter/casting/support/CommissionerDeclaration.java
Show resolved
Hide resolved
...ndroid/App/app/src/main/jni/com/matter/casting/support/IdentificationDeclarationOptions.java
Show resolved
Hide resolved
hawk248
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android tv-casting-app example app, implemented new Matter v1.3 Matter Casting User Directed Commissioning (UDC) feature Commissioner-Generated passcode commissioning flow.
Change summary
Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). With the Android example tv-casting-app app, we are able to successfully commission the Linux tv-app running on a Raspberry-Pi using the CommissioneR-generated passcode flow by long pressing on a discovered CastingPlayer. The original CommissioneE-generated passcode continues to function by (short) clicking on the discovered CastingPlayer.
Testing logs:
Android tv-casting-app CommissioneE-generated passcode.log
Android tv-casting-app CommissioneR-generated passcode Cancel.log
Android tv-casting-app CommissioneR-generated passcode.log