[Silabs] Adds feature to update network name in LCD status screen for WiFi combinations #34410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34410: Size comparison from c024e4f to 590b3ea Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
rosahay-silabs
force-pushed
the
feature/lcd-output-data
branch
from
24fde41 to
9d1a841
Compare
|
PR #34410: Size comparison from 42d03d5 to 9d1a841 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 26, 2024
* Add an optional `withLock` parameter to `UpdateLCDStatusScreen` to control concurrent access to the chip stack. * Added GetScreen API * chore: Update LCD status screen to include network name from DeviceNetworkInfo * Align `PostEvent` * chore: Set LCD screen in BaseApplication::OnPlatformEvent --------- Co-authored-by: Rohan S <3526930+brosahay@users.noreply.github.com>
|
PR #34410: Size comparison from 42d03d5 to 7fa1ea7 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 29, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
… WiFi combinations (project-chip#34410) * chore: Update network name in LCD status screen * Merge redundent event handler * chore: Update LCD status screen to include network name from DeviceNetworkInfo * Adds auto update of LCD (project-chip#322) * Add an optional `withLock` parameter to `UpdateLCDStatusScreen` to control concurrent access to the chip stack. * Added GetScreen API * chore: Update LCD status screen to include network name from DeviceNetworkInfo * Align `PostEvent` * chore: Set LCD screen in BaseApplication::OnPlatformEvent --------- Co-authored-by: Rohan S <3526930+brosahay@users.noreply.github.com> --------- Co-authored-by: Rohan S <3526930+brosahay@users.noreply.github.com>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
… WiFi combinations (project-chip#34410) * chore: Update network name in LCD status screen * Merge redundent event handler * chore: Update LCD status screen to include network name from DeviceNetworkInfo * Adds auto update of LCD (project-chip#322) * Add an optional `withLock` parameter to `UpdateLCDStatusScreen` to control concurrent access to the chip stack. * Added GetScreen API * chore: Update LCD status screen to include network name from DeviceNetworkInfo * Align `PostEvent` * chore: Set LCD screen in BaseApplication::OnPlatformEvent --------- Co-authored-by: Rohan S <3526930+brosahay@users.noreply.github.com> --------- Co-authored-by: Rohan S <3526930+brosahay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the LCD status screen to show proper SSID and connected state for WiFi applications.