[ICD] Implement the support of the ICD Check-In BackOff #34482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
lib
app
core
icd
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
|
PR #34482: Size comparison from 8ad0bdf to c8b04e7 Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, stm32, tizen)
|
jmartinez-silabs
approved these changes
Jul 24, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
reviewed
Jul 26, 2024
andy31415
approved these changes
Jul 26, 2024
mkardous-silabs
force-pushed
the
feature/check_in_backoff
branch
from
acb71f9 to
f1484c0
Compare
|
PR #34482: Size comparison from 63d38ea to f1484c0 Full report (3 builds for cc32xx, stm32)
|
|
PR #34482: Size comparison from 63d38ea to ca9e27f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 26, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #34482: Size comparison from 63d38ea to 4755d13 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…#34482) * Add MaximunCheckInBackOff attribute to ICDM cluster * Add injectable ICD Check-In BackOff strategy * Fix gn dependency * Fix non CIP builds * Fix switch case and add test * Update zcl with extensions * Fix zap generation * Refactor ICDManager init to leverage a builder pattern * Fix non LIT test builds * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…#34482) * Add MaximunCheckInBackOff attribute to ICDM cluster * Add injectable ICD Check-In BackOff strategy * Fix gn dependency * Fix non CIP builds * Fix switch case and add test * Update zcl with extensions * Fix zap generation * Refactor ICDManager init to leverage a builder pattern * Fix non LIT test builds * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR implements the ICD Check-In BackOff strategy with the ICD server feature-set.
PR adds the framework to enable a platform to inject a strategy that will be leveraged by the ICDManager during server init.
Note to reviewers
The goal of this PR is just to setup the structure were a strategy can be injected. It provides very little help to implement a given strategy for now. Having trackers for missed Check-In messages and other tools will be added in a follow up PR.
Tests