Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AddressResolver] Add a check in shutdown to avoid some crashes if so… #35824

Merged
merged 2 commits into from
Sep 27, 2024
+4 −0
Merged

[AddressResolver] Add a check in shutdown to avoid some crashes if so… #35824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f75d42
[AddressResolver] Add a check in shutdown to avoid some crashes if so…
vivien-apple Sep 27, 2024
8e2ed1d
Apply suggestion from code review.
bzbarsky-apple Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Apply suggestion from code review. 
Co-authored-by: Andrei Litvin <andy314@gmail.com>
@bzbarsky-apple @andy31415
bzbarsky-apple and andy31415 authored Sep 27, 2024

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 8e2ed1dd7976ebe3b87d2d7dbebdf0ac0610f3e2
2 changes: 2 additions & 0 deletions src/lib/address_resolve/AddressResolve_DefaultImpl.cpp
View file
Original file line number Diff line number Diff line change
@@ -248,6 +248,8 @@ CHIP_ERROR Resolver::Init(System::Layer * systemLayer)

void Resolver::Shutdown()
{
// mSystemLayer is set in ::Init, so if it's null that means the resolver
// has not been initialized or has already been shut down.
VerifyOrReturn(mSystemLayer != nullptr);

while (mActiveLookups.begin() != mActiveLookups.end())