[Chef] Create a ContactSensor to support LIT ICD （Linux Only) #37123
+6,168
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ | |
| _CD_STAGING_DIR = os.path.join(_CHEF_SCRIPT_PATH, "staging") | ||
| _EXCLUDE_DEVICE_FROM_LINUX_CI = [ # These do not compile / deprecated. | ||
| "noip_rootnode_dimmablelight_bCwGYSDpoe", | ||
| "icd_rootnode_contactsensor_ed3b19ec55", | ||
| "rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680", | ||
| ] | ||
|
|
||
|
|
@@ -328,6 +329,8 @@ def main() -> int: | |
| action="store_true", dest="do_erase") | ||
| parser.add_option("-i", "--terminal", help="opens terminal to interact with with device", | ||
| action="store_true", dest="do_interact") | ||
| parser.add_option("-I", "--enable_lit_icd", help="enable LIT ICD (Long Idle Time Intermittently Connected Device) mode", | ||
| action="store_true", default=False) | ||
| parser.add_option("-m", "--menuconfig", help="runs menuconfig on platforms that support it", | ||
| action="store_true", dest="do_menuconfig") | ||
| parser.add_option("-z", "--zap", help="runs zap to generate data model & interaction model artifacts", | ||
|
|
@@ -894,6 +897,13 @@ def main() -> int: | |
| else: | ||
| linux_args.append("chip_inet_config_enable_ipv4=false") | ||
|
|
||
| if options.enable_lit_icd: | ||
| linux_args.append("chip_enable_icd_server = true") | ||
| linux_args.append("chip_subscription_timeout_resumption = true") | ||
| linux_args.append("chip_icd_report_on_active_mode = true") | ||
| linux_args.append("chip_enable_icd_lit = true") | ||
| linux_args.append("chip_enable_icd_dsls = true") | ||
|
There was a problem hiding this comment. Does the contact sensor implement this feature? There was a problem hiding this comment. The contact sensor is this current code under chef. There was a problem hiding this comment. @mkardous-silabs I think this feature There was a problem hiding this comment. The question is does the contact-sensor require this feature in the sense do we need to enable it? I don't think the current contact sensor implementation uses but i might be wrong. The feature can be enabled without it being actually used. You can ignore the comment. |
||
|
|
||
| if sw_ver_string: | ||
| linux_args.append( | ||
| f'chip_device_config_device_software_version_string = "{sw_ver_string}"') | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the persistent subscription feature enabled? It is a requirement for this feature.
As a side comment, this changes the behavior on when check-in messages are sent out based on wether we are retrying to re-subscribe or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkardous-silabs
chip_persist_subscriptionshasn't been enabled. Thanks for the reminder. May I know what is your suggestion?Actually I am not very familiar with these feature. So I'll leave this to @yunhanw-google to comment if we should enable both
chip_persist_subscriptionsandchip_subscription_timeout_resumption.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ICDmanager behavior adapts based on the presence of both feature. The combos are
chip_persist_subscriptionsandchip_subscription_timeout_resumptionchip_persist_subscriptionsand withoutchip_subscription_timeout_resumptionSubscription timeout cannot be present without chip_persist_subscriptions IIRC.
making these configurable might be valuable to enable most tests case.