Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the constraints component directly #3330

Open
wants to merge 1 commit into
base: release-8.x
Choose a base branch
from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Sep 23, 2024

Deprecate the catalog/_constraints.html.erb partial

jcoyne added a commit that referenced this pull request Sep 23, 2024
Just call the component instead.  The partial was deprecated in #3330
@jcoyne jcoyne added this to the 8.x milestone Sep 23, 2024
@jcoyne jcoyne changed the base branch from main to release-8.x September 23, 2024 15:58
@cbeer
Copy link
Member

cbeer commented Oct 23, 2024

I don't think this change would be backwards compatible (like #3333), right?

Deprecate the catalog/_constraints.html.erb partial
@jcoyne jcoyne force-pushed the deprecate-constraints-partial branch from d96fc77 to c469c0e Compare October 24, 2024 13:51
@jcoyne
Copy link
Member Author

jcoyne commented Oct 24, 2024

@cbeer is this better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants