process_collector: Add Platform-Specific Describe for processCollector #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
force-pushed
the
split-describe-by-platform
branch
from
bc2ac02 to
acd48a9
Compare
Signed-off-by: Ying WANG <ying.wang@grafana.com>
ying-jeanne
force-pushed
the
split-describe-by-platform
branch
from
acd48a9 to
1a1b860
Compare
Signed-off-by: Ying WANG <ying.wang@grafana.com>
bwplotka
approved these changes
Sep 16, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| * [ENHANCEMENT] process_collector: Add Platform-Specific Describe for processCollector. #1625 | |||
There was a problem hiding this comment.
Is it really a customer visible change? It might be mostly our tech-debt removal, right?
There was a problem hiding this comment.
removed in 0bfbc37
prometheus/process_collector.go
Outdated
| ch <- c.startTime | ||
| ch <- c.inBytes | ||
| ch <- c.outBytes | ||
| func (c *processCollector) defaultCollectFn(ch chan<- Metric) { |
There was a problem hiding this comment.
Should we name this and below something like errorCollectFn and errorDescribeFn given what they do?
There was a problem hiding this comment.
renamed in 0bfbc37
| @@ -20,7 +20,14 @@ func canCollectProcess() bool { | |||
| return false | |||
| } | |||
|
|
|||
| // describe returns all descriptions of the collector for js. | |||
There was a problem hiding this comment.
Nice! I'm not sure why we have files for js and wasip1 that explicitly say "false" in can collect function, but other potentially also non supported environments will go through _other file. Maybe we can find the source of the file/blame to see why it was added vs going through _other file flow 🤔
We can do in other PR
There was a problem hiding this comment.
I think this may caused by below function is not available in js and wasip1 PR, but I think you are still right, we can at least merge those 2 since they are exactly the same today. Just left them now as they are, let me know what do you think, I can open a follow PR.
func canCollectProcess() bool {
_, err := procfs.NewDefaultFS()
return err == nil
}
Signed-off-by: Ying WANG <ying.wang@grafana.com>
ying-jeanne
force-pushed
the
split-describe-by-platform
branch
from
de6aff8 to
0bfbc37
Compare
|
could you take another look at this PR @bwplotka @ArthurSens @kakkoyun? thank you. |
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
prometheus#1625) * process_collector: Add Platform-Specific Describe for processCollector Signed-off-by: Ying WANG <ying.wang@grafana.com> * add changelog entry Signed-off-by: Ying WANG <ying.wang@grafana.com> * Address comments Signed-off-by: Ying WANG <ying.wang@grafana.com> --------- Signed-off-by: Ying WANG <ying.wang@grafana.com> Signed-off-by: Eugene <eugene@amberpixels.io>
1 task
1 task
1 task
1 task
1 task
1 task
1 task
This was referenced Feb 19, 2025
Merged
Merged
1 task
1 task
This was referenced Mar 2, 2025
1 task
This was referenced Mar 2, 2025
Update module github.com/prometheus/client_golang to v1.21.0
project-koku/koku-metrics-operator#549
Open
This was referenced Mar 3, 2025
Open
Merged
This was referenced Mar 3, 2025
Merged
Open
renovate bot
added a commit
to anza-labs/kvm-device-plugin
that referenced
this pull request
Mar 5, 2025
….1 (#5) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `v1.19.1` -> `v1.21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.21.1`](https://github.com/prometheus/client_golang/releases/tag/v1.21.1): / 2025-03-04 [Compare Source](https://github.com/prometheus/client_golang/compare/v1.21.0...v1.21.1) This release addresses a major performance regression introduced in [#​1661](https://github.com/prometheus/client_golang/issues/1661) -- thanks to all who [reported this quickly](https://github.com/prometheus/client_golang/issues/1748): [@​chlunde](https://github.com/chlunde), [@​dethi](https://github.com/dethi), [@​aaronbee](https://github.com/aaronbee) [@​tsuna](https://github.com/tsuna) 💪🏽. This patch release also fixes the iOS build. We will be hardening the release process even further ([#​1759](https://github.com/prometheus/client_golang/issues/1759), [#​1761](https://github.com/prometheus/client_golang/issues/1761)) to prevent this in future, sorry for the inconvenience! The high concurrency optimization is planned to be eventually reintroduced, however in a much safer manner, potentially in a separate API. - \[BUGFIX] prometheus: Revert of `Inc`, `Add` and `Observe` cumulative metric CAS optimizations ([#​1661](https://github.com/prometheus/client_golang/issues/1661)), causing regressions on low concurrency cases [#​1757](https://github.com/prometheus/client_golang/issues/1757) - \[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_\* wrong build tags. [#​1758](https://github.com/prometheus/client_golang/issues/1758) <details> <summary>All commits</summary> - Revert "exponential backoff for CAS operations on floats" and cut 1.21.1 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1757](https://github.com/prometheus/client_golang/pull/1757) - Fix ios build for 1.21.1 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1758](https://github.com/prometheus/client_golang/pull/1758) </details> **Full Changelog**: prometheus/client_golang@v1.21.0...v1.21.1 ### [`v1.21.0`](https://github.com/prometheus/client_golang/releases/tag/v1.21.0): / 2025-02-19 [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.5...v1.21.0) :warning: This release contains potential breaking change if you upgrade `github.com/prometheus/common` to 0.62+ together with client_golang (and depend on the strict, legacy validation for the label names). New common version [changes `model.NameValidationScheme` global variable](https://github.com/prometheus/common/pull/724), which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change `model.NameValidationScheme` to old `model.LegacyValidation` value in your project `init` function. :warning: - \[BUGFIX] gocollector: Fix help message for runtime/metric metrics. [#​1583](https://github.com/prometheus/client_golang/issues/1583) - \[BUGFIX] prometheus: Fix `Desc.String()` method for no labels case. [#​1687](https://github.com/prometheus/client_golang/issues/1687) - \[PERF] prometheus: Optimize popular `prometheus.BuildFQName` function; now up to 30% faster. [#​1665](https://github.com/prometheus/client_golang/issues/1665) - \[PERF] prometheus: Optimize `Inc`, `Add` and `Observe` cumulative metrics; now up to 50% faster under high concurrent contention. [#​1661](https://github.com/prometheus/client_golang/issues/1661) - \[CHANGE] Upgrade prometheus/common to 0.62.0 which changes `model.NameValidationScheme` global variable. [#​1712](https://github.com/prometheus/client_golang/issues/1712) - \[CHANGE] Add support for Go 1.23. [#​1602](https://github.com/prometheus/client_golang/issues/1602) - \[FEATURE] process_collector: Add support for Darwin systems. [#​1600](https://github.com/prometheus/client_golang/issues/1600) [#​1616](https://github.com/prometheus/client_golang/issues/1616) [#​1625](https://github.com/prometheus/client_golang/issues/1625) [#​1675](https://github.com/prometheus/client_golang/issues/1675) [#​1715](https://github.com/prometheus/client_golang/issues/1715) - \[FEATURE] api: Add ability to invoke `CloseIdleConnections` on api.Client using `api.Client.(CloseIdler).CloseIdleConnections()` casting. [#​1513](https://github.com/prometheus/client_golang/issues/1513) - \[FEATURE] promhttp: Add `promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples` option to create OpenMetrics \_created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). [#​1408](https://github.com/prometheus/client_golang/issues/1408) - \[FEATURE] prometheus: Add `NewConstNativeHistogram` function. [#​1654](https://github.com/prometheus/client_golang/issues/1654) <details> <summary> All commits </summary> * Merge release-1.20 to main by @​bwplotka in prometheus/client_golang#1582 * gocollector: Tiny fix for help message with runtime/metrics source. by @​bwplotka in prometheus/client_golang#1583 * ci: bump dagger to the latest version by @​marcosnils in prometheus/client_golang#1588 * Merge release-1.20 back to main by @​ArthurSens in prometheus/client_golang#1593 * Update linting by @​SuperQ in prometheus/client_golang#1603 * Update supported Go versions by @​SuperQ in prometheus/client_golang#1602 * build(deps): bump golang.org/x/sys from 0.22.0 to 0.24.0 by @​dependabot in prometheus/client_golang#1611 * build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 by @​dependabot in prometheus/client_golang#1612 * changed the name of all variables with min/max name by @​parthlaw in prometheus/client_golang#1606 * Update Dagger and build. by @​SuperQ in prometheus/client_golang#1610 * build(deps): bump github/codeql-action from 3.25.15 to 3.26.6 in the github-actions group across 1 directory by @​dependabot in prometheus/client_golang#1614 * examples: Improved GoCollector example. by @​bwplotka in prometheus/client_golang#1589 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1615 * process_collector: fill in most statistics on macOS by @​mharbison72 in prometheus/client_golang#1600 * ⚡ http client defer CloseIdleConnections by @​cuisongliu in prometheus/client_golang#1513 * Set allow-utf-8 in Format during tests to avoid escaping. by @​ywwg in prometheus/client_golang#1618 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1622 * Merge Release 1.20 back to main by @​ArthurSens in prometheus/client_golang#1627 * examples: Add custom labels example by @​ying-jeanne in prometheus/client_golang#1626 * Refactor default runtime metrics tests for Go collector so that default runtime metric set autogenerates by @​vesari in prometheus/client_golang#1631 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1628 * process_xxx_memory statistics for macOS (cgo) by @​mharbison72 in prometheus/client_golang#1616 * build(deps): bump github.com/klauspost/compress from 1.17.9 to 1.17.10 by @​dependabot in prometheus/client_golang#1633 * build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 by @​dependabot in prometheus/client_golang#1632 * process_collector: Add Platform-Specific Describe for processCollector by @​ying-jeanne in prometheus/client_golang#1625 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1635 * build(deps): bump the github-actions group with 4 updates by @​dependabot in prometheus/client_golang#1634 * Optionally print OM created lines by @​ArthurSens in prometheus/client_golang#1408 * process_collector: merge wasip1 and js into a single implementation by @​ying-jeanne in prometheus/client_golang#1644 * Merge release 1.20 to main by @​bwplotka in prometheus/client_golang#1647 * Add Arianna as maintainer 💪 by @​ArthurSens in prometheus/client_golang#1651 * test add headers round tripper by @​Manask322 in prometheus/client_golang#1657 * build(deps): bump github.com/klauspost/compress from 1.17.10 to 1.17.11 by @​dependabot in prometheus/client_golang#1668 * build(deps): bump golang.org/x/sys from 0.25.0 to 0.26.0 by @​dependabot in prometheus/client_golang#1669 * build(deps): bump github.com/prometheus/common from 0.59.1 to 0.60.1 by @​dependabot in prometheus/client_golang#1667 * build(deps): bump google.golang.org/protobuf from 1.34.2 to 1.35.1 by @​dependabot in prometheus/client_golang#1670 * Optimize BuildFQName function by @​jkroepke in prometheus/client_golang#1665 * fix: use injected now() instead of time.Now() in summary methods by @​imorph in prometheus/client_golang#1672 * process_collector: avoid a compiler warning on macOS (fixes #​1660) by @​mharbison72 in prometheus/client_golang#1675 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1674 * build(deps): bump the github-actions group across 1 directory with 3 updates by @​dependabot in prometheus/client_golang#1678 * [chore]: enable perfsprint linter by @​mmorel-35 in prometheus/client_golang#1676 * Duplicate of #​1662 by @​imorph in prometheus/client_golang#1673 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1679 * chore: enable usestdlibvars linter by @​mmorel-35 in prometheus/client_golang#1680 * Add: exponential backoff for CAS operations on floats by @​imorph in prometheus/client_golang#1661 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1683 * [1617] Add ConstnativeHistogram by @​shivanthzen in prometheus/client_golang#1654 * fix: replace fmt.Errorf with errors.New by @​kakkoyun in prometheus/client_golang#1689 * Add codeowners by @​kakkoyun in prometheus/client_golang#1688 * fix: add very small delay between observations in `TestHistogramAtomicObserve` by @​imorph in prometheus/client_golang#1691 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1692 * Fix: handle nil variableLabels in Desc.String() method and add tests for nil label values by @​kakkoyun in prometheus/client_golang#1687 * examples: Follow best practices and established naming conventions by @​lilic in prometheus/client_golang#1650 * setup OSSF Scorecard workflow by @​mmorel-35 in prometheus/client_golang#1432 * build(deps): bump google.golang.org/protobuf from 1.35.1 to 1.35.2 by @​dependabot in prometheus/client_golang#1697 * build(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 by @​dependabot in prometheus/client_golang#1696 * build(deps): bump the github-actions group with 5 updates by @​dependabot in prometheus/client_golang#1695 * update links to openmetrics to reference the v1.0.0 release by @​dashpole in prometheus/client_golang#1699 * build(deps): bump google.golang.org/protobuf from 1.35.2 to 1.36.1 by @​dependabot in prometheus/client_golang#1706 * build(deps): bump golang.org/x/sys from 0.27.0 to 0.28.0 by @​dependabot in prometheus/client_golang#1705 * build(deps): bump the github-actions group with 5 updates by @​dependabot in prometheus/client_golang#1707 * build(deps): bump github.com/prometheus/common from 0.60.1 to 0.61.0 by @​dependabot in prometheus/client_golang#1704 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1703 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1708 * Upgrade to prometheus/common 0.62.0 with breaking change by @​bwplotka in prometheus/client_golang#1712 * build(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 in /tutorials/whatsup by @​dependabot in prometheus/client_golang#1713 * docs: Add RELEASE.md for the release process by @​kakkoyun in prometheus/client_golang#1690 * tutorials/whatsup: Updated deps by @​bwplotka in prometheus/client_golang#1716 * process collector: Fixed pedantic registry failures on darwin with cgo. by @​bwplotka in prometheus/client_golang#1715 * Revert "ci: daggerize test and lint pipelines (#​1534)" by @​bwplotka in prometheus/client_golang#1717 * Cut 1.21.0-rc.0 by @​bwplotka in prometheus/client_golang#1718 * Cut 1.21 by @​bwplotka in prometheus/client_golang#1737 </details> #### New Contributors * @​parthlaw made their first contributi[https://github.com/prometheus/client_golang/pull/1606](https://github.com/prometheus/client_golang/pull/1606)l/1606 * @​mharbison72 made their first contributi[https://github.com/prometheus/client_golang/pull/1600](https://github.com/prometheus/client_golang/pull/1600)l/1600 * @​cuisongliu made their first contributi[https://github.com/prometheus/client_golang/pull/1513](https://github.com/prometheus/client_golang/pull/1513)l/1513 * @​ying-jeanne made their first contributi[https://github.com/prometheus/client_golang/pull/1626](https://github.com/prometheus/client_golang/pull/1626)l/1626 * @​Manask322 made their first contributi[https://github.com/prometheus/client_golang/pull/1657](https://github.com/prometheus/client_golang/pull/1657)l/1657 * @​jkroepke made their first contributi[https://github.com/prometheus/client_golang/pull/1665](https://github.com/prometheus/client_golang/pull/1665)l/1665 * @​imorph made their first contributi[https://github.com/prometheus/client_golang/pull/1672](https://github.com/prometheus/client_golang/pull/1672)l/1672 * @​mmorel-35 made their first contributi[https://github.com/prometheus/client_golang/pull/1676](https://github.com/prometheus/client_golang/pull/1676)l/1676 * @​shivanthzen made their first contributi[https://github.com/prometheus/client_golang/pull/1654](https://github.com/prometheus/client_golang/pull/1654)l/1654 * @​dashpole made their first contributi[https://github.com/prometheus/client_golang/pull/1699](https://github.com/prometheus/client_golang/pull/1699)l/1699 **Full Changelog**: prometheus/client_golang@v1.20.5...v1.21.0 ### [`v1.20.5`](https://github.com/prometheus/client_golang/releases/tag/v1.20.5): / 2024-10-15 [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.4...v1.20.5) We decided to revert [the `testutil` change](https://github.com/prometheus/client_golang/pull/1424) that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the [exact error message](https://github.com/grafana/mimir/pull/9624#issuecomment-2413401565). Going forward, we plan to reinforce our release testing strategy [\[1\]](https://github.com/prometheus/client_golang/issues/1646),[\[2\]](https://github.com/prometheus/client_golang/issues/1648) and deliver an enhanced [`testutil` package/module](https://github.com/prometheus/client_golang/issues/1639) with more flexible and safer APIs. Thanks to [@​dashpole](https://github.com/dashpole) [@​dgrisonnet](https://github.com/dgrisonnet) [@​kakkoyun](https://github.com/kakkoyun) [@​ArthurSens](https://github.com/ArthurSens) [@​vesari](https://github.com/vesari) [@​logicalhan](https://github.com/logicalhan) [@​krajorama](https://github.com/krajorama) [@​bwplotka](https://github.com/bwplotka) who helped in this patch release! 🤗 ##### Changelog \[BUGFIX] testutil: Reverted [#​1424](https://github.com/prometheus/client_golang/issues/1424); functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. [#​1645](https://github.com/prometheus/client_golang/issues/1645) ### [`v1.20.4`](https://github.com/prometheus/client_golang/releases/tag/v1.20.4) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.3...v1.20.4) - \[BUGFIX] histograms: Fix a possible data race when appending exemplars vs metrics gather. [#​1623](https://github.com/prometheus/client_golang/issues/1623) ### [`v1.20.3`](https://github.com/prometheus/client_golang/releases/tag/v1.20.3) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.2...v1.20.3) - \[BUGFIX] histograms: Fix possible data race when appending exemplars. [#​1608](https://github.com/prometheus/client_golang/issues/1608) ### [`v1.20.2`](https://github.com/prometheus/client_golang/releases/tag/v1.20.2) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.1...v1.20.2) - \[BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. [#​1596](https://github.com/prometheus/client_golang/issues/1596) ### [`v1.20.1`](https://github.com/prometheus/client_golang/releases/tag/v1.20.1) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.0...v1.20.1) This release contains the critical fix for the [issue](https://github.com/prometheus/client_golang/issues/1584). Thanks to [@​geberl](https://github.com/geberl), [@​CubicrootXYZ](https://github.com/CubicrootXYZ), [@​zetaab](https://github.com/zetaab) and [@​timofurrer](https://github.com/timofurrer) for helping us with the investigation! - \[BUGFIX] process-collector: Fixed unregistered descriptor error when using process collector with PedanticRegistry on Linux machines. [#​1587](https://github.com/prometheus/client_golang/issues/1587) ### [`v1.20.0`](https://github.com/prometheus/client_golang/releases/tag/v1.20.0) [Compare Source](https://github.com/prometheus/client_golang/compare/v1.19.1...v1.20.0) Thanks everyone for contributions! :warning: In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default `collectors.NewGoCollector()` collector. Given its popular usage, expect your binary to expose two additional metric. #### Changes - \[CHANGE] :warning: go-collector: Remove `go_memstat_lookups_total` metric which was always 0; Go runtime stopped sharing pointer lookup statistics. [#​1577](https://github.com/prometheus/client_golang/issues/1577) - \[FEATURE]⚠️ go-collector: Add 3 default metrics: `go_gc_gogc_percent`, `go_gc_gomemlimit_bytes` and `go_sched_gomaxprocs_threads` as those are recommended by the Go team. [#​1559](https://github.com/prometheus/client_golang/issues/1559) - \[FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact `runtime/metrics` sourcing each metric (if relevant). [#​1568](https://github.com/prometheus/client_golang/issues/1568) [#​1578](https://github.com/prometheus/client_golang/issues/1578) - \[FEATURE] testutil: Add CollectAndFormat method. [#​1503](https://github.com/prometheus/client_golang/issues/1503) - \[FEATURE] histograms: Add support for exemplars in native histograms. [#​1471](https://github.com/prometheus/client_golang/issues/1471) - \[FEATURE] promhttp: Add experimental support for `zstd` on scrape, controlled by the request `Accept-Encoding` header. [#​1496](https://github.com/prometheus/client_golang/issues/1496) - \[FEATURE] api/v1: Add `WithLimit` parameter to all API methods that supports it. [#​1544](https://github.com/prometheus/client_golang/issues/1544) - \[FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. [#​1537](https://github.com/prometheus/client_golang/issues/1537) - \[FEATURE] process-collectors: Add network usage metrics: `process_network_receive_bytes_total` and `process_network_transmit_bytes_total`. [#​1555](https://github.com/prometheus/client_golang/issues/1555) - \[FEATURE] promlint: Add duplicated metric lint rule. [#​1472](https://github.com/prometheus/client_golang/issues/1472) - \[BUGFIX] promlint: Relax metric type in name linter rule. [#​1455](https://github.com/prometheus/client_golang/issues/1455) - \[BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. [#​1480](https://github.com/prometheus/client_golang/issues/1480) - \[BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. [#​1424](https://github.com/prometheus/client_golang/issues/1424) <details> <summary>All commits</summary> - feat(prometheus/testutil/promlint/validations): refine lintMetricType… by [@​foehammer127](https://github.com/foehammer127) in [https://github.com/prometheus/client_golang/pull/1455](https://github.com/prometheus/client_golang/pull/1455) - Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 in /examples/middleware by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1457](https://github.com/prometheus/client_golang/pull/1457) - Bump github.com/prometheus/client_model from 0.5.0 to 0.6.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1458](https://github.com/prometheus/client_golang/pull/1458) - Bump golang.org/x/sys from 0.16.0 to 0.17.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1459](https://github.com/prometheus/client_golang/pull/1459) - Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1461](https://github.com/prometheus/client_golang/pull/1461) - Merge Release 1.19 back to main by [@​ArthurSens](https://github.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1462](https://github.com/prometheus/client_golang/pull/1462) - Bump the github-actions group with 2 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1456](https://github.com/prometheus/client_golang/pull/1456) - Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1466](https://github.com/prometheus/client_golang/pull/1466) - Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 in /examples/middleware by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1467](https://github.com/prometheus/client_golang/pull/1467) - Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1469](https://github.com/prometheus/client_golang/pull/1469) - Add LintDuplicateMetric to promlint by [@​bboreham](https://github.com/bboreham) in [https://github.com/prometheus/client_golang/pull/1472](https://github.com/prometheus/client_golang/pull/1472) - Auto-update Go Collector Metrics for new Go versions by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1476](https://github.com/prometheus/client_golang/pull/1476) - Implement Unwrap() for responseWriterDelegator by [@​igor-drozdov](https://github.com/igor-drozdov) in [https://github.com/prometheus/client_golang/pull/1480](https://github.com/prometheus/client_golang/pull/1480) - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1485](https://github.com/prometheus/client_golang/pull/1485) - Bump github.com/prometheus/procfs from 0.12.0 to 0.13.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1486](https://github.com/prometheus/client_golang/pull/1486) - ci: Remove hardcoded supported Go versions from go.yml by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1489](https://github.com/prometheus/client_golang/pull/1489) - feat: metrics generation workflow by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1481](https://github.com/prometheus/client_golang/pull/1481) - fix: remove redundant go module in middleware example by [@​majolo](https://github.com/majolo) in [https://github.com/prometheus/client_golang/pull/1492](https://github.com/prometheus/client_golang/pull/1492) - chore: Refactor how base metrics are added to Sched metrics by [@​ArthurSens](https://github.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1483](https://github.com/prometheus/client_golang/pull/1483) - gocollector: Add regex option to allow collection of debug runtime metrics by [@​ArthurSens](https://github.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1389](https://github.com/prometheus/client_golang/pull/1389) - Bump github.com/prometheus/common from 0.48.0 to 0.52.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1498](https://github.com/prometheus/client_golang/pull/1498) - chore: fix function name in comment by [@​oftenoccur](https://github.com/oftenoccur) in [https://github.com/prometheus/client_golang/pull/1497](https://github.com/prometheus/client_golang/pull/1497) - build(deps): bump golang.org/x/net from 0.20.0 to 0.23.0 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1501](https://github.com/prometheus/client_golang/pull/1501) - build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1502](https://github.com/prometheus/client_golang/pull/1502) - feat(dependency): replace go-spew package by [@​dongjiang1989](https://github.com/dongjiang1989) in [https://github.com/prometheus/client_golang/pull/1499](https://github.com/prometheus/client_golang/pull/1499) - build(deps): bump github.com/prometheus/common from 0.52.3 to 0.53.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1504](https://github.com/prometheus/client_golang/pull/1504) - build(deps): bump github.com/cespare/xxhash/v2 from 2.2.0 to 2.3.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1505](https://github.com/prometheus/client_golang/pull/1505) - build(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1506](https://github.com/prometheus/client_golang/pull/1506) - build(deps): bump golang.org/x/sys from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1507](https://github.com/prometheus/client_golang/pull/1507) - build(deps): bump github.com/prometheus/client_model from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1508](https://github.com/prometheus/client_golang/pull/1508) - build(deps): bump github.com/prometheus/common from 0.48.0 to 0.53.0 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1509](https://github.com/prometheus/client_golang/pull/1509) - improved code more clean by [@​lilijreey](https://github.com/lilijreey) in [https://github.com/prometheus/client_golang/pull/1511](https://github.com/prometheus/client_golang/pull/1511) - build(deps): bump the github-actions group with 3 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1510](https://github.com/prometheus/client_golang/pull/1510) - \[CI]: Add Concurrency Grouping to GitHub Workflows by [@​Ishani217](https://github.com/Ishani217) in [https://github.com/prometheus/client_golang/pull/1444](https://github.com/prometheus/client_golang/pull/1444) - Add CollectAndFormat to testutil, allowing caller to assert as they want to on the exported metric by [@​jcass8695](https://github.com/jcass8695) in [https://github.com/prometheus/client_golang/pull/1503](https://github.com/prometheus/client_golang/pull/1503) - testutil compareMetricFamilies: make less error-prone by [@​leonnicolas](https://github.com/leonnicolas) in [https://github.com/prometheus/client_golang/pull/1424](https://github.com/prometheus/client_golang/pull/1424) - improved code more clean use time.IsZero() replace t = time.Time{} by [@​lilijreey](https://github.com/lilijreey) in [https://github.com/prometheus/client_golang/pull/1515](https://github.com/prometheus/client_golang/pull/1515) - add native histogram exemplar support by [@​fatsheep9146](https://github.com/fatsheep9146) in [https://github.com/prometheus/client_golang/pull/1471](https://github.com/prometheus/client_golang/pull/1471) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1514](https://github.com/prometheus/client_golang/pull/1514) - build(deps): bump golang.org/x/sys from 0.19.0 to 0.20.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1523](https://github.com/prometheus/client_golang/pull/1523) - build(deps): bump google.golang.org/protobuf from 1.34.0 to 1.34.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1522](https://github.com/prometheus/client_golang/pull/1522) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1524](https://github.com/prometheus/client_golang/pull/1524) - Add PR template for changelog automation by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1517](https://github.com/prometheus/client_golang/pull/1517) - Auto label PRs by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1518](https://github.com/prometheus/client_golang/pull/1518) - Fix: Auto label PRs [#​1518](https://github.com/prometheus/client_golang/issues/1518) by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1525](https://github.com/prometheus/client_golang/pull/1525) - build(deps): bump github.com/prometheus/procfs from 0.13.0 to 0.15.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1527](https://github.com/prometheus/client_golang/pull/1527) - ci: Group all changelog-related CI jobs into single one by [@​ArthurSens](https://github.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1526](https://github.com/prometheus/client_golang/pull/1526) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1530](https://github.com/prometheus/client_golang/pull/1530) - Remove synchronize trigger from changelog workflow by [@​SachinSahu431](https://github.com/SachinSahu431) in [https://github.com/prometheus/client_golang/pull/1532](https://github.com/prometheus/client_golang/pull/1532) - feat: Support zstd compression by [@​mrueg](https://github.com/mrueg) in [https://github.com/prometheus/client_golang/pull/1496](https://github.com/prometheus/client_golang/pull/1496) - Fix golangci-lint config by [@​SuperQ](https://github.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1536](https://github.com/prometheus/client_golang/pull/1536) - build(deps): bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1529](https://github.com/prometheus/client_golang/pull/1529) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1531](https://github.com/prometheus/client_golang/pull/1531) - Cleanup NOTICE file by [@​SuperQ](https://github.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1541](https://github.com/prometheus/client_golang/pull/1541) - Remove inlined upstream code by [@​SuperQ](https://github.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1539](https://github.com/prometheus/client_golang/pull/1539) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1545](https://github.com/prometheus/client_golang/pull/1545) - client: Add Option to provide limit query param for APIs that support it by [@​abbyssoul](https://github.com/abbyssoul) in [https://github.com/prometheus/client_golang/pull/1544](https://github.com/prometheus/client_golang/pull/1544) - Allow creating constant histogram and summary metrics with a created timestamp by [@​swar8080](https://github.com/swar8080) in [https://github.com/prometheus/client_golang/pull/1537](https://github.com/prometheus/client_golang/pull/1537) - Update README.md by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1556](https://github.com/prometheus/client_golang/pull/1556) - Temporarily remove required CI job for changelog. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1560](https://github.com/prometheus/client_golang/pull/1560) - build(deps): bump github.com/prometheus/common from 0.53.0 to 0.55.0 in /tutorial/whatsup by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1549](https://github.com/prometheus/client_golang/pull/1549) - build(deps): bump golang.org/x/sys from 0.20.0 to 0.21.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1552](https://github.com/prometheus/client_golang/pull/1552) - build(deps): bump github.com/klauspost/compress from 1.17.8 to 1.17.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1553](https://github.com/prometheus/client_golang/pull/1553) - fix: Update Go tests by [@​SuperQ](https://github.com/SuperQ) in [https://github.com/prometheus/client_golang/pull/1562](https://github.com/prometheus/client_golang/pull/1562) - process_collector: collect received/transmitted bytes by [@​huwcbjones](https://github.com/huwcbjones) in [https://github.com/prometheus/client_golang/pull/1555](https://github.com/prometheus/client_golang/pull/1555) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1561](https://github.com/prometheus/client_golang/pull/1561) - chore: Remove half-implemented changelog automation by [@​ArthurSens](https://github.com/ArthurSens) in [https://github.com/prometheus/client_golang/pull/1564](https://github.com/prometheus/client_golang/pull/1564) - build(deps): bump the github-actions group across 1 directory with 3 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1565](https://github.com/prometheus/client_golang/pull/1565) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1563](https://github.com/prometheus/client_golang/pull/1563) - build(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1551](https://github.com/prometheus/client_golang/pull/1551) - deps: Updated to prometheus/common to 0.55 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1566](https://github.com/prometheus/client_golang/pull/1566) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1567](https://github.com/prometheus/client_golang/pull/1567) - tutorials: Renamed tutorial -> tutorials for consistency + fixed tutorial code. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1569](https://github.com/prometheus/client_golang/pull/1569) - go collector: add default metrics acceptance tests; adding more context to HELP by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1568](https://github.com/prometheus/client_golang/pull/1568) - build(deps): bump golang.org/x/sys from 0.21.0 to 0.22.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1570](https://github.com/prometheus/client_golang/pull/1570) - build(deps): bump the github-actions group with 3 updates by [@​dependabot](https://github.com/dependabot) in [https://github.com/prometheus/client_golang/pull/1571](https://github.com/prometheus/client_golang/pull/1571) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1572](https://github.com/prometheus/client_golang/pull/1572) - ci: daggerize test and lint pipelines by [@​marcosnils](https://github.com/marcosnils) in [https://github.com/prometheus/client_golang/pull/1534](https://github.com/prometheus/client_golang/pull/1534) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1573](https://github.com/prometheus/client_golang/pull/1573) - Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /sched/gomaxprocs:threads by [@​vesari](https://github.com/vesari) in [https://github.com/prometheus/client_golang/pull/1559](https://github.com/prometheus/client_golang/pull/1559) - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [https://github.com/prometheus/client_golang/pull/1576](https://github.com/prometheus/client_golang/pull/1576) - Remove go_memstat_lookups_total; added runtime/metrics calculation to memstat metric's help. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1577](https://github.com/prometheus/client_golang/pull/1577) - gocollector: Attach original runtime/metrics metric name to help. by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1578](https://github.com/prometheus/client_golang/pull/1578) </details> #### New Contributors * @​foehammer127 made their first contributi[https://github.com/prometheus/client_golang/pull/1455](https://github.com/prometheus/client_golang/pull/1455)l/1455 * @​SachinSahu431 made their first contributi[https://github.com/prometheus/client_golang/pull/1476](https://github.com/prometheus/client_golang/pull/1476)l/1476 * @​igor-drozdov made their first contributi[https://github.com/prometheus/client_golang/pull/1480](https://github.com/prometheus/client_golang/pull/1480)l/1480 * @​majolo made their first contributi[https://github.com/prometheus/client_golang/pull/1492](https://github.com/prometheus/client_golang/pull/1492)l/1492 * @​oftenoccur made their first contributi[https://github.com/prometheus/client_golang/pull/1497](https://github.com/prometheus/client_golang/pull/1497)l/1497 * @​dongjiang1989 made their first contributi[https://github.com/prometheus/client_golang/pull/1499](https://github.com/prometheus/client_golang/pull/1499)l/1499 * @​lilijreey made their first contributi[https://github.com/prometheus/client_golang/pull/1511](https://github.com/prometheus/client_golang/pull/1511)l/1511 * @​Ishani217 made their first contributi[https://github.com/prometheus/client_golang/pull/1444](https://github.com/prometheus/client_golang/pull/1444)l/1444 * @​jcass8695 made their first contributi[https://github.com/prometheus/client_golang/pull/1503](https://github.com/prometheus/client_golang/pull/1503)l/1503 * @​leonnicolas made their first contributi[https://github.com/prometheus/client_golang/pull/1424](https://github.com/prometheus/client_golang/pull/1424)l/1424 * @​fatsheep9146 made their first contributi[https://github.com/prometheus/client_golang/pull/1471](https://github.com/prometheus/client_golang/pull/1471)l/1471 * @​abbyssoul made their first contributi[https://github.com/prometheus/client_golang/pull/1544](https://github.com/prometheus/client_golang/pull/1544)l/1544 * @​swar8080 made their first contributi[https://github.com/prometheus/client_golang/pull/1537](https://github.com/prometheus/client_golang/pull/1537)l/1537 * @​huwcbjones made their first contributi[https://github.com/prometheus/client_golang/pull/1555](https://github.com/prometheus/client_golang/pull/1555)l/1555 * @​marcosnils made their first contributi[https://github.com/prometheus/client_golang/pull/1534](https://github.com/prometheus/client_golang/pull/1534)l/1534 * @​vesari made their first contributi[https://github.com/prometheus/client_golang/pull/1559](https://github.com/prometheus/client_golang/pull/1559)l/1559 **Full Changelog**: prometheus/client_golang@v1.19.1...v1.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/anza-labs/kvm-device-plugin). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODUuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4NS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
atoulme
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 6, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `v1.20.5` -> `v1.21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.21.1`](https://github.com/prometheus/client_golang/releases/tag/v1.21.1): / 2025-03-04 [Compare Source](https://github.com/prometheus/client_golang/compare/v1.21.0...v1.21.1) This release addresses a major performance regression introduced in [#​1661](https://github.com/prometheus/client_golang/issues/1661) -- thanks to all who [reported this quickly](https://github.com/prometheus/client_golang/issues/1748): [@​chlunde](https://github.com/chlunde), [@​dethi](https://github.com/dethi), [@​aaronbee](https://github.com/aaronbee) [@​tsuna](https://github.com/tsuna) 💪🏽. This patch release also fixes the iOS build. We will be hardening the release process even further ([#​1759](https://github.com/prometheus/client_golang/issues/1759), [#​1761](https://github.com/prometheus/client_golang/issues/1761)) to prevent this in future, sorry for the inconvenience! The high concurrency optimization is planned to be eventually reintroduced, however in a much safer manner, potentially in a separate API. - \[BUGFIX] prometheus: Revert of `Inc`, `Add` and `Observe` cumulative metric CAS optimizations ([#​1661](https://github.com/prometheus/client_golang/issues/1661)), causing regressions on low concurrency cases [#​1757](https://github.com/prometheus/client_golang/issues/1757) - \[BUGFIX] prometheus: Fix GOOS=ios build, broken due to process_collector_\* wrong build tags. [#​1758](https://github.com/prometheus/client_golang/issues/1758) <details> <summary>All commits</summary> - Revert "exponential backoff for CAS operations on floats" and cut 1.21.1 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1757](https://github.com/prometheus/client_golang/pull/1757) - Fix ios build for 1.21.1 by [@​bwplotka](https://github.com/bwplotka) in [https://github.com/prometheus/client_golang/pull/1758](https://github.com/prometheus/client_golang/pull/1758) </details> **Full Changelog**: prometheus/client_golang@v1.21.0...v1.21.1 ### [`v1.21.0`](https://github.com/prometheus/client_golang/releases/tag/v1.21.0): / 2025-02-19 [Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.5...v1.21.0) :warning: This release contains potential breaking change if you upgrade `github.com/prometheus/common` to 0.62+ together with client_golang (and depend on the strict, legacy validation for the label names). New common version [changes `model.NameValidationScheme` global variable](https://github.com/prometheus/common/pull/724), which relaxes the validation of label names and metric name, allowing all UTF-8 characters. Typically, this should not break any user, unless your test or usage expects strict certain names to panic/fail on client_golang metric registration, gathering or scrape. In case of problems change `model.NameValidationScheme` to old `model.LegacyValidation` value in your project `init` function. :warning: - \[BUGFIX] gocollector: Fix help message for runtime/metric metrics. [#​1583](https://github.com/prometheus/client_golang/issues/1583) - \[BUGFIX] prometheus: Fix `Desc.String()` method for no labels case. [#​1687](https://github.com/prometheus/client_golang/issues/1687) - \[PERF] prometheus: Optimize popular `prometheus.BuildFQName` function; now up to 30% faster. [#​1665](https://github.com/prometheus/client_golang/issues/1665) - \[PERF] prometheus: Optimize `Inc`, `Add` and `Observe` cumulative metrics; now up to 50% faster under high concurrent contention. [#​1661](https://github.com/prometheus/client_golang/issues/1661) - \[CHANGE] Upgrade prometheus/common to 0.62.0 which changes `model.NameValidationScheme` global variable. [#​1712](https://github.com/prometheus/client_golang/issues/1712) - \[CHANGE] Add support for Go 1.23. [#​1602](https://github.com/prometheus/client_golang/issues/1602) - \[FEATURE] process_collector: Add support for Darwin systems. [#​1600](https://github.com/prometheus/client_golang/issues/1600) [#​1616](https://github.com/prometheus/client_golang/issues/1616) [#​1625](https://github.com/prometheus/client_golang/issues/1625) [#​1675](https://github.com/prometheus/client_golang/issues/1675) [#​1715](https://github.com/prometheus/client_golang/issues/1715) - \[FEATURE] api: Add ability to invoke `CloseIdleConnections` on api.Client using `api.Client.(CloseIdler).CloseIdleConnections()` casting. [#​1513](https://github.com/prometheus/client_golang/issues/1513) - \[FEATURE] promhttp: Add `promhttp.HandlerOpts.EnableOpenMetricsTextCreatedSamples` option to create OpenMetrics \_created lines. Not recommended unless you want to use opt-in Created Timestamp feature. Community works on OpenMetrics 2.0 format that should make those lines obsolete (they increase cardinality significantly). [#​1408](https://github.com/prometheus/client_golang/issues/1408) - \[FEATURE] prometheus: Add `NewConstNativeHistogram` function. [#​1654](https://github.com/prometheus/client_golang/issues/1654) <details> <summary> All commits </summary> * Merge release-1.20 to main by @​bwplotka in prometheus/client_golang#1582 * gocollector: Tiny fix for help message with runtime/metrics source. by @​bwplotka in prometheus/client_golang#1583 * ci: bump dagger to the latest version by @​marcosnils in prometheus/client_golang#1588 * Merge release-1.20 back to main by @​ArthurSens in prometheus/client_golang#1593 * Update linting by @​SuperQ in prometheus/client_golang#1603 * Update supported Go versions by @​SuperQ in prometheus/client_golang#1602 * build(deps): bump golang.org/x/sys from 0.22.0 to 0.24.0 by @​dependabot in prometheus/client_golang#1611 * build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 by @​dependabot in prometheus/client_golang#1612 * changed the name of all variables with min/max name by @​parthlaw in prometheus/client_golang#1606 * Update Dagger and build. by @​SuperQ in prometheus/client_golang#1610 * build(deps): bump github/codeql-action from 3.25.15 to 3.26.6 in the github-actions group across 1 directory by @​dependabot in prometheus/client_golang#1614 * examples: Improved GoCollector example. by @​bwplotka in prometheus/client_golang#1589 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1615 * process_collector: fill in most statistics on macOS by @​mharbison72 in prometheus/client_golang#1600 * ⚡ http client defer CloseIdleConnections by @​cuisongliu in prometheus/client_golang#1513 * Set allow-utf-8 in Format during tests to avoid escaping. by @​ywwg in prometheus/client_golang#1618 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1622 * Merge Release 1.20 back to main by @​ArthurSens in prometheus/client_golang#1627 * examples: Add custom labels example by @​ying-jeanne in prometheus/client_golang#1626 * Refactor default runtime metrics tests for Go collector so that default runtime metric set autogenerates by @​vesari in prometheus/client_golang#1631 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1628 * process_xxx_memory statistics for macOS (cgo) by @​mharbison72 in prometheus/client_golang#1616 * build(deps): bump github.com/klauspost/compress from 1.17.9 to 1.17.10 by @​dependabot in prometheus/client_golang#1633 * build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 by @​dependabot in prometheus/client_golang#1632 * process_collector: Add Platform-Specific Describe for processCollector by @​ying-jeanne in prometheus/client_golang#1625 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1635 * build(deps): bump the github-actions group with 4 updates by @​dependabot in prometheus/client_golang#1634 * Optionally print OM created lines by @​ArthurSens in prometheus/client_golang#1408 * process_collector: merge wasip1 and js into a single implementation by @​ying-jeanne in prometheus/client_golang#1644 * Merge release 1.20 to main by @​bwplotka in prometheus/client_golang#1647 * Add Arianna as maintainer 💪 by @​ArthurSens in prometheus/client_golang#1651 * test add headers round tripper by @​Manask322 in prometheus/client_golang#1657 * build(deps): bump github.com/klauspost/compress from 1.17.10 to 1.17.11 by @​dependabot in prometheus/client_golang#1668 * build(deps): bump golang.org/x/sys from 0.25.0 to 0.26.0 by @​dependabot in prometheus/client_golang#1669 * build(deps): bump github.com/prometheus/common from 0.59.1 to 0.60.1 by @​dependabot in prometheus/client_golang#1667 * build(deps): bump google.golang.org/protobuf from 1.34.2 to 1.35.1 by @​dependabot in prometheus/client_golang#1670 * Optimize BuildFQName function by @​jkroepke in prometheus/client_golang#1665 * fix: use injected now() instead of time.Now() in summary methods by @​imorph in prometheus/client_golang#1672 * process_collector: avoid a compiler warning on macOS (fixes #​1660) by @​mharbison72 in prometheus/client_golang#1675 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1674 * build(deps): bump the github-actions group across 1 directory with 3 updates by @​dependabot in prometheus/client_golang#1678 * [chore]: enable perfsprint linter by @​mmorel-35 in prometheus/client_golang#1676 * Duplicate of #​1662 by @​imorph in prometheus/client_golang#1673 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1679 * chore: enable usestdlibvars linter by @​mmorel-35 in prometheus/client_golang#1680 * Add: exponential backoff for CAS operations on floats by @​imorph in prometheus/client_golang#1661 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1683 * [1617] Add ConstnativeHistogram by @​shivanthzen in prometheus/client_golang#1654 * fix: replace fmt.Errorf with errors.New by @​kakkoyun in prometheus/client_golang#1689 * Add codeowners by @​kakkoyun in prometheus/client_golang#1688 * fix: add very small delay between observations in `TestHistogramAtomicObserve` by @​imorph in prometheus/client_golang#1691 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1692 * Fix: handle nil variableLabels in Desc.String() method and add tests for nil label values by @​kakkoyun in prometheus/client_golang#1687 * examples: Follow best practices and established naming conventions by @​lilic in prometheus/client_golang#1650 * setup OSSF Scorecard workflow by @​mmorel-35 in prometheus/client_golang#1432 * build(deps): bump google.golang.org/protobuf from 1.35.1 to 1.35.2 by @​dependabot in prometheus/client_golang#1697 * build(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 by @​dependabot in prometheus/client_golang#1696 * build(deps): bump the github-actions group with 5 updates by @​dependabot in prometheus/client_golang#1695 * update links to openmetrics to reference the v1.0.0 release by @​dashpole in prometheus/client_golang#1699 * build(deps): bump google.golang.org/protobuf from 1.35.2 to 1.36.1 by @​dependabot in prometheus/client_golang#1706 * build(deps): bump golang.org/x/sys from 0.27.0 to 0.28.0 by @​dependabot in prometheus/client_golang#1705 * build(deps): bump the github-actions group with 5 updates by @​dependabot in prometheus/client_golang#1707 * build(deps): bump github.com/prometheus/common from 0.60.1 to 0.61.0 by @​dependabot in prometheus/client_golang#1704 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1703 * Synchronize common files from prometheus/prometheus by @​prombot in prometheus/client_golang#1708 * Upgrade to prometheus/common 0.62.0 with breaking change by @​bwplotka in prometheus/client_golang#1712 * build(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 in /tutorials/whatsup by @​dependabot in prometheus/client_golang#1713 * docs: Add RELEASE.md for the release process by @​kakkoyun in prometheus/client_golang#1690 * tutorials/whatsup: Updated deps by @​bwplotka in prometheus/client_golang#1716 * process collector: Fixed pedantic registry failures on darwin with cgo. by @​bwplotka in prometheus/client_golang#1715 * Revert "ci: daggerize test and lint pipelines (#​1534)" by @​bwplotka in prometheus/client_golang#1717 * Cut 1.21.0-rc.0 by @​bwplotka in prometheus/client_golang#1718 * Cut 1.21 by @​bwplotka in prometheus/client_golang#1737 </details> #### New Contributors * @​parthlaw made their first contributi[https://github.com/prometheus/client_golang/pull/1606](https://github.com/prometheus/client_golang/pull/1606)l/1606 * @​mharbison72 made their first contributi[https://github.com/prometheus/client_golang/pull/1600](https://github.com/prometheus/client_golang/pull/1600)l/1600 * @​cuisongliu made their first contributi[https://github.com/prometheus/client_golang/pull/1513](https://github.com/prometheus/client_golang/pull/1513)l/1513 * @​ying-jeanne made their first contributi[https://github.com/prometheus/client_golang/pull/1626](https://github.com/prometheus/client_golang/pull/1626)l/1626 * @​Manask322 made their first contributi[https://github.com/prometheus/client_golang/pull/1657](https://github.com/prometheus/client_golang/pull/1657)l/1657 * @​jkroepke made their first contributi[https://github.com/prometheus/client_golang/pull/1665](https://github.com/prometheus/client_golang/pull/1665)l/1665 * @​imorph made their first contributi[https://github.com/prometheus/client_golang/pull/1672](https://github.com/prometheus/client_golang/pull/1672)l/1672 * @​mmorel-35 made their first contributi[https://github.com/prometheus/client_golang/pull/1676](https://github.com/prometheus/client_golang/pull/1676)l/1676 * @​shivanthzen made their first contributi[https://github.com/prometheus/client_golang/pull/1654](https://github.com/prometheus/client_golang/pull/1654)l/1654 * @​dashpole made their first contributi[https://github.com/prometheus/client_golang/pull/1699](https://github.com/prometheus/client_golang/pull/1699)l/1699 **Full Changelog**: prometheus/client_golang@v1.20.5...v1.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzYuMiIsInVwZGF0ZWRJblZlciI6IjM5LjE4NS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Merged
1 task
Merged
1 task
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #1591.
Given the clarity of the ticket, I proceeded directly with the fix rather than engaging in further discussion, but please let me know if there are any questions or concerns.
In this PR, I've refactored the Describe function to be platform-specific and added tests to ensure alignment between Describe and ProcessCollect for Linux and Windows. I've also included comments to help ensure future alignment between these functions. Also defaultCollectFn and defaultDescribeFn are added to standardise behaviour for unsupported platforms.
As this is my first contribution, I would really appreciate any feedback you may have. Thank you. @bwplotka @ArthurSens @kakkoyun