Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_is_zipfile Fix #10

Merged
merged 1 commit into from
Jul 31, 2023
Merged

_is_zipfile Fix #10

merged 1 commit into from
Jul 31, 2023

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Jul 31, 2023

_is_zipfile was throwing a "ValueError: I/O operation on closed file" for cases from files because the file was being closed

_is_zipfile was throwing a "ValueError: I/O operation on closed file" for cases from files
@swashko swashko requested review from cherbel and mehrinkiani July 31, 2023 23:36
@swashko swashko self-assigned this Jul 31, 2023
Copy link
Member

@cherbel cherbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚢

@swashko swashko merged commit 129fe35 into main Jul 31, 2023
@swashko swashko deleted the _is_zipfile-Fix branch July 31, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants