Handle invalid PyTorch files #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamfaisalkhan
approved these changes
Aug 8, 2023
| bad_pytorch = Modelscan() | ||
| bad_pytorch.scan_path(Path(f"{pytorch_file_path}/bad_pytorch.pt")) | ||
| assert bad_pytorch.issues.all_issues == [] | ||
| assert [error.scan_name for error in bad_pytorch.errors] == ["pytorch"] # type: ignore[attr-defined] |
There was a problem hiding this comment.
Not relevant to this PR. scan_name need to be defined as an attribute of the base Error class to avoid the type ignore. I will take care of it in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hugging Face model repository contains files with a PyTorch .pt extension which are actually PNG files, which trips the picklescan scanner. The code change handles such files as part of the PyTorch magic-number validation and reports them as scan errors instead of unhandled exceptions.
This is a port from mmaitre314/picklescan#19.