Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version flag to cli options #35

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Add version flag to cli options #35

merged 4 commits into from
Aug 11, 2023

Conversation

iamfaisalkhan
Copy link
Member

@iamfaisalkhan iamfaisalkhan commented Aug 9, 2023 •
edited
Loading

  • Update click options to add version flag. Both -v and --version option should work.
  • Update README to include the version option.

Close #32

@iamfaisalkhan iamfaisalkhan linked an issue Aug 9, 2023 that may be closed by this pull request
Add -v/--version cli flag to modelscan #32
Closed
mehrinkiani
mehrinkiani approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@mehrinkiani mehrinkiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@iamfaisalkhan iamfaisalkhan merged commit 0b6cb07 into main Aug 11, 2023
@iamfaisalkhan iamfaisalkhan deleted the 32-add-version-flag-to-modelscan branch August 11, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrinkiani mehrinkiani mehrinkiani approved these changes

@cherbel cherbel Awaiting requested review from cherbel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -v/--version cli flag to modelscan
2 participants
@iamfaisalkhan @mehrinkiani