create light-client-updates bucket #14266
Merged
+1,115
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rkapka
previously approved these changes
Jul 29, 2024
* Refactor get local payload * Fix go lint: new line
|
rkapka
reviewed
Aug 13, 2024
|
@rkapka do we want to have safety guards in the kv interface functions that check that an update is somewhat valid before saving it? for example, the important fields are not nil. |
rkapka
reviewed
Aug 16, 2024
There was a problem hiding this comment.
We should have a few test cases for LighClientUpdates:
startPeriod > endPeriod- error returnedstartPeriod == endPeriod- one update returnedstartPeriod > endPeriod:- all updates between
startPeriodandendPeriodare in the DB - all returned - some periods between
startPeriodandendPerioddon't have updates - existing updates returned startPeriodis earlier than the first update - return starting from first existing updateendPeriodis later than the first update - return up to the last update
- all updates between
|
Added tests to cover all the mentioned cases. |
|
@rkapka The |
rkapka
reviewed
Aug 22, 2024
This reverts commit 33c707f5bd164386449dc14ff27d95ad5f195161.
rkapka
approved these changes
Aug 22, 2024
james-prysm
pushed a commit
that referenced
this pull request
Sep 6, 2024
* create light-client-updates bucket * Electra committe validation for aggregate and proof (#14317) * Electra committe validation for aggregate and proof * review * update comments * Refactor get local payload (#14327) * Refactor get local payload * Fix go lint: new line * add lightclient db kv functions * lightclient db tests * move blockchain/lightclient.go to core/light-client package * add comparison check for start and end period * create testing/utils/lightcilent.go * lightclient db tests * fix imports and usages * fix imports and usages in process_block_helpers * fix bazel dependencies * remove unnecessary nil check * add more tests for lightclient kv functions * refactor tests * refactor kv.LightClientUpdates * fix db to return every update that is available in the requested range * run gazzele fix * return empty map in case of empty db * fix goimports errors * goimports * Revert "Auxiliary commit to revert individual files from aa7ce6f" This reverts commit 33c707f5bd164386449dc14ff27d95ad5f195161. --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: terence <terence@prysmaticlabs.com> Co-authored-by: rkapka <radoslaw.kapka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR intends to address the needs for a light client updates database per #12991 .
This is needed to support light clients.
Which issues(s) does this PR fix?
Partially addresses #12991