-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (light client)add new consensus types for Electra #14527
Merged
rkapka
merged 19 commits into
prysmaticlabs:develop
from
rupam-04:electra/consensus-types
Oct 15, 2024
Merged
feat: (light client)add new consensus types for Electra #14527
rkapka
merged 19 commits into
prysmaticlabs:develop
from
rupam-04:electra/consensus-types
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupam-04
commented
Oct 11, 2024
rupam-04
commented
Oct 13, 2024
rkapka
requested changes
Oct 14, 2024
Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
This reverts commit 5ceaaf5.
rkapka
approved these changes
Oct 15, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Oct 15, 2024
dc91c96
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds new consensus types for Electra. This is necessary as depth of sync committee branch changed from 5 in Deneb to 6 in Electra.
LightClientBootstrapElectra
proto struct with depth of sync committee branch set to 6LightClientUpdateElectra
proto struct with depth of sync committee branch set to 6bootstrapElectra
struct inconsensus-types
withcurrentSyncCommitteeBranch
set tointerfaces.LightClientSyncCommitteeBranchElectra
LightClientBootstrapElectra
andLightClientUpdateElectra
toBUILD.bazel
to update SSZ methodsupdateElectra
struct inconsensus-types
withnextSyncCommitteeBranch
set tointerfaces.LightClientSyncCommitteeBranchElectra
NextSyncCommitteeBranchElectra()
toLightClientBootstrap
andLightClientUpdate
interfacesWhich issues(s) does this PR fix?
Needed for #12991
Other notes for review
Acknowledgements