fix TODOs for events #14570
Merged
fix TODOs for events #14570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupam-04
requested review from
kasey,
nalepae and
james-prysm
and removed request for
a team
|
Looks like the build fails. Please fix |
Hi, the build is supposed to fail because there are some errors(or you could say WIP) in the |
rkapka
requested changes
Oct 24, 2024
rkapka
reviewed
Oct 25, 2024
rkapka
reviewed
Oct 25, 2024
rkapka
reviewed
Oct 25, 2024
rkapka
reviewed
Oct 25, 2024
Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
approved these changes
Oct 25, 2024
rkapka
added a commit
that referenced
this pull request
Oct 26, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Oct 28, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Oct 28, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Oct 28, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 3, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 3, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 20, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 20, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 25, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 25, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 28, 2024
* Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * align changelog with develop branch * bzl * LC Updates by Range to read from DB (#14531) * change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com> * Light Client: Electra finality branch (#14597) * extract from lc-p2p branch * generate code * trixy's review * test fixes * fix issue in `CreateDefaultLightClientUpdate` function (#14585) * use state in `CreateDefaultLightClientUpdate` * lint * add `stateSlot` to `update.go` structs * Revert "add `stateSlot` to `update.go` structs" This reverts commit 84468ae. * set sync committee based on attestedHeader in updateElectra * dependencies * add check to `SetNextSyncCommitteeBranchElectra` * add detailed error messages to `update.go` * dependencies * fix `createDefaultLightClientUpdate` * deps * fix errors * deps * revert error messages * deps * save update * save update * move create lc bootstrap to core * bootstrap db * save bootstrap * testing * testing progress * testing * testing * checkpoint working * set genesis time manually * savebootstrap tests * conflicts resolved * fix lint issues * fix lint issues * address reviews * revert changes to consensus-types/lc/updates.go * add lightClientHeaderToJSON support for Electra --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com> Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Inspector-Butters <mohamadbastin@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 29, 2024
* fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 29, 2024
* change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com>
rkapka
added a commit
that referenced
this pull request
Nov 29, 2024
* Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * align changelog with develop branch * bzl * LC Updates by Range to read from DB (#14531) * change updatebyrange * lcupdateresponse from consensus * range altair test * range forks tests * finish tests * changelog * remove unused functions * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/light-client/handlers.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * use slice instead of array * refactor code * refactor tests * refactor tests * refactor tests * add configCleanup in tests * refactor missing updates testcase * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * change updatesByRange to use new structs * Light Client - use the new consensus types (#14549) * in progress * completed logic * var name * additional logic changes * fix createDefaultLightClientUpdate * empty fields * unused context * fix rpc/helpers_test * Return the correct light client payload proof (#14565) * Return the correct payload proof * changelog <3 * merge * Set fields of wrapped proto object in light client setters (#14573) * Set fields of wrapped proto object in light client setters * changelog <3 * fixing tests... * core tests fixed * kv tests fixed * fix TODOs for events (#14570) * fix TODOs for events * address review comments * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * Update beacon-chain/rpc/eth/events/events.go Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * nits --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> * tests fixed * remove unused function * fix slice capacity * address issues * address issues * fix circular import error * remove unused func * fix changelog --------- Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com> * Light Client: Electra finality branch (#14597) * extract from lc-p2p branch * generate code * trixy's review * test fixes * fix issue in `CreateDefaultLightClientUpdate` function (#14585) * use state in `CreateDefaultLightClientUpdate` * lint * add `stateSlot` to `update.go` structs * Revert "add `stateSlot` to `update.go` structs" This reverts commit 84468ae. * set sync committee based on attestedHeader in updateElectra * dependencies * add check to `SetNextSyncCommitteeBranchElectra` * add detailed error messages to `update.go` * dependencies * fix `createDefaultLightClientUpdate` * deps * fix errors * deps * revert error messages * deps * save update * save update * move create lc bootstrap to core * bootstrap db * save bootstrap * testing * testing progress * testing * testing * checkpoint working * set genesis time manually * savebootstrap tests * conflicts resolved * fix lint issues * fix lint issues * address reviews * revert changes to consensus-types/lc/updates.go * add lightClientHeaderToJSON support for Electra --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: Rupam Dey <rpmdey2004@gmail.com> Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com> Co-authored-by: Inspector-Butters <mohamadbastin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR addresses the TODOs that were mentioned in #14549
Which issues(s) does this PR fix?
Part of #12991
Other notes for review
Acknowledgements