process lc finality update only for new finalized checkpoints #14713
+75
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Dec 11, 2024
rkapka
reviewed
Dec 12, 2024
rkapka
reviewed
Dec 12, 2024
rkapka
reviewed
Dec 12, 2024
Co-authored-by: Radosław Kapka <radoslaw.kapka@gmail.com>
rkapka
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Process light client finality updates only for new finalized checkpoints instead of doing it for every block. Also adds an
EmptyExecutionPayloadHeader()function to use inBlockToLightClientHeader()instead of hardcoding the valuesWhich issues(s) does this PR fix?
Part of #12991
Other notes for review
Acknowledgements