Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add clang-formatter lint workflow for proto files #14831

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Jan 27, 2025

What type of PR is this?

Other

What does this PR do? Why is it needed?

As title describes, this PR introduces a github workflow to require that protobuf files are
formatted appropriately.

Summary of changes:

  • Format all proto files
  • Add github workflow to require protofiles are formatted properly
  • Run ./hack/update-go-pb.sh

Which issues(s) does this PR fix?

This is a followup to #14818 where we updated protoc, but didn't update any of the pb.go files.

Other notes for review

Acknowledgements

@prestonvanloon prestonvanloon requested a review from a team as a code owner January 27, 2025 19:01
@prestonvanloon prestonvanloon added this pull request to the merge queue Jan 27, 2025
Merged via the queue into develop with commit b4220e3 Jan 27, 2025
17 checks passed
@prestonvanloon prestonvanloon deleted the clang-pb-linter branch January 27, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants