Remove Fulu block and state. #14905
Remove Fulu block and state. #14905
Conversation
nalepae
force-pushed
the
remove-fulu-block-state
branch
from
b037b20 to
7c00886
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
2 times, most recently
from
0b3075a to
5c8bcee
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
11 times, most recently
from
1afc93c to
f7774b4
Compare
nalepae
force-pushed
the
remove-fulu-block-state
branch
from
f7774b4 to
a2d3db0
Compare
| @@ -636,10 +556,10 @@ func ProtobufBeaconStateElectra(s interface{}) (*ethpb.BeaconStateElectra, error | |||
|
|
|||
| // ProtobufBeaconStateFulu transforms an input into beacon state Fulu in the form of protobuf. | |||
| // Error is returned if the input is not type protobuf beacon state. | |||
| func ProtobufBeaconStateFulu(s interface{}) (*ethpb.BeaconStateFulu, error) { | |||
| pbState, ok := s.(*ethpb.BeaconStateFulu) | |||
| func ProtobufBeaconStateFulu(s interface{}) (*ethpb.BeaconStateElectra, error) { | |||
There was a problem hiding this comment.
Is this function needed? Can't we alias ProtobufBeaconStateElectra?
| // Execution requests. | ||
| ethereum.engine.v1.ExecutionRequests execution_requests = 13; | ||
| } | ||
|
|
||
| message SignedBlindedBeaconBlockFulu { | ||
| // The unsigned blinded beacon block itself. | ||
| BlindedBeaconBlockFulu message = 1; |
There was a problem hiding this comment.
I can't find the definition for some reason, but is BlindedBeaconBlockFulu needed? You did remove the full block
There was a problem hiding this comment.
The definition of BlindedBeaconBlockFulu is here.
There was a problem hiding this comment.
- In
produceBlockV3, to produce a non blinded block, we need to compare type against*eth.GenericBeaconBlock_Fulu. *eth.GenericBeaconBlock_Fuluis created here and is of typeBeaconBlockContentsFulu(and not of typeBeaconBlockFulu).
- In
produceBlockV3, to produce a blinded block, we need to compare type against*eth.GenericBeaconBlock_BlindedFulu. *eth.GenericBeaconBlock_BlindedFuluis created here and is of typeBlindedBeaconBlockFulu.
==> I need both BlindedBeaconBlockFulu and BeaconBlockContentsFulu, but I don't need BlindedBeaconBlockFulu.
There was a problem hiding this comment.
We do all this to set version.String(version.Fulu)) on Fulu blocks.
(Even if the shape of the struct is exactly the same than Electra block.)
| BlobKzgCommitments []string `json:"blob_kzg_commitments"` | ||
| ExecutionRequests *ExecutionRequests `json:"execution_requests"` | ||
| } | ||
|
|
||
| type BlindedBeaconBlockFulu struct { |
There was a problem hiding this comment.
Is this needed? Se comment in proto/prysm/v1alpha1/beacon_block.proto
There was a problem hiding this comment.
See #14905 (comment)
What type of PR is this?
Other
What does this PR do? Why is it needed?
Remove as much as Fulu proto definitions. (Including Fulu block and state.)
How I realized this PR:
blk.Versionreturnedelectrafor a Fulu block.3.(being able to differentiate versions), I had to re-add some Fulu structs, even if they are the same than the Electra ones. Only the minimal amount of structs have been added.Acknowledgements