builder: api calls should have appropriate headers #14961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
jtraglia
approved these changes
Feb 19, 2025
rkapka
approved these changes
Feb 20, 2025
rkapka
pushed a commit
that referenced
this pull request
Mar 19, 2025
* adding correct headers when posting for validator registration on builder api * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
the register validator builder API call currently isn't providing the correct content type and accept headers when it should be. This PR adds them and updates the unit test. In the future when we accept ssz this will need to change
Which issues(s) does this PR fix?
Fixes #14960
Other notes for review
Acknowledgements