tracing: Add otel tracer transport to all http clients #14972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This may not be the best solution as the http client is defined in many places. There should be a canoncial http client with the proper setup.
james-prysm
approved these changes
Feb 21, 2025
Yeah, we should have just one http client. I think that would be good |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rkapka
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Fixed otelhttp client setups. Note: This may not be the best solution as the http client is defined in many places. There should be a canoncial http client with the proper setup. * Changelog fragment * go mod tidy and gazelle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Allows for tracing headers to be sent during http requests such that spans across the validator <> beacon-chain can be connected in the tracing graphs.
Which issues(s) does this PR fix?
Other notes for review
Supersedes #14825
Acknowledgements