fixing electra committee logs #14992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
dB2510
reviewed
Feb 27, 2025
| logTest "github.com/sirupsen/logrus/hooks/test" | ||
| ) | ||
|
|
||
| func TestLogSubmittedAtts(t *testing.T) { |
There was a problem hiding this comment.
can we have one more testcase here where we'll have more than one committee index as part of committeeIndices array log?
There was a problem hiding this comment.
You can't propose an attestation or aggregate with multiple committee bits because the proposing validator is assigned to only one committee.
rkapka
requested changes
Mar 3, 2025
validator/client/log_test.go
Outdated
Comment on lines
35
to
36
| att.CommitteeBits[0] = 44 | ||
| att.CommitteeBits[1] = 73 |
There was a problem hiding this comment.
This is not how you set bits on a bitlist. This way you are modifying a whole byte at once. You should use the SetBitAt method. That way you can control exactly which bit is set.
| logTest "github.com/sirupsen/logrus/hooks/test" | ||
| ) | ||
|
|
||
| func TestLogSubmittedAtts(t *testing.T) { |
There was a problem hiding this comment.
You can't propose an attestation or aggregate with multiple committee bits because the proposing validator is assigned to only one committee.
rkapka
approved these changes
Mar 3, 2025
rkapka
pushed a commit
that referenced
this pull request
Mar 19, 2025
* fixing logs * fixing tests * addressing feedback * fixing tests based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Electra attestation logs have been printing out incorrect indicies
this pr solves the issue by correctly using the committee bits to get the committee index for electra attestation logs
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements