Fix Block Decoding During State Deletion #15008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
approved these changes
Mar 4, 2025
rkapka
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Fix Block Decoding * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
During state deletion, we have a potential code path which unmarshals a block in the event the state summary cannot be found. This code path was only unmarshalling for phase0 blocks, every alternate fork type would fail with a ssz error. This PR fixes it and adds in a regression test.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements