Validate blob sidecar: check bad parent first #15013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
check-bad-parent-first
branch
from
76b0470 to
debaf59
Compare
prestonvanloon
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly a cosmetic change to emit the correct log when receiving a blob sidecar that builds on an invalid parent. The end result remains the same—the peer gets penalized.
Currently, if a blob sidecar builds on top of an invalid parent, the following happens:
SidecarParentSeenreturnsnilValidProposerSignaturereturns "block not found"What we want instead is for
SidecarParentSeento returnnil, but forSidecarParentValidto return an error subsequently. This ensures the logs are emitted in the correct order, making them less confusing to read.Note to the reviewer: I don’t see any downside to switching the order of validation.
SidecarParentValidis a cheap check, and it’s unclear why it was always placed afterValidProposerSignature. The original intent is not obvious