Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimistic check to /eth/v1/validator/sync_committee_contribution #15022

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Mar 6, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

according to https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Validator/produceSyncCommitteeContribution we should have an optimistic check on the sync_committee_contribution endpoint and error out with a 503 if so

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

@james-prysm james-prysm added Bug Something isn't working API Api related tasks labels Mar 6, 2025
@james-prysm james-prysm requested a review from a team as a code owner March 6, 2025 20:56
@james-prysm james-prysm requested review from kasey, potuz and dB2510 March 6, 2025 20:56
@james-prysm james-prysm enabled auto-merge March 6, 2025 21:54
@james-prysm james-prysm disabled auto-merge March 6, 2025 21:55
@james-prysm james-prysm enabled auto-merge March 6, 2025 22:06
@james-prysm james-prysm added this pull request to the merge queue Mar 6, 2025
Merged via the queue into develop with commit 0b6bea4 Mar 6, 2025
17 checks passed
@james-prysm james-prysm deleted the add-op-check-sync-committee branch March 6, 2025 22:57
rkapka pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants