Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing e2e builder gas limit #15025

Merged
merged 2 commits into from
Mar 7, 2025
Merged

fixing e2e builder gas limit #15025

merged 2 commits into from
Mar 7, 2025

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Mar 7, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
This PR fixes some e2e bugs introduced by #14858 due to not setting the gas limit correctly on the execution client via --miner.gaslimit flag.
This PR also fixes an issue writing the header code after json encoding.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

@james-prysm james-prysm added Bug Something isn't working E2E Tests End-To-End testing Builder PR or issue that supports builder related work labels Mar 7, 2025
@james-prysm james-prysm requested a review from a team as a code owner March 7, 2025 18:16
@james-prysm james-prysm requested review from kasey, nalepae and rkapka March 7, 2025 18:16
@prestonvanloon
Copy link
Member

Please run gofmt

@prestonvanloon prestonvanloon enabled auto-merge March 7, 2025 18:37
@prestonvanloon prestonvanloon added this pull request to the merge queue Mar 7, 2025
Merged via the queue into develop with commit 4e41d5c Mar 7, 2025
17 checks passed
@prestonvanloon prestonvanloon deleted the fix-builder-e2e branch March 7, 2025 19:08
rkapka pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Builder PR or issue that supports builder related work E2E Tests End-To-End testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants